Hi Erik, Thanks for looking over my patch.> > * Account for the updates to UTF-8 on Windows. > > One of these updates, added an "#ifdef _WIN32" to the file > src/share/win_utf8_io/win_utf8_io.c. Is this really necessary? Is > it not possible to just not include that file when not compiling > for windows?You're right. I changed my patch to only specify "-lwin_utf8_io" under Windows.> Those Makefile variables are somewhat non-standard. Is there any > reason you chose CCFLACGS and CCCFLAGS instead of the more usual > CFLAGS and CXXFLAGS?I usually see the C++ compiler as CXX, while FLAC uses CCC. I suppose that threw me off. Updated my patch to use CFLAGS and CXXFLAGS.> I would appreciate it if you could update you patch to address > the issues I raised above.I attached a revised patch. -H -------------- next part -------------- A non-text attachment was scrubbed... Name: flac-update-Makefile-lite-20140623.patch.gz Type: application/x-gzip Size: 4396 bytes Desc: not available Url : http://lists.xiph.org/pipermail/flac-dev/attachments/20140623/4a53d052/attachment.bin
Evan Ramos wrote:> I attached a revised patch.Patch applied, thanks! Out of curiosity, what platform and compiler are you using? I ask, because the Makefile.lite system tries to build the project in src/utils/flactimer under Linux, but that program is meant to be windows only. Cheers, Erik -- ---------------------------------------------------------------------- Erik de Castro Lopo http://www.mega-nerd.com/
Erik de Castro Lopo wrote:> Patch applied, thanks!Glad to help!> Out of curiosity, what platform and compiler are you using? I ask, > because the Makefile.lite system tries to build the project in > src/utils/flactimer under Linux, but that program is meant to be > windows only.I use Windows as a host (I have Win7 x64 and Win8.1 x64 machines). My compilers of choice are MinGW (mainline) and MinGW-w64 (targeting both i686 and x86_64). For reference, I've documented how I set up my build system on my project's wiki: http://wiki.eduke32.com/wiki/Building_EDuke32_on_Windows -H