flac dev - May 2014 - replace -Wextra with -W

The attached small configury patch replaces -Wextra with -W in the
main CFLAGS and CXXFLAGS assignments. A few lines after them, -Wextra
is conditionally added already with XIPH_ADD_CFLAGS([-Wextra]), so
this allows build using older compilers.

Regards.

--
O.S.
-------------- next part --------------
diff --git a/configure.ac b/configure.ac
index 6d0fa00..cc5a247 100644
--- a/configure.ac
+++ b/configure.ac
@@ -392,8 +392,8 @@ fi
 XIPH_GCC_VERSION
 
 if test x$ac_cv_c_compiler_gnu = xyes ; then
-	CFLAGS="$CFLAGS -Wall -Wextra -Wstrict-prototypes -Wmissing-prototypes
-Waggregate-return -Wcast-align -Wnested-externs -Wshadow -Wundef
-Wmissing-declarations -Wunreachable-code " # -Wcast-qual
-Wbad-function-cast -Wwrite-strings -Winline -Wconversion
-	CXXFLAGS="$CXXFLAGS -Wall -Wextra -Wcast-align -Wshadow -Wwrite-strings
-Wctor-dtor-privacy -Wnon-virtual-dtor -Wreorder -Wsign-promo -Wundef
-Wunreachable-code " # -Wcast-qual -Wbad-function-cast -Wwrite-strings
-Woverloaded-virtual -Wmissing-declarations
+	CFLAGS="$CFLAGS -Wall -W -Wstrict-prototypes -Wmissing-prototypes
-Waggregate-return -Wcast-align -Wnested-externs -Wshadow -Wundef
-Wmissing-declarations -Wunreachable-code " # -Wcast-qual
-Wbad-function-cast -Wwrite-strings -Winline -Wconversion
+	CXXFLAGS="$CXXFLAGS -Wall -W -Wcast-align -Wshadow -Wwrite-strings
-Wctor-dtor-privacy -Wnon-virtual-dtor -Wreorder -Wsign-promo -Wundef
-Wunreachable-code " # -Wcast-qual -Wbad-function-cast -Wwrite-strings
-Woverloaded-virtual -Wmissing-declarations
 
 
 	XIPH_ADD_CFLAGS([-Wdeclaration-after-statement])

Ozkan Sezer wrote:
> The attached small configury patch replaces -Wextra with -W in the
> main CFLAGS and CXXFLAGS assignments. A few lines after them, -Wextra
> is conditionally added already with XIPH_ADD_CFLAGS([-Wextra]), so
> this allows build using older compilers.
Which older compilers do not support -Wextra?

Erik
-- 
----------------------------------------------------------------------
Erik de Castro Lopo
http://www.mega-nerd.com/

On 6/15/14, Erik de Castro Lopo <mle+la at mega-nerd.com>
wrote:
> Ozkan Sezer wrote:
>
>> The attached small configury patch replaces -Wextra with -W in the
>> main CFLAGS and CXXFLAGS assignments. A few lines after them, -Wextra
>> is conditionally added already with XIPH_ADD_CFLAGS([-Wextra]), so
>> this allows build using older compilers.
>
> Which older compilers do not support -Wextra?
gcc-3.3 and older.

--
O.S.