Janne Hyv?rinen wrote:> I thought Ben Allison would have made a patch. Here's a patch for this. > I suppose we were all blind at first for the cause.Applied thanks. I'd now like to look at the 2/4Gig off_t issue in your original support_2gb_output patch. Unlike your original patch, you will have to avoid touchng anything in the directories: include/FLAC include/FLAC++ as these are the public API headers and we don't want to change the API in this release. Cheers, Erik -- ---------------------------------------------------------------------- Erik de Castro Lopo http://www.mega-nerd.com/
On 12.3.2013 10:52, Erik de Castro Lopo wrote:> I'd now like to look at the 2/4Gig off_t issue in your original > support_2gb_output patch. Unlike your original patch, you will > have to avoid touchng anything in the directories: > > include/FLAC > include/FLAC++ > > as these are the public API headers and we don't want to change the API > in this release. > > Cheers, > ErikI re-did the patch with these limitations. I also noticed I had left stat() and fstat() functions unfixed previously. And encoder was limited to 4G in many places when printing status info. -------------- next part -------------- A non-text attachment was scrubbed... Name: updated_2gb_fix.zip Type: application/x-zip-compressed Size: 11876 bytes Desc: not available Url : http://lists.xiph.org/pipermail/flac-dev/attachments/20130312/220af1d9/attachment.bin
Janne Hyv?rinen wrote:> I re-did the patch with these limitations. I also noticed I had left > stat() and fstat() functions unfixed previously. And encoder was limited > to 4G in many places when printing status info.Unfortunately, this patch did not apply cleanly. There were two problems; one in src/flac/main.c that was easy and obvious to fix, the other in include/share/compat.h. Can you please send your version of that file? Thanks, Erik -- ---------------------------------------------------------------------- Erik de Castro Lopo http://www.mega-nerd.com/