rsync - Jun 2019 - Allow "--in-place" as an alternative option name for "--inplace"

Hi!

As I commonly spell --inplace as --in-place, I'd like to suggest this
simple patch:


commit 5689f99b702788044a45e13582559832cf986328
Author: Jan-Benedict Glaw <jbglaw at lug-owl.de>
Date:   Wed Jun 26 22:49:31 2019 +0200

    Allow "--in-place" as an alternative option name for
"--inplace".

diff --git a/options.c b/options.c
index e5b0cb68..7ff0c51d 100644
--- a/options.c
+++ b/options.c
@@ -926,6 +926,7 @@ static struct poptOption long_options[] = {
   {"no-S",             0,  POPT_ARG_VAL,    &sparse_files, 0, 0,
0 },
   {"preallocate",      0,  POPT_ARG_NONE,   &preallocate_files,
0, 0, 0},
   {"inplace",          0,  POPT_ARG_VAL,    &inplace, 1, 0, 0 },
+  {"in-place",         0,  POPT_ARG_VAL,    &inplace, 1, 0, 0 },
   {"no-inplace",       0,  POPT_ARG_VAL,    &inplace, 0, 0, 0 },
   {"append",           0,  POPT_ARG_NONE,   0, OPT_APPEND, 0, 0 },
   {"append-verify",    0,  POPT_ARG_VAL,    &append_mode, 2, 0, 0
},



Thanks,
  Jan-Benedict
-- 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL:
<http://lists.samba.org/pipermail/rsync/attachments/20190626/9f637af1/signature.sig>

On Jun 26, 2019, at 2:53 PM, Jan-Benedict Glaw via rsync <rsync at
lists.samba.org> wrote:
> 
> As I commonly spell --inplace as --in-place, I'd like to suggest this
simple patch:
If we?re going to do that add --remove-source and --delete-source as aliases for
whatever the command is I have to look up every single time.

I mean, really, delete-source is the OBVIOUS flag as it matches with many other
flags...

-- 
Hey kids, shake it loose together the spotlight's hitting something
That's been known to change the weather we'll kill the fatted calf
tonight So stick around you're gonna hear electric music: Solid walls of
sound

> On Jun 26, 2019, at 2:53 PM, Jan-Benedict Glaw via rsync <
rsync at lists.samba.org> wrote:
> > As I commonly spell --inplace as --in-place, I'd like to suggest
this
simple patch:

On Wed, Jun 26, 2019 at 7:29 PM @lbutlr via rsync <rsync at
lists.samba.org>
wrote:
> If we?re going to do that add --remove-source and --delete-source as
aliases for whatever the command is I have to look up every single time.

The --remove-* options are not named --delete-* because they happen on the
sending side, not the receiving side. This makes things like the daemon
"refuse options" setting easier as you can easily specify exactly what
you
want to refuse via wildcards (such as "remove-*" or
"delete-*").

If you have your own favorite option names, feel free to specify them in
the ~/.popt file:

rsync alias --in-place --inplace
> rsync alias --srcdel --remove-source-files
> rsync alias --delete-source --remove-source-files

..wayne..
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.samba.org/pipermail/rsync/attachments/20200405/11efd8fb/attachment.htm>