samba - Feb 2019 - AD-DC samba_gpoupdate failing

Hi,
I just upgraded to 4.8.9 and decided to give the samba_gpoupdate feature a
whirl.
However, it fails.
The line that's failing is "gpos =
ads.get_gpo_list(creds.get_username())"
returning None.

This is probably a failure, since it should otherwise return an empty list
(if there were no gpos to return).  But there is no output to indicate what
may be failing.
I have  setup of three redundant domain controllers, all of them similarly
failing. Any thought on this, before I start digging around inside gpo.so
in the python module dir?


-- 
Kv,
Kristján Valur Jónsson, RVX

On Mon, 25 Feb 2019 12:56:59 +0000
Kristján Valur Jónsson via samba <samba at lists.samba.org> wrote:
> Hi,
> I just upgraded to 4.8.9 and decided to give the samba_gpoupdate
> feature a whirl.
> However, it fails.
> The line that's failing is "gpos >
ads.get_gpo_list(creds.get_username())" returning None.
> 
> This is probably a failure, since it should otherwise return an empty
> list (if there were no gpos to return).  But there is no output to
> indicate what may be failing.
> I have  setup of three redundant domain controllers, all of them
> similarly failing. Any thought on this, before I start digging around
> inside gpo.so in the python module dir?
> 
> 
It was renamed to 'samba_gpudate' from 4.9.0, there were other changes
as well, perhaps testing 4.9.x would be a good idea.

Rowland

Well, I had a look at the python bindings and the error handling was in
shambles.
  I fixed libgpo/pygpo.c and I now get:
    gpos = ads.get_gpo_list(creds.get_username())
SystemError: Failed to get machine token for 'DC01$' (CN=DC01,OU=Domain
Controllers,DC=rvx,DC=is)

(the failing call is  status = gp_get_machine_token(self->ads_ptr, frame,
dn,
                                              &token);

I'm a former python core dev, so I know a bit about python c code.  I've
fixed what I could find there, and will create a pull request.  Meanwhile,
do you know why this may be failing?  The DN does exist.
K



On Mon, 25 Feb 2019 at 13:10, Rowland Penny via samba <samba at
lists.samba.org>
wrote:
> On Mon, 25 Feb 2019 12:56:59 +0000
> Kristján Valur Jónsson via samba <samba at lists.samba.org> wrote:
>
> > Hi,
> > I just upgraded to 4.8.9 and decided to give the samba_gpoupdate
> > feature a whirl.
> > However, it fails.
> > The line that's failing is "gpos > >
ads.get_gpo_list(creds.get_username())" returning None.
> >
> > This is probably a failure, since it should otherwise return an empty
> > list (if there were no gpos to return).  But there is no output to
> > indicate what may be failing.
> > I have  setup of three redundant domain controllers, all of them
> > similarly failing. Any thought on this, before I start digging around
> > inside gpo.so in the python module dir?
> >
> >
>
> It was renamed to 'samba_gpudate' from 4.9.0, there were other
changes
> as well, perhaps testing 4.9.x would be a good idea.
>
> Rowland
>
> --
> To unsubscribe from this list go to the following URL and read the
> instructions:  https://lists.samba.org/mailman/options/samba
>

-- 
Kv,
Kristján Valur Jónsson, RVX