dovecot - Jul 2020 - To field was not correct indexed by FTS

On Mon, Jul 20, 2020 at 20:24:13 +0900, TACHIBANA Masashi
wrote:
> Hi,
> 
> I'm Tachibana.
> Additionally, I found below:
> 
> dovecot/src/plugins/fts/fts-build-mail.c:
> 
>     187                 i_debug("@@@@@ befor address
parse:%s",hdr->full_value);
>     188
>     189                 addr =
message_address_parse(pool_datastack_create(),
>     190                                              hdr->full_value,
>     191                                             
hdr->full_value_len,
>     192                                              UINT_MAX, 0);
>     193                 str = t_str_new(hdr->full_value_len);
>     194                 message_address_write(str, addr);
>     195
>     196                 i_debug("@@@@@ after address
parse:%s",str_data(str));
> 
> Mail addresses were deleted when passed message_address_parse().
> So this debug logs came like following:
> 
> Debug: @@@@@ befor address parse:uesr1 <user1 at example.com>
> Debug: @@@@@ after address parse:uesr1 <user1 at example.com>
> Debug: @@@@@ data:uesr1 <user1 at example.com>
> Debug: @@@@@ befor address parse:Yamada Taro <yamada at
example.com>,user2 at example.com <user2 at example.com>, user3 at
example.com <user3 at example.com>, user4 desu <user4 at
example.com>
> Debug: @@@@@ after address parse:"Yamada Taro" <yamada at
example.com>, <user2 at example.com>
Thanks for the report.  I reproduced it locally, but I'm not sure what is
causing it yet.

Jeff.
> Debug: @@@@@ data:"Yamada Taro" <yamada at example.com>,
<user2 at example.com>
> Debug: @@@@@ tmp_value:"Yamada Taro" <yamada at
example.com>, <user2 at example.com>
> 
> 
> Regards,
> 
> ----- Original Message -----
> > Hi,
> > 
> > This To field was not correct indexed by FTS.
> > 
> > To: Yamada Taro <yamada at
example.com>,=?UTF-8?B?dXNlcjJAZXhhbXBsZS5jb20=?= <user2 at
example.com>, =?UTF-8?B?dXNlcjNAZXhhbXBsZS5jb20=?= <user3 at
example.com>,
> > 	user4 desu <user4 at example.com>
> > 
> > --> Yamada Taro  <yamada at example.com> , user2 at
example.com
> > 
> > And follow was correct indexed by FTS
> > 
> > To: Yamada Taro <yamada at example.com>,"user2 at
example.com" <user2 at example.com>, "user3 at example.com"
<user3 at example.com>,
> > 	user4 desu <user4 at example.com>
> > 
> > --> Yamada Taro  <yamada at example.com> , user2 at
example.com <user2 at example.com> , user3 at example.com  <user3 at
example.com> ,  user4 desu  <user4 at example.com>
> > 
> > 
> > Any hint?
> > 
> > --
> > TACHIBANA Masashi  QUALITIA CO., LTD.
> > mailto:tachibana at qualitia.co.jp
> > 
> > ??????????
> > https://www.qualitia.co.jp/
> > 
> --
> TACHIBANA Masashi  QUALITIA CO., LTD.
> mailto:tachibana at qualitia.co.jp
> 
> ??????????
> https://www.qualitia.co.jp/
> 
> 
-- 
Intellectuals solve problems; geniuses prevent them
		- Albert Einstein

On Mon, Jul 20, 2020 at 09:43:12 -0400, Josef 'Jeff' Sipek
wrote:
> On Mon, Jul 20, 2020 at 20:24:13 +0900, TACHIBANA Masashi wrote:
...
> Thanks for the report.  I reproduced it locally, but I'm not sure what
is
> causing it yet.
Alright, it is actually a parsing bug.  The problem seems to be when the
code encounters a "name <address>" format where the name is a
valid address.
This accidentally makes the parser stop parsing - making any additional
addresses ignored.

E.g.,

    test at example.com <test at example.com>, Name <other at
example.com>

The parser stops after the first address's name thinking it is just a bare
address (without a name).  That is, after the first loop iterating while
parsing, the "cursor" is at the first space and not at the comma.

                                       /- parsing should stop here
                                       v
    test at example.com <test at example.com>, Name <other at
example.com>
                    ^
                    `- parsing stops here

This is obviously wrong.  I'll have to dig in more to figure out what it
will take to fix this.

Thanks again,

Jeff.

-- 
FreeBSD 12.1

Hi,

Thank you for your reply.

I hope this bug to be fixed soon. :)
Thank you.

Tachibana

----- Original Message -----
> On Mon, Jul 20, 2020 at 09:43:12 -0400, Josef 'Jeff' Sipek wrote:
> > On Mon, Jul 20, 2020 at 20:24:13 +0900, TACHIBANA Masashi wrote:
> ...
> > Thanks for the report.  I reproduced it locally, but I'm not sure
what is
> > causing it yet.
> 
> Alright, it is actually a parsing bug.  The problem seems to be when the
> code encounters a "name <address>" format where the name is
a valid address.
> This accidentally makes the parser stop parsing - making any additional
> addresses ignored.
> 
> E.g.,
> 
>     test at example.com <test at example.com>, Name <other at
example.com>
> 
> The parser stops after the first address's name thinking it is just a
bare
> address (without a name).  That is, after the first loop iterating while
> parsing, the "cursor" is at the first space and not at the comma.
> 
>                                        /- parsing should stop here
>                                        v
>     test at example.com <test at example.com>, Name <other at
example.com>
>                     ^
>                     `- parsing stops here
> 
> This is obviously wrong.  I'll have to dig in more to figure out what
it
> will take to fix this.
> 
> Thanks again,
> 
> Jeff.
> 
> -- 
> FreeBSD 12.1
> 
--
TACHIBANA Masashi  QUALITIA CO., LTD.
mailto:tachibana at qualitia.co.jp

??????????
https://www.qualitia.co.jp/