Tomáš Golembiovský
2020-Jan-16 15:05 UTC
[Libguestfs] [PATCH v2] add versioned directory for guest agent on EL8
There was no source directory for EL8 guest agent (only EL6 and EL7). RHBZ#1791802 Signed-off-by: Tomáš Golembiovský <tgolembi@redhat.com> --- v2v/windows_virtio.ml | 1 + 1 file changed, 1 insertion(+) diff --git a/v2v/windows_virtio.ml b/v2v/windows_virtio.ml index 5ec7664b..86bc8c0a 100644 --- a/v2v/windows_virtio.ml +++ b/v2v/windows_virtio.ml @@ -192,6 +192,7 @@ and install_linux_tools g inspect (match inspect.i_major_version with | 6 -> Some "el6" | 7 -> Some "el7" + | 8 -> Some "el8" | _ -> None) | "sles" | "suse-based" | "opensuse" -> Some "lp151" | _ -> None in -- 2.24.1
Richard W.M. Jones
2020-Jan-16 15:15 UTC
Re: [Libguestfs] [PATCH v2] add versioned directory for guest agent on EL8
On Thu, Jan 16, 2020 at 04:05:10PM +0100, Tomáš Golembiovský wrote:> There was no source directory for EL8 guest agent (only EL6 and EL7). > > RHBZ#1791802 > > Signed-off-by: Tomáš Golembiovský <tgolembi@redhat.com> > --- > v2v/windows_virtio.ml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/v2v/windows_virtio.ml b/v2v/windows_virtio.ml > index 5ec7664b..86bc8c0a 100644 > --- a/v2v/windows_virtio.ml > +++ b/v2v/windows_virtio.ml > @@ -192,6 +192,7 @@ and install_linux_tools g inspect > (match inspect.i_major_version with > | 6 -> Some "el6" > | 7 -> Some "el7" > + | 8 -> Some "el8" > | _ -> None) > | "sles" | "suse-based" | "opensuse" -> Some "lp151" > | _ -> None in > --ACK from me. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-top is 'top' for virtual machines. Tiny program with many powerful monitoring features, net stats, disk stats, logging, etc. http://people.redhat.com/~rjones/virt-top
Pino Toscano
2020-Feb-24 09:32 UTC
Re: [Libguestfs] [PATCH v2] add versioned directory for guest agent on EL8
On Thursday, 16 January 2020 16:15:42 CET Richard W.M. Jones wrote:> On Thu, Jan 16, 2020 at 04:05:10PM +0100, Tomáš Golembiovský wrote: > > There was no source directory for EL8 guest agent (only EL6 and EL7). > > > > RHBZ#1791802 > > > > Signed-off-by: Tomáš Golembiovský <tgolembi@redhat.com> > > --- > > v2v/windows_virtio.ml | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/v2v/windows_virtio.ml b/v2v/windows_virtio.ml > > index 5ec7664b..86bc8c0a 100644 > > --- a/v2v/windows_virtio.ml > > +++ b/v2v/windows_virtio.ml > > @@ -192,6 +192,7 @@ and install_linux_tools g inspect > > (match inspect.i_major_version with > > | 6 -> Some "el6" > > | 7 -> Some "el7" > > + | 8 -> Some "el8" > > | _ -> None) > > | "sles" | "suse-based" | "opensuse" -> Some "lp151" > > | _ -> None in > > ACK from me.LGTM too, so pushed: https://github.com/libguestfs/virt-v2v/commit/79dd6a6bbb7e95691be18f54d601318d7d713702 Thanks, -- Pino Toscano
Maybe Matching Threads
- [PATCH] add default (unversioned) directory for guest agent on EL
- Re: [PATCH v3 3/3] v2v: linux: install QEMU-GA (RHBZ#1619665)
- [PATCH 0/2] allow alternative guest tools directories for distributions
- [PATCH v4 0/3] Install QEMU-GA from oVirt guest tools ISO on Linux
- Re: [PATCH 2/2] v2v: allow alternative directories for distributions