Libguestfs - Jul 2018 - Error building nbdkit on RHEL 7.5 - possibly undefined macro: PKG_CHECK_VAR

I'm trying to build upstream source on RHEL 7.5 and get this error:

# autoreconf -i
libtoolize: putting auxiliary files in `.'.
libtoolize: copying file `./ltmain.sh'
libtoolize: putting macros in AC_CONFIG_MACRO_DIR, `m4'.
libtoolize: copying file `m4/libtool.m4'
libtoolize: copying file `m4/ltoptions.m4'
libtoolize: copying file `m4/ltsugar.m4'
libtoolize: copying file `m4/ltversion.m4'
libtoolize: copying file `m4/lt~obsolete.m4'
configure.ac:190: error: possibly undefined macro: PKG_CHECK_VAR
      If this token and others are legitimate, please use m4_pattern_allow.
      See the Autoconf documentation.
autoreconf: /usr/bin/autoconf failed with exit status: 1

How to fix this? I hope I can avoid reading autoconf documentation :-)

Nir

On Sat, Jul 28, 2018 at 09:26:06PM +0300, Nir Soffer
wrote:
> I'm trying to build upstream source on RHEL 7.5 and get this error:
> 
> # autoreconf -i
> libtoolize: putting auxiliary files in `.'.
> libtoolize: copying file `./ltmain.sh'
> libtoolize: putting macros in AC_CONFIG_MACRO_DIR, `m4'.
> libtoolize: copying file `m4/libtool.m4'
> libtoolize: copying file `m4/ltoptions.m4'
> libtoolize: copying file `m4/ltsugar.m4'
> libtoolize: copying file `m4/ltversion.m4'
> libtoolize: copying file `m4/lt~obsolete.m4'
> configure.ac:190: error: possibly undefined macro: PKG_CHECK_VAR
>       If this token and others are legitimate, please use m4_pattern_allow.
>       See the Autoconf documentation.
> autoreconf: /usr/bin/autoconf failed with exit status: 1
> 
> How to fix this? I hope I can avoid reading autoconf documentation :-)
Can confirm it also happens for me (on RHEL 7.6 nightly).

The attached patch should fix it.

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-builder quickly builds VMs from scratch
http://libguestfs.org/virt-builder.1.html

On Sat, Jul 28, 2018 at 10:11 PM Richard W.M. Jones <rjones@redhat.com>
wrote:
> On Sat, Jul 28, 2018 at 09:26:06PM +0300, Nir Soffer wrote:
> > I'm trying to build upstream source on RHEL 7.5 and get this
error:
> >
> > # autoreconf -i
> > libtoolize: putting auxiliary files in `.'.
> > libtoolize: copying file `./ltmain.sh'
> > libtoolize: putting macros in AC_CONFIG_MACRO_DIR, `m4'.
> > libtoolize: copying file `m4/libtool.m4'
> > libtoolize: copying file `m4/ltoptions.m4'
> > libtoolize: copying file `m4/ltsugar.m4'
> > libtoolize: copying file `m4/ltversion.m4'
> > libtoolize: copying file `m4/lt~obsolete.m4'
> > configure.ac:190: error: possibly undefined macro: PKG_CHECK_VAR
> >       If this token and others are legitimate, please use
> m4_pattern_allow.
> >       See the Autoconf documentation.
> > autoreconf: /usr/bin/autoconf failed with exit status: 1
> >
> > How to fix this? I hope I can avoid reading autoconf documentation :-)
>
> Can confirm it also happens for me (on RHEL 7.6 nightly).
>
> The attached patch should fix it.
>
Thanks, it works.