Libguestfs - Mar 2017 - [PATCH] p2v: Add awk as a dependency.

The code to parse /proc/cpuinfo runs awk, but it was not included as a
specific dependency so the parsing code might silently fail.
---
 p2v/dependencies.m4 | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/p2v/dependencies.m4 b/p2v/dependencies.m4
index bd62d34..21541b4 100644
--- a/p2v/dependencies.m4
+++ b/p2v/dependencies.m4
@@ -29,6 +29,7 @@ ifelse(REDHAT,1,
   dnl Run as external programs by the p2v binary.
   /usr/bin/ssh
   /usr/bin/qemu-nbd
+  gawk
   curl
   ethtool
   util-linux
@@ -80,6 +81,7 @@ ifelse(DEBIAN,1,
   libdbus-1-3
   openssh-client
   qemu-utils
+  gawk
   curl
   ethtool
   util-linux
@@ -112,6 +114,7 @@ ifelse(ARCHLINUX,1,
   dbus
   openssh
   qemu
+  gawk
   curl
   ethtool
   util-linux
@@ -145,6 +148,7 @@ ifelse(SUSE,1,
   libdbus-1-3
   qemu-tools
   openssh
+  gawk
   curl
   ethtool
   util-linux
-- 
2.10.2

On Thursday, 16 March 2017 19:53:25 CET Richard W.M. Jones
wrote:
> The code to parse /proc/cpuinfo runs awk, but it was not included as a
> specific dependency so the parsing code might silently fail.
> ---
LGTM, although I'd simply add it once at the end of the file, so there
is no need to duplicate it for all the distros.

I can do the work of un-duplicating the other duplicated dependencies.

Thanks,
-- 
Pino Toscano

On Fri, Mar 17, 2017 at 09:39:47AM +0100, Pino Toscano
wrote:
> On Thursday, 16 March 2017 19:53:25 CET Richard W.M. Jones wrote:
> > The code to parse /proc/cpuinfo runs awk, but it was not included as a
> > specific dependency so the parsing code might silently fail.
> > ---
> 
> LGTM, although I'd simply add it once at the end of the file, so there
> is no need to duplicate it for all the distros.
> 
> I can do the work of un-duplicating the other duplicated dependencies.
Yes please.

I have pushed this commit unchanged.

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
Fedora Windows cross-compiler. Compile Windows programs, test, and
build Windows installers. Over 100 libraries supported.
http://fedoraproject.org/wiki/MinGW