Libguestfs - Oct 2015 - [PATCH 0/3] hivex: misc changes

Hi,

Few changes in hivex, sent as series to be clearly identified as hivex
ones.

After these patches, what about a new release of it? The last one is
basically one year old, and the changes after 1.3.11 make hivex build
and work fine on FreeBSD (and maybe more non-Linux OSes).

Thanks,


Pino Toscano (3):
  Fix shebang in perl scripts
  Update gnulib to latest.
  Update .gitignore with more gnulib files.

 .gnulib                    | 2 +-
 extra-tests/fuzz.pl        | 3 ++-
 extra-tests/insert-keys.pl | 3 ++-
 m4/.gitignore              | 2 ++
 regedit/hivexregedit       | 2 +-
 5 files changed, 8 insertions(+), 4 deletions(-)

-- 
2.1.0

Instead of hardcoding the location of perl (assuming it is installed in
/usr), use /usr/bin/env to run it, and thus picking it from $PATH.
This makes it possible to run these scripts also on installations with
perl in a different prefix than /usr.

Also, given that we want enable warnings on scripts, turn the -w
previously in shebang to explicit "use warnings;" in scripts which
didn't have it before.

(This is the same change as d98c9c0e0b4d259f49825fc360bc7e6cafbdd644
in libguestfs.)
---
 extra-tests/fuzz.pl        | 3 ++-
 extra-tests/insert-keys.pl | 3 ++-
 regedit/hivexregedit       | 2 +-
 3 files changed, 5 insertions(+), 3 deletions(-)

diff --git a/extra-tests/fuzz.pl b/extra-tests/fuzz.pl
index 46e77fd..0e8f254 100755
--- a/extra-tests/fuzz.pl
+++ b/extra-tests/fuzz.pl
@@ -1,4 +1,4 @@
-#!/usr/bin/perl -w
+#!/usr/bin/env perl
 # hivex extra tests
 # Copyright (C) 2014 Red Hat Inc.
 #
@@ -20,6 +20,7 @@
 # crash on the fuzzed hives, not that it can read them.
 
 use strict;
+use warnings;
 
 use File::Temp qw(tempfile);
 use File::Copy;
diff --git a/extra-tests/insert-keys.pl b/extra-tests/insert-keys.pl
index 1124b37..b3d6a18 100755
--- a/extra-tests/insert-keys.pl
+++ b/extra-tests/insert-keys.pl
@@ -1,4 +1,4 @@
-#!/usr/bin/perl -w
+#!/usr/bin/env perl
 # hivex extra tests
 # Copyright (C) 2013 Red Hat Inc.
 #
@@ -21,6 +21,7 @@
 # get the expected data and don't get any errors.
 
 use strict;
+use warnings;
 
 use Win::Hivex;
 
diff --git a/regedit/hivexregedit b/regedit/hivexregedit
index 0e534de..6b31a3a 100755
--- a/regedit/hivexregedit
+++ b/regedit/hivexregedit
@@ -1,4 +1,4 @@
-#!/usr/bin/perl -w
+#!/usr/bin/env perl
 # Copyright (C) 2010-2011 Red Hat Inc.
 #
 # This program is free software; you can redistribute it and/or modify
-- 
2.1.0

---
 .gnulib | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.gnulib b/.gnulib
index a0712c3..5fecb65 160000
--- a/.gnulib
+++ b/.gnulib
@@ -1 +1 @@
-Subproject commit a0712c3bd924b6dcb085e7a1b7d22f0c91ae7d74
+Subproject commit 5fecb65e32709e66fd6025ad72cef4717cf73a24
-- 
2.1.0

---
 m4/.gitignore | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/m4/.gitignore b/m4/.gitignore
index 09915f7..05ca27c 100644
--- a/m4/.gitignore
+++ b/m4/.gitignore
@@ -7,6 +7,7 @@
 /closeout.m4
 /close-stream.m4
 /codeset.m4
+/ctype.m4
 /dos.m4
 /dup2.m4
 /eealloc.m4
@@ -97,6 +98,7 @@
 /sockpfaf.m4
 /ssize_t.m4
 /stat.m4
+/stdalign.m4
 /stdbool.m4
 /stddef_h.m4
 /stdint_h.m4
-- 
2.1.0

On Mon, Oct 05, 2015 at 04:56:35PM +0200, Pino Toscano
wrote:
> ---
>  m4/.gitignore | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/m4/.gitignore b/m4/.gitignore
> index 09915f7..05ca27c 100644
> --- a/m4/.gitignore
> +++ b/m4/.gitignore
> @@ -7,6 +7,7 @@
>  /closeout.m4
>  /close-stream.m4
>  /codeset.m4
> +/ctype.m4
>  /dos.m4
>  /dup2.m4
>  /eealloc.m4
> @@ -97,6 +98,7 @@
>  /sockpfaf.m4
>  /ssize_t.m4
>  /stat.m4
> +/stdalign.m4
>  /stdbool.m4
>  /stddef_h.m4
>  /stdint_h.m4
ACK series.

Ping me on IRC when you've pushed them so I can make an upstream release.

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-builder quickly builds VMs from scratch
http://libguestfs.org/virt-builder.1.html