Syslinux - Aug 2018 - Discard .note.gnu.property section to fix build failure (patch)

Hi,

currently syslinux fails to build from source in Debian as has been
reported in https://bugs.debian.org/906414 . The reported error is:

  mbr.bin: too big (452 > 440)


I've realized that this is because since a recent version, the linker
adds a new section (.note.gnu.property). Discarding this section fixes
the problem. I've attached a patch, please consider merging it.

Thanks
Lukas
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0016-strip-gnu-property.patch
Type: text/x-patch
Size: 1276 bytes
Desc: not available
URL:
<http://www.zytor.com/pipermail/syslinux/attachments/20180818/07c75e68/attachment.bin>

On Sat, Aug 18, 2018 at 11:35 AM Lukas Schwaighofer via Syslinux
<syslinux at zytor.com> wrote:
> currently syslinux fails to build from source in Debian as has been
> reported in https://bugs.debian.org/906414 . The reported error is:
>
>   mbr.bin: too big (452 > 440)
>
>
> I've realized that this is because since a recent version, the linker
> adds a new section (.note.gnu.property). Discarding this section fixes
> the problem. I've attached a patch, please consider merging it.
That explains a lot about why others have been seeing this issue.

Thanks.  Merged but not yet pushed.  There's 0 need to build MBRs for
EFI and I'm looking at why utils/ depends on mbr/ and planing to
eliminate a bunch of useless binaries (like how memdisk/ is only BIOS
for essentially the same reason; it just won't work for others).

-- 
-Gene

> There's 0 need to build MBRs for
> EFI
 
 
At least gptmbr.bin might come to mind (after all, GPT is part of the 
UEFI specs). Isohybrid with UEFI options perhaps too?

> and I'm looking at why utils/ depends on mbr/ 
 
isohybrid(.pl) and mkdiskimage come to mind here?

I'm not saying for certain these are the reasons for such dependencies, 
but they might (and perhaps there might be more?).

Regards,
Ady.