Khem Raj
2015-Sep-10 05:55 UTC
[syslinux] [PATCH] Dont bypass compiler driver for Dependency generation options
We can let compiler driver pass the right options to preprocessor after processing -Mxy options, right now its bypassing the gcc driver and handing them straight to cpp This also helps in other compilers processing these options correctly for their preprocessors consumption Signed-off-by: Khem Raj <raj.khem at gmail.com> --- mk/syslinux.mk | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/mk/syslinux.mk b/mk/syslinux.mk index 337560b..9ca74b1 100644 --- a/mk/syslinux.mk +++ b/mk/syslinux.mk @@ -82,11 +82,11 @@ ARCH ?= $(strip $(SUBARCH)) GCCWARN = -W -Wall -Wstrict-prototypes $(DEBUGOPT) # Common stanza to make gcc generate .*.d dependency files -MAKEDEPS = -Wp,-MT,$@,-MD,$(dir $@).$(notdir $@).d +MAKEDEPS = -MT $@ -MD # Dependencies that exclude system headers; use whenever we use # header files from the platform. -UMAKEDEPS = -Wp,-MT,$@,-MMD,$(dir $@).$(notdir $@).d +UMAKEDEPS = -MT $@ -MMD # Items that are only appropriate during development; this file is # removed when tarballs are generated. -- 2.5.1
Gene Cumm
2015-Sep-13 18:04 UTC
[syslinux] [PATCH] Dont bypass compiler driver for Dependency generation options
On Thu, Sep 10, 2015 at 1:55 AM, Khem Raj via Syslinux <syslinux at zytor.com> wrote:> We can let compiler driver pass the right options to preprocessor after > processing -Mxy options, right now its bypassing the gcc driver and > handing them straight to cpp > > This also helps in other compilers processing these options correctly > for their preprocessors consumption > > Signed-off-by: Khem Raj <raj.khem at gmail.com> > --- > mk/syslinux.mk | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/mk/syslinux.mk b/mk/syslinux.mk > index 337560b..9ca74b1 100644 > --- a/mk/syslinux.mk > +++ b/mk/syslinux.mk > @@ -82,11 +82,11 @@ ARCH ?= $(strip $(SUBARCH)) > GCCWARN = -W -Wall -Wstrict-prototypes $(DEBUGOPT) > > # Common stanza to make gcc generate .*.d dependency files > -MAKEDEPS = -Wp,-MT,$@,-MD,$(dir $@).$(notdir $@).d > +MAKEDEPS = -MT $@ -MD > > # Dependencies that exclude system headers; use whenever we use > # header files from the platform. > -UMAKEDEPS = -Wp,-MT,$@,-MMD,$(dir $@).$(notdir $@).d > +UMAKEDEPS = -MT $@ -MMD > > # Items that are only appropriate during development; this file is > # removed when tarballs are generated.It looks like these were introduced in MCONFIG back in commit ID fe938522 and originally in a bunch of other commits like fbfc9121 and the earliest instance appears to be 17f96764. Khem, at first I didn't quite understand the part about other compilers then it struck me that you're probably trying to build linux/syslinux and extlinux/extlinux without a gcc dependence. HPA, any clue on the history of these gcc flags? Was gcc previously error-prone on direct dependence generation? Any reason to not proceed? -- -Gene
Khem Raj
2015-Sep-14 05:36 UTC
[syslinux] [PATCH] Dont bypass compiler driver for Dependency generation options
> On Sep 13, 2015, at 11:04 AM, Gene Cumm <gene.cumm at gmail.com> wrote: > > On Thu, Sep 10, 2015 at 1:55 AM, Khem Raj via Syslinux > <syslinux at zytor.com> wrote: >> We can let compiler driver pass the right options to preprocessor after >> processing -Mxy options, right now its bypassing the gcc driver and >> handing them straight to cpp >> >> This also helps in other compilers processing these options correctly >> for their preprocessors consumption >> >> Signed-off-by: Khem Raj <raj.khem at gmail.com> >> --- >> mk/syslinux.mk | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/mk/syslinux.mk b/mk/syslinux.mk >> index 337560b..9ca74b1 100644 >> --- a/mk/syslinux.mk >> +++ b/mk/syslinux.mk >> @@ -82,11 +82,11 @@ ARCH ?= $(strip $(SUBARCH)) >> GCCWARN = -W -Wall -Wstrict-prototypes $(DEBUGOPT) >> >> # Common stanza to make gcc generate .*.d dependency files >> -MAKEDEPS = -Wp,-MT,$@,-MD,$(dir $@).$(notdir $@).d >> +MAKEDEPS = -MT $@ -MD >> >> # Dependencies that exclude system headers; use whenever we use >> # header files from the platform. >> -UMAKEDEPS = -Wp,-MT,$@,-MMD,$(dir $@).$(notdir $@).d >> +UMAKEDEPS = -MT $@ -MMD >> >> # Items that are only appropriate during development; this file is >> # removed when tarballs are generated. > > It looks like these were introduced in MCONFIG back in commit ID > fe938522 and originally in a bunch of other commits like fbfc9121 and > the earliest instance appears to be 17f96764. > > Khem, at first I didn't quite understand the part about other > compilers then it struck me that you're probably trying to build > linux/syslinux and extlinux/extlinux without a gcc dependence.I was using clang to compile it :). than I ran into further issues which I am tackling and if any useful patch results, I will send upstream
H. Peter Anvin
2015-Dec-18 21:44 UTC
[syslinux] [PATCH] Dont bypass compiler driver for Dependency generation options
On 09/13/2015 11:04 AM, Gene Cumm via Syslinux wrote:> > HPA, any clue on the history of these gcc flags? Was gcc previously > error-prone on direct dependence generation? Any reason to not > proceed? >I think these options first got introduced as cpp options. No reason these days. -hpa
Reasonably Related Threads
- [PATCH] Dont bypass compiler driver for Dependency generation options
- [PATCH] Dont bypass compiler driver for Dependency generation options
- [PATCH] Dont bypass compiler driver for Dependency generation options
- If(cond) statement
- [PATCH 0/3] xen: various changes to what we install in /boot