Daniel Vetter
2019-Jan-24 16:58 UTC
[Nouveau] [PATCH 26/26] drm/<drivers>: Don't set FBINFO_(FLAG_)DEFAULT
It's 0.
Signed-off-by: Daniel Vetter <daniel.vetter at intel.com>
Cc: Inki Dae <inki.dae at samsung.com>
Cc: Joonyoung Shim <jy0922.shim at samsung.com>
Cc: Seung-Woo Kim <sw0312.kim at samsung.com>
Cc: Kyungmin Park <kyungmin.park at samsung.com>
Cc: Kukjin Kim <kgene at kernel.org>
Cc: Krzysztof Kozlowski <krzk at kernel.org>
Cc: Patrik Jakobsson <patrik.r.jakobsson at gmail.com>
Cc: Ben Skeggs <bskeggs at redhat.com>
Cc: Sandy Huang <hjc at rock-chips.com>
Cc: "Heiko Stübner" <heiko at sntech.de>
Cc: Thierry Reding <thierry.reding at gmail.com>
Cc: Jonathan Hunter <jonathanh at nvidia.com>
Cc: Hans de Goede <hdegoede at redhat.com>
Cc: Greg Kroah-Hartman <gregkh at linuxfoundation.org>
Cc: Daniel Vetter <daniel.vetter at ffwll.ch>
Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie at samsung.com>
Cc: Alexander Kapshuk <alexander.kapshuk at gmail.com>
Cc: linux-arm-kernel at lists.infradead.org
Cc: linux-samsung-soc at vger.kernel.org
Cc: nouveau at lists.freedesktop.org
Cc: linux-rockchip at lists.infradead.org
Cc: linux-tegra at vger.kernel.org
---
drivers/gpu/drm/exynos/exynos_drm_fbdev.c | 1 -
drivers/gpu/drm/gma500/framebuffer.c | 1 -
drivers/gpu/drm/nouveau/nouveau_fbcon.c | 4 ++--
drivers/gpu/drm/rockchip/rockchip_drm_fbdev.c | 1 -
drivers/gpu/drm/tegra/fb.c | 1 -
5 files changed, 2 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/exynos/exynos_drm_fbdev.c
b/drivers/gpu/drm/exynos/exynos_drm_fbdev.c
index b2018961b9cf..00bfcd28e589 100644
--- a/drivers/gpu/drm/exynos/exynos_drm_fbdev.c
+++ b/drivers/gpu/drm/exynos/exynos_drm_fbdev.c
@@ -87,7 +87,6 @@ static int exynos_drm_fbdev_update(struct drm_fb_helper
*helper,
return PTR_ERR(fbi);
}
- fbi->flags = FBINFO_FLAG_DEFAULT;
fbi->fbops = &exynos_drm_fb_ops;
drm_fb_helper_fill_info(fbi, helper);
diff --git a/drivers/gpu/drm/gma500/framebuffer.c
b/drivers/gpu/drm/gma500/framebuffer.c
index c7a5c29f9a69..3b59dbadfa63 100644
--- a/drivers/gpu/drm/gma500/framebuffer.c
+++ b/drivers/gpu/drm/gma500/framebuffer.c
@@ -401,7 +401,6 @@ static int psbfb_create(struct psb_fbdev *fbdev,
fbdev->psb_fb_helper.fb = fb;
- info->flags = FBINFO_DEFAULT;
if (dev_priv->ops->accel_2d && pitch_lines > 8) /* 2D engine
*/
info->fbops = &psbfb_ops;
else if (gtt_roll) { /* GTT rolling seems best */
diff --git a/drivers/gpu/drm/nouveau/nouveau_fbcon.c
b/drivers/gpu/drm/nouveau/nouveau_fbcon.c
index 3a3d454b65e3..1136ee26005f 100644
--- a/drivers/gpu/drm/nouveau/nouveau_fbcon.c
+++ b/drivers/gpu/drm/nouveau/nouveau_fbcon.c
@@ -370,9 +370,9 @@ nouveau_fbcon_create(struct drm_fb_helper *helper,
fbcon->helper.fb = &fb->base;
if (!chan)
- info->flags = FBINFO_DEFAULT | FBINFO_HWACCEL_DISABLED;
+ info->flags = FBINFO_HWACCEL_DISABLED;
else
- info->flags = FBINFO_DEFAULT | FBINFO_HWACCEL_COPYAREA |
+ info->flags = FBINFO_HWACCEL_COPYAREA |
FBINFO_HWACCEL_FILLRECT |
FBINFO_HWACCEL_IMAGEBLIT;
info->fbops = &nouveau_fbcon_sw_ops;
diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_fbdev.c
b/drivers/gpu/drm/rockchip/rockchip_drm_fbdev.c
index d12164878e05..fed7d7698164 100644
--- a/drivers/gpu/drm/rockchip/rockchip_drm_fbdev.c
+++ b/drivers/gpu/drm/rockchip/rockchip_drm_fbdev.c
@@ -90,7 +90,6 @@ static int rockchip_drm_fbdev_create(struct drm_fb_helper
*helper,
goto out;
}
- fbi->flags = FBINFO_FLAG_DEFAULT;
fbi->fbops = &rockchip_drm_fbdev_ops;
fb = helper->fb;
diff --git a/drivers/gpu/drm/tegra/fb.c b/drivers/gpu/drm/tegra/fb.c
index 82348ddd0b83..ea82184073bd 100644
--- a/drivers/gpu/drm/tegra/fb.c
+++ b/drivers/gpu/drm/tegra/fb.c
@@ -255,7 +255,6 @@ static int tegra_fbdev_probe(struct drm_fb_helper *helper,
helper->fb = fb;
helper->fbdev = info;
- info->flags = FBINFO_FLAG_DEFAULT;
info->fbops = &tegra_fb_ops;
drm_fb_helper_fill_info(info, helper);
--
2.20.1
Emil Velikov
2019-Jan-25 15:02 UTC
[Nouveau] [Intel-gfx] [PATCH 26/26] drm/<drivers>: Don't set FBINFO_(FLAG_)DEFAULT
On Thu, 24 Jan 2019 at 17:00, Daniel Vetter <daniel.vetter at ffwll.ch> wrote:> > It's 0. >I'd add a bit more information here. Feel free to reuse as much/little of the following: Both macros evaluate to 0. At the same time flag is already set to zero since the struct is kzalloc'd in framebuffer_alloc(). As called by drm_fb_helper_alloc_fbi() in the DRM drivers. -Emil
Thierry Reding
2019-Jan-25 15:14 UTC
[Nouveau] [PATCH 26/26] drm/<drivers>: Don't set FBINFO_(FLAG_)DEFAULT
On Thu, Jan 24, 2019 at 05:58:31PM +0100, Daniel Vetter wrote:> It's 0. > > Signed-off-by: Daniel Vetter <daniel.vetter at intel.com> > Cc: Inki Dae <inki.dae at samsung.com> > Cc: Joonyoung Shim <jy0922.shim at samsung.com> > Cc: Seung-Woo Kim <sw0312.kim at samsung.com> > Cc: Kyungmin Park <kyungmin.park at samsung.com> > Cc: Kukjin Kim <kgene at kernel.org> > Cc: Krzysztof Kozlowski <krzk at kernel.org> > Cc: Patrik Jakobsson <patrik.r.jakobsson at gmail.com> > Cc: Ben Skeggs <bskeggs at redhat.com> > Cc: Sandy Huang <hjc at rock-chips.com> > Cc: "Heiko Stübner" <heiko at sntech.de> > Cc: Thierry Reding <thierry.reding at gmail.com> > Cc: Jonathan Hunter <jonathanh at nvidia.com> > Cc: Hans de Goede <hdegoede at redhat.com> > Cc: Greg Kroah-Hartman <gregkh at linuxfoundation.org> > Cc: Daniel Vetter <daniel.vetter at ffwll.ch> > Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie at samsung.com> > Cc: Alexander Kapshuk <alexander.kapshuk at gmail.com> > Cc: linux-arm-kernel at lists.infradead.org > Cc: linux-samsung-soc at vger.kernel.org > Cc: nouveau at lists.freedesktop.org > Cc: linux-rockchip at lists.infradead.org > Cc: linux-tegra at vger.kernel.org > --- > drivers/gpu/drm/exynos/exynos_drm_fbdev.c | 1 - > drivers/gpu/drm/gma500/framebuffer.c | 1 - > drivers/gpu/drm/nouveau/nouveau_fbcon.c | 4 ++-- > drivers/gpu/drm/rockchip/rockchip_drm_fbdev.c | 1 - > drivers/gpu/drm/tegra/fb.c | 1 - > 5 files changed, 2 insertions(+), 6 deletions(-)Acked-by: Thierry Reding <treding at nvidia.com> -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 833 bytes Desc: not available URL: <https://lists.freedesktop.org/archives/nouveau/attachments/20190125/cb60c0b7/attachment.sig>
Daniel Vetter
2019-Jan-29 09:58 UTC
[Nouveau] [Intel-gfx] [PATCH 26/26] drm/<drivers>: Don't set FBINFO_(FLAG_)DEFAULT
On Fri, Jan 25, 2019 at 03:02:46PM +0000, Emil Velikov wrote:> On Thu, 24 Jan 2019 at 17:00, Daniel Vetter <daniel.vetter at ffwll.ch> wrote: > > > > It's 0. > > > I'd add a bit more information here. Feel free to reuse as much/little > of the following: > > Both macros evaluate to 0. At the same time flag is already set to > zero since the struct is kzalloc'd in framebuffer_alloc(). > As called by drm_fb_helper_alloc_fbi() in the DRM drivers.Added&merged, thanks for your review. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch
Reasonably Related Threads
- [Intel-gfx] [PATCH 26/26] drm/<drivers>: Don't set FBINFO_(FLAG_)DEFAULT
- [PATCH 1/4] fbdev: Drop FBINFO_CAN_FORCE_OUTPUT flag
- [PATCH] drm/fbdev: Make skip_vt_switch the default
- [PATCH] drm/fbdev: Make skip_vt_switch the default
- [PATCH] drm/fbdev: Make skip_vt_switch the default