Pkg xen devel - Aug 2015 - Bug#763102: xen-utils-common: xen-init-list fails to parse xm output -> cannot shutdown domains with service xendomains

Control: tag -1 +moreinfo

Hello,

It seems this was incorrectly closed as xend only since this code can
be used on upgrade (as part of rebooting from xend into a new system).
I don't have any systems to test but I think the fix is trivially the
following:

@@ -51,7 +51,7 @@ class DataJSON(Data):
 
 class DataSXP(Data):
     def __init__(self, p):
-        s = SXPParser()(p)
+        s = SXPParser.loads(p)
         self.data = d = {}
         for i in s:
             if i and i[0] == 'domain':

Please can you try making that change to /usr/lib/xen-common/bin/xen
-init-list and report whether or not it works?

I've also published the fix to the feature/bug763102 branch of the pkg
-xen git repository.

Thanks,
Ian

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi Ian,

you can use the patch I posted in the original report, there are two
places that need to be fixed. I'm using it since November.

Cheers,
Volker
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iEYEARECAAYFAlXXpS8ACgkQgKD4KXUzSriihQCgidnLz9Lx475uQ4dzWz4jDrzM
nsUAn3Z/Sy3tA2yquXvyAXnY04pxgOop
=GYjR
-----END PGP SIGNATURE-----

On Sat, 2015-08-22 at 00:24 +0200, Volker Klasen wrote:
> Hi Ian,
> 
> you can use the patch I posted in the original report,
Uh, how on earth did I miss it!
>  there are two
> places that need to be fixed. I'm using it since November.
Thanks. Since loads is a classmethod I think the right fix for that
issue is to s/self/cls/ in the body rather than s/cls/self/ in the
declaration.

I've updated the feature/bug763102 with the following extra patch:

@@ -14,7 +14,7 @@ class SXPParser(object):
     def loads(cls, input):
         data = []
         stack = []
-        for match in self.tokenizer_re.finditer(input):
+        for match in cls.tokenizer_re.finditer(input):
             if match.group('open'):
                 stack.append([])
             elif match.group('close'):

Ian.