openssh unix dev - Jun 2018 - vanilla build of 7.7p1 release on linux/4.17 fails with gcc8 @ "/usr/bin/ld: unrecognized option '-Wl,-z,retpolineplt'"

Also what exact distro and version are you having the problem on and
what version of ld does it have?

Mine is
$ ld --version
GNU ld version 2.29.1-23.fc28

-- 
Darren Tucker (dtucker at dtucker.net)
GPG key 11EAA6FA / A86E 3E07 5B19 5880 E860  37F4 9357 ECEF 11EA A6FA (new)
    Good judgement comes with experience. Unfortunately, the experience
usually comes from bad judgement.

On 6/7/18 5:08 PM, Darren Tucker wrote:
> Also what exact distro and version are you having the problem on and
It's OpenSUSE Leap 15.

But the gcc dev env is from my own packages (basically cloned from distro
builds, but a more reliable/manageable source).

Available for interest at:

	https://build.opensuse.org/project/show/home:pgnd:devel:gcc8

So far, it's not been the source of any build probs elsewhere that I'm
aware of; that's certainly not to say it's not possible.
> what version of ld does it have?
>
> Mine is
> $ ld --version
> GNU ld version 2.29.1-23.fc28
from above,
> ld -v
>	GNU ld (GNU Binutils; home:pgnd:devel:gcc8 / openSUSE_Leap_15.0)
2.30.0.20180320-lp150.319

here, the same

	gcc -o sshd sshd.o auth-rhosts.o auth-passwd.o audit.o audit-bsm.o
audit-linux.o platform.o sshpty.o sshlogin.o servconf.o serverloop.o auth.o
auth2.o auth-options.o session.o auth2-chall.o groupaccess.o auth-skey.o
auth-bsdauth.o auth2-hostbased.o auth2-kbdint.o auth2-none.o auth2-passwd.o
auth2-pubkey.o monitor.o monitor_wrap.o auth-krb5.o auth2-gss.o gss-serv.o
gss-serv-krb5.o loginrec.o auth-pam.o auth-shadow.o auth-sia.o md5crypt.o
sftp-server.o sftp-common.o sandbox-null.o sandbox-rlimit.o sandbox-systrace.o
sandbox-darwin.o sandbox-seccomp-filter.o sandbox-capsicum.o sandbox-pledge.o
sandbox-solaris.o -L. -Lopenbsd-compat/ -Wl,-z,retpolineplt -Wl,-z,relro
-Wl,-z,now -Wl,-z,noexecstack -fstack-protector-strong -pie  -lssh
-lopenbsd-compat  -lcrypto -ldl -lutil -lz  -lcrypt -lresolv

also returns

	/usr/lib64/gcc/x86_64-suse-linux/8/../../../../x86_64-suse-linux/bin/ld:
warning: -z retpolineplt ignored.

where,

	ls -al /usr/lib64/gcc/x86_64-suse-linux/8/../../../../x86_64-suse-linux/bin/ld
		lrwxrwxrwx 1 root root 12 Jun  7 05:00
/usr/lib64/gcc/x86_64-suse-linux/8/../../../../x86_64-suse-linux/bin/ld ->
../../bin/ld*

	/usr/x86_64-suse-linux/bin/ld -v
		GNU ld (GNU Binutils; home:pgnd:devel:gcc8 / openSUSE_Leap_15.0)
2.30.0.20180320-lp150.319

One difference I notice is that in your failing example you are
invoking /usr/bin/ld directly to link:

               /usr/bin/ld -o ssh ssh.o readconf.o clientloop.o
sshtty.o sshconnect.o sshconnect2.o mux.o -L. -Lopenbsd-compat/
-Wl,-z,retpolineplt -Wl,-z,relro -Wl,-z,now -Wl,-z,noexecstack
-fstack-protector-strong -pie  -lssh -lopenbsd-compat  -lutil -lz
-lcrypt -lresolv

whereas my example is invoking via gcc.  I assume you are explicitly
setting the LD env var?

To narrow this down I suggest:
a) take the failing link command line and delete -Wl, options other
than retpoline and see if it will link at any point.  Perhaps the
problem is the problem is occurs due to an interaction with other
flags
b) try using LD=gcc and see if it behaves any different (also, see if
the list of options it detects is different).

-- 
Darren Tucker (dtucker at dtucker.net)
GPG key 11EAA6FA / A86E 3E07 5B19 5880 E860  37F4 9357 ECEF 11EA A6FA (new)
    Good judgement comes with experience. Unfortunately, the experience
usually comes from bad judgement.