openssh unix dev - Mar 2015 - [PATCH 1/1] monitor_wrap: do not give error but debug message

Hello everybody,

Just updated to openssh 6.8p1. Everything works just fine, though I get these
lines in syslog on logout:

Mar 18 12:52:05 leda sshd[27487]: Received disconnect from ::1: 11:
disconnected by user
Mar 18 12:52:05 leda sshd[27487]: Disconnected from ::1
Mar 18 12:52:05 leda sshd[27482]: error: mm_request_receive: socket closed

First and second entry is ok, but why does it give an error on socket closed?
-- 
main(a){char*c=/*    Schoene Gruesse                        
*/"B?IJj;MEH"
"CX:;",b;for(a/*    Chris           get my mail address:   
*/=0;b=c[a++];)
putchar(b-1/(/*               gcc -o sig sig.c && ./sig   
*/b/42*2-3)*42);}
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 473 bytes
Desc: OpenPGP digital signature
URL:
<http://lists.mindrot.org/pipermail/openssh-unix-dev/attachments/20150318/0c849446/attachment-0001.bin>

From: Christian Hesse <mail at eworm.de>

Commit 72ef7c14 (support --without-openssl at configure time) added an
error message in mm_request_receive() when socket is closed. Make this a
debug message.

Signed-off-by: Christian Hesse <mail at eworm.de>
---
 monitor_wrap.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/monitor_wrap.c b/monitor_wrap.c
index b379f05..f13894a 100644
--- a/monitor_wrap.c
+++ b/monitor_wrap.c
@@ -154,7 +154,7 @@ mm_request_receive(int sock, Buffer *m)
 
 	if (atomicio(read, sock, buf, sizeof(buf)) != sizeof(buf)) {
 		if (errno == EPIPE) {
-			error("%s: socket closed", __func__);
+			debug("%s: socket closed", __func__);
 			cleanup_exit(255);
 		}
 		fatal("%s: read: %s", __func__, strerror(errno));
-- 
2.3.3

On Thu, 19 Mar 2015, Christian Hesse wrote:
> From: Christian Hesse <mail at eworm.de>
> 
> Commit 72ef7c14 (support --without-openssl at configure time) added an
> error message in mm_request_receive() when socket is closed. Make this a
> debug message.
> 
> Signed-off-by: Christian Hesse <mail at eworm.de>
> ---
>  monitor_wrap.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/monitor_wrap.c b/monitor_wrap.c
> index b379f05..f13894a 100644
> --- a/monitor_wrap.c
> +++ b/monitor_wrap.c
> @@ -154,7 +154,7 @@ mm_request_receive(int sock, Buffer *m)
>  
>  	if (atomicio(read, sock, buf, sizeof(buf)) != sizeof(buf)) {
>  		if (errno == EPIPE) {
> -			error("%s: socket closed", __func__);
> +			debug("%s: socket closed", __func__);
Actually, I think it was a debugging change that I accidentally committed
somewhere between 6.7 and 6.8. It can be deleted entirely.

-d