Hello everyone A previous thread about OrcJIT brought up bug reports on Bugzilla. A quick search gives 20+ results: https://bugs.llvm.org/buglist.cgi?component=OrcJIT&list_id=162232&query_format=advanced&resolution=--- While some of them are obviously outdated (addModuleSet API cleanup [1]), others may actually be relevant again (Small code model? [2]). If you reported one of them, please take the time (some day) and review from today's perspective. Are there recommendations regarding Bugzilla reports from other parts of LLVM? Best practices that worked out well? Thanks! Stefan -- [1] https://bugs.llvm.org/show_bug.cgi?id=30896 [2] https://bugs.llvm.org/show_bug.cgi?id=24159 -- https://flowcrypt.com/pub/stefan.graenitz at gmail.com -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 488 bytes Desc: OpenPGP digital signature URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20190518/38390ce2/attachment.sig>
In fact, this is all very good practice in my opinion: https://bugs.llvm.org/show_bug.cgi?id=30896 https://bugs.llvm.org/show_bug.cgi?id=22608 https://bugs.llvm.org/show_bug.cgi?id=24159 Back in 2016 I simply didn't know about the Bugzilla tracker. From today's perspective, I think, we should try and revive this spirit and share rough plans there. @Praveen very good initiative! https://bugs.llvm.org/show_bug.cgi?id=41075 @Machiel: This is quite recent, but didn't land after it was accepted. Objections? https://reviews.llvm.org/D61599 Cheers -------- Forwarded Message -------- Subject: Bugzilla OrcJIT Tickets Date: Sat, 18 May 2019 17:47:58 +0200 From: Stefan Gränitz <stefan.graenitz at gmail.com> To: via llvm-dev <llvm-dev at lists.llvm.org> Hello everyone A previous thread about OrcJIT brought up bug reports on Bugzilla. A quick search gives 20+ results: https://bugs.llvm.org/buglist.cgi?component=OrcJIT&list_id=162232&query_format=advanced&resolution=--- While some of them are obviously outdated (addModuleSet API cleanup [1]), others may actually be relevant again (Small code model? [2]). If you reported one of them, please take the time (some day) and review from today's perspective. Are there recommendations regarding Bugzilla reports from other parts of LLVM? Best practices that worked out well? Thanks! Stefan -- [1] https://bugs.llvm.org/show_bug.cgi?id=30896 [2] https://bugs.llvm.org/show_bug.cgi?id=24159 -- https://flowcrypt.com/pub/stefan.graenitz at gmail.com -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20190518/416611b7/attachment.html> -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 488 bytes Desc: OpenPGP digital signature URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20190518/416611b7/attachment.sig>
Hi Stefan Thank you! In case, you missed in llvm-dev listing: you can find the proposal here : link. <https://docs.google.com/document/d/1202EcXlWMQ8yxu5qD0b5fE0a_kihlcaPNpZo_Jk0YeQ/edit?usp=sharing> Thanks for working on summarising the Bugzilla tickets to track the recent changes in ORC this is really helpful. On Sat, 18 May 2019 at 21:33, Stefan Gränitz <stefan.graenitz at gmail.com> wrote:> In fact, this is all very good practice in my opinion: > https://bugs.llvm.org/show_bug.cgi?id=30896 > https://bugs.llvm.org/show_bug.cgi?id=22608 > https://bugs.llvm.org/show_bug.cgi?id=24159 > > Back in 2016 I simply didn't know about the Bugzilla tracker. > From today's perspective, I think, we should try and revive this spirit > and share rough plans there. > > @Praveen very good initiative! > https://bugs.llvm.org/show_bug.cgi?id=41075 > > @Machiel: This is quite recent, but didn't land after it was accepted. > Objections? > https://reviews.llvm.org/D61599 > > Cheers > -------- Forwarded Message -------- > Subject: Bugzilla OrcJIT Tickets > Date: Sat, 18 May 2019 17:47:58 +0200 > From: Stefan Gränitz <stefan.graenitz at gmail.com> > <stefan.graenitz at gmail.com> > To: via llvm-dev <llvm-dev at lists.llvm.org> <llvm-dev at lists.llvm.org> > > Hello everyone > > A previous thread about OrcJIT brought up bug reports on Bugzilla. A > quick search gives 20+ results: > > https://bugs.llvm.org/buglist.cgi?component=OrcJIT&list_id=162232&query_format=advanced&resolution> --- > > While some of them are obviously outdated (addModuleSet API cleanup > [1]), others may actually be relevant again (Small code model? [2]). If > you reported one of them, please take the time (some day) and review > from today's perspective. > > Are there recommendations regarding Bugzilla reports from other parts of > LLVM? Best practices that worked out well? > > Thanks! > Stefan > > -- > > [1] https://bugs.llvm.org/show_bug.cgi?id=30896 > [2] https://bugs.llvm.org/show_bug.cgi?id=24159 > > -- https://flowcrypt.com/pub/stefan.graenitz at gmail.com > > >-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20190518/4cab3062/attachment-0001.html>
Hi Stefan, As for https://reviews.llvm.org/D61599 , I do not have commit access so I am waiting for Lang or someone else to commit this patch. This fixes https://bugs.llvm.org/show_bug.cgi?id=41690 . I can also confirm that this other bug that I reported a while ago is still relevant with ORCv2: https://bugs.llvm.org/show_bug.cgi?id=40074 It is a rather impactful one on COFF/Windows. There is an effective workaround though. The COFF side of ORC still needs a few other workarounds to be enabled for it to work properly. It could use some more developer attention. One off them I believe is a workaround for https://bugs.llvm.org/show_bug.cgi?id=25493, so that one is still relevant as well. I might contribute some more patches in that direction in the future if I can find the time, though I have limited experience with llvm. Cheers Machiel On Sat, May 18, 2019 at 6:03 PM Stefan Gränitz <stefan.graenitz at gmail.com> wrote:> In fact, this is all very good practice in my opinion: > https://bugs.llvm.org/show_bug.cgi?id=30896 > https://bugs.llvm.org/show_bug.cgi?id=22608 > https://bugs.llvm.org/show_bug.cgi?id=24159 > > Back in 2016 I simply didn't know about the Bugzilla tracker. > From today's perspective, I think, we should try and revive this spirit > and share rough plans there. > > @Praveen very good initiative! > https://bugs.llvm.org/show_bug.cgi?id=41075 > > @Machiel: This is quite recent, but didn't land after it was accepted. > Objections? > https://reviews.llvm.org/D61599 > > Cheers > -------- Forwarded Message -------- > Subject: Bugzilla OrcJIT Tickets > Date: Sat, 18 May 2019 17:47:58 +0200 > From: Stefan Gränitz <stefan.graenitz at gmail.com> > <stefan.graenitz at gmail.com> > To: via llvm-dev <llvm-dev at lists.llvm.org> <llvm-dev at lists.llvm.org> > > Hello everyone > > A previous thread about OrcJIT brought up bug reports on Bugzilla. A > quick search gives 20+ results: > > https://bugs.llvm.org/buglist.cgi?component=OrcJIT&list_id=162232&query_format=advanced&resolution> --- > > While some of them are obviously outdated (addModuleSet API cleanup > [1]), others may actually be relevant again (Small code model? [2]). If > you reported one of them, please take the time (some day) and review > from today's perspective. > > Are there recommendations regarding Bugzilla reports from other parts of > LLVM? Best practices that worked out well? > > Thanks! > Stefan > > -- > > [1] https://bugs.llvm.org/show_bug.cgi?id=30896 > [2] https://bugs.llvm.org/show_bug.cgi?id=24159 > > -- https://flowcrypt.com/pub/stefan.graenitz at gmail.com > > >-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20190519/b22aefd2/attachment.html>