Duncan P. N. Exon Smith
2014-Jun-27 20:53 UTC
[LLVMdev] Another phabricator feature request...
> On 2014-Jun-27, at 11:48, Manuel Klimek <klimek at google.com> wrote: > > On Fri, Jun 27, 2014 at 7:39 PM, Chandler Carruth <chandlerc at gmail.com> wrote: > I know you worked hard to make sure that updating a revision doesn't send email unless there is text typed into one of the boxes Manuel, but I think we should by default put some text into a box (and send the email unless the user deletes that text) when accepting a revision. Otherwise, the final LGTM can accidentally happen on Phab and not reach the mailing list (D4178 for example). > > Thoughts? > > I had hoped we can educate people using phab that only text they write gets sent to the list, and that they should only send things to the list, and not manage the state in phab.Is there a way of disabling the state management interface in phab entirely? Then the only way for people to "accept" something is by typing text to that effect.> I think wanting to make it possible to make the state in phab more in line with what's visible on the list would be great, but I have problems finding the spare cycles currently (given that I spend most of my phab time cycles with maintenance due to DMARC / other email problems). > _______________________________________________ > LLVM Developers mailing list > LLVMdev at cs.uiuc.edu http://llvm.cs.uiuc.edu > http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev
On 27 June 2014 21:53, Duncan P. N. Exon Smith <dexonsmith at apple.com> wrote:> Then the only way for people to "accept" something is by typing text > to that effect.If you don't "Accept" the patch, you can't close the issue. So, either we send an email when people accept the patch (with LGTM or not, doesn't matter), or we remove the restriction on closing pending reviews. cheers, --renato
On Mon, Jun 30, 2014 at 10:48 AM, Renato Golin <renato.golin at linaro.org> wrote:> On 27 June 2014 21:53, Duncan P. N. Exon Smith <dexonsmith at apple.com> > wrote: > > Then the only way for people to "accept" something is by typing text > > to that effect. > > If you don't "Accept" the patch, you can't close the issue. So, either > we send an email when people accept the patch (with LGTM or not, > doesn't matter), or we remove the restriction on closing pending > reviews. >I'm not sure why those are related - you can simply self-accept a revision (which probably shouldn't send an LG). This is because many people don't use phab, and so the LG only comes via the mailing list.> > cheers, > --renato >-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20140630/d0aacbe1/attachment.html>