llvm dev - May 2014 - [LLVMdev] Is it ok to nuke fpcmp and llvm-PerfectShuffle utils?

On Wed, Apr 30, 2014 at 1:37 PM, Hal Finkel <hfinkel at anl.gov> wrote:
> ----- Original Message -----
> > From: "Alexey Samsonov" <samsonov at google.com>
> > To: "LLVM Developers Mailing List" <llvmdev at
cs.uiuc.edu>
> > Sent: Wednesday, April 30, 2014 3:30:12 PM
> > Subject: [LLVMdev] Is it ok to nuke fpcmp and llvm-PerfectShuffle
utils?
> >
> >
> >
> > They are not used in the regression test suite anymore, and are not
> > even built in CMake build tree.
>
> You cannot nuke llvm-PerfectShuffle... that is the utility used to
> generate the lib/Target/ARM64/ARM64PerfectShuffle.h,
> lib/Target/ARM/ARMPerfectShuffle.h and
> lib/Target/PowerPC/PPCPerfectShuffle.h files.
>
Ouch, indeed... Is it ok it has no build rules? If yes, we can just break
the dependency between test suite and this utility.

>
>  -Hal
>
> >
> >
> >
> >
> > --
> >
> >
> > Alexey Samsonov, Mountain View, CA
> > _______________________________________________
> > LLVM Developers mailing list
> > LLVMdev at cs.uiuc.edu         http://llvm.cs.uiuc.edu
> > http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev
> >
>
> --
> Hal Finkel
> Assistant Computational Scientist
> Leadership Computing Facility
> Argonne National Laboratory
>


-- 
Alexey Samsonov, Mountain View, CA
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20140430/410d35bc/attachment.html>

----- Original Message -----
> From: "Alexey Samsonov" <samsonov at google.com>
> To: "Hal Finkel" <hfinkel at anl.gov>
> Cc: "LLVM Developers Mailing List" <llvmdev at cs.uiuc.edu>
> Sent: Wednesday, April 30, 2014 3:43:42 PM
> Subject: Re: [LLVMdev] Is it ok to nuke fpcmp and llvm-PerfectShuffle
utils?
> 
> 
> 
> 
> 
> On Wed, Apr 30, 2014 at 1:37 PM, Hal Finkel < hfinkel at anl.gov >
> wrote:
> 
> 
> 
> ----- Original Message -----
> > From: "Alexey Samsonov" < samsonov at google.com >
> > To: "LLVM Developers Mailing List" < llvmdev at
cs.uiuc.edu >
> > Sent: Wednesday, April 30, 2014 3:30:12 PM
> > Subject: [LLVMdev] Is it ok to nuke fpcmp and llvm-PerfectShuffle
> > utils?
> > 
> > 
> > 
> > They are not used in the regression test suite anymore, and are not
> > even built in CMake build tree.
> 
> You cannot nuke llvm-PerfectShuffle... that is the utility used to
> generate the lib/Target/ARM64/ARM64PerfectShuffle.h,
> lib/Target/ARM/ARMPerfectShuffle.h and
> lib/Target/PowerPC/PPCPerfectShuffle.h files.
> 
> 
> 
> Ouch, indeed... Is it ok it has no build rules?
I think that it should have build rules. If nothing else, can you file a bug
report on this?
> If yes, we can just
> break the dependency between test suite and this utility.
I don't understand why the test suite depends on llvm-PerfectShuffle
explicitly; I suspect breaking the dependency would be fine.

 -Hal
> 
> 
> 
> -Hal
> 
> 
> > 
> > 
> > 
> > 
> > --
> > 
> > 
> > Alexey Samsonov, Mountain View, CA
> > _______________________________________________
> > LLVM Developers mailing list
> > LLVMdev at cs.uiuc.edu http://llvm.cs.uiuc.edu
> > http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev
> > 
> 
> --
> Hal Finkel
> Assistant Computational Scientist
> Leadership Computing Facility
> Argonne National Laboratory
> 
> 
> 
> 
> --
> 
> 
> Alexey Samsonov, Mountain View, CA
-- 
Hal Finkel
Assistant Computational Scientist
Leadership Computing Facility
Argonne National Laboratory

>> Ouch, indeed... Is it ok it has no build rules?
>
> I think that it should have build rules. If nothing else, can you file a
bug report on this?
It is building using configure + make. In good old days the perfect
shuffle tables for PPC were generated through the normal build process
like .td files. However, this was pretty useless - they do not change
and thus perfectshuffle was excluded from the build process.

-- 
With best regards, Anton Korobeynikov
Faculty of Mathematics and Mechanics, Saint Petersburg State University