On 10 December 2013 15:00, Joerg Sonnenberger <joerg at britannica.bec.de> wrote:> On Tue, Dec 10, 2013 at 02:26:53PM +0000, Renato Golin wrote: >> In a nutshell, it seems to be our consensus that the integrated >> assembly can now be turned on by default on ARM, and we should add >> -no-integrated-as for the cases where it fails (like the kernel). > > It can't assemble basic PIC code as created by clang -S for ELF > platforms.Is there a PR for this? We should link it to one of the issues that exist for integrated-as.> That's IMO a pretty big show stopper.I disagree. It's nice and probably should be a priority to fix, but it's not the standard use-situation for Clang. Cheers. Tim.
On Tue, Dec 10, 2013 at 03:26:56PM +0000, Tim Northover wrote:> On 10 December 2013 15:00, Joerg Sonnenberger <joerg at britannica.bec.de> wrote: > > On Tue, Dec 10, 2013 at 02:26:53PM +0000, Renato Golin wrote: > >> In a nutshell, it seems to be our consensus that the integrated > >> assembly can now be turned on by default on ARM, and we should add > >> -no-integrated-as for the cases where it fails (like the kernel). > > > > It can't assemble basic PIC code as created by clang -S for ELF > > platforms. > > Is there a PR for this? We should link it to one of the issues that > exist for integrated-as. > > > That's IMO a pretty big show stopper. > > I disagree. It's nice and probably should be a priority to fix, but > it's not the standard use-situation for Clang.Without it, -save-temps is broken. As such it falls into a pretty basic use case. Joerg
On 10 December 2013 15:26, Tim Northover <t.p.northover at gmail.com> wrote:> Is there a PR for this? We should link it to one of the issues that > exist for integrated-as.Or create a new one. If you use "arm integrated assembler" in the subject line, we can make a filter for all of them.> I disagree. It's nice and probably should be a priority to fix, but > it's not the standard use-situation for Clang.We have just moved to 3.5svn, and there will be a good number of months to clear the most egregious bugs in the integrated assembler. There are also a good number of people working on that right now, so I don't expect those matters to be forgotten easily. We tried to do the same last year but there were even more serious bugs in the IAS. Now, we can run the tests, the test-suite, benchmarks, large programs (such as Chromium) and so on. It seems to be the perfect time to not forget about this, but to also have a smaller number of critical bugs to fix before the next release. cheers, --renato
On 10 December 2013 15:35, Joerg Sonnenberger <joerg at britannica.bec.de> wrote:> Without it, -save-temps is broken. As such it falls into a pretty > basic use case.Hi Joerg, I couldn't find anything in bugzilla that matched your description, but it seems like a pretty bad problem, can you point us to the discussion so we can decide whether it should be fixed now, or after the move. thanks, --renato
On Tue, Dec 10, 2013 at 04:35:57PM +0100, Joerg Sonnenberger wrote:> On Tue, Dec 10, 2013 at 03:26:56PM +0000, Tim Northover wrote: > > On 10 December 2013 15:00, Joerg Sonnenberger <joerg at britannica.bec.de> wrote: > > > On Tue, Dec 10, 2013 at 02:26:53PM +0000, Renato Golin wrote: > > >> In a nutshell, it seems to be our consensus that the integrated > > >> assembly can now be turned on by default on ARM, and we should add > > >> -no-integrated-as for the cases where it fails (like the kernel). > > > > > > It can't assemble basic PIC code as created by clang -S for ELF > > > platforms. > > > > Is there a PR for this? We should link it to one of the issues that > > exist for integrated-as. > > > > > That's IMO a pretty big show stopper. > > > > I disagree. It's nice and probably should be a priority to fix, but > > it's not the standard use-situation for Clang. > > Without it, -save-temps is broken. As such it falls into a pretty > basic use case.With the recent driver change, I will qualify that as "Clang should be buildable with -via-file-asm" as criterion for making IAS the default for a platform. I think that's a reasonable criterion. Joerg