On Tuesday 04 August 2009 10:46, Chris Lattner wrote:> On Aug 4, 2009, at 8:29 AM, Aaron Gray wrote: > > How do output hex in DOUT's ? > > Please don't use DOUT, please use: > > DEBUG(errs() << stuff); > > instead.I've got some more DOUT-involving patches in the queue. Is this a general design choice that's been made? If so I can change the patches to use errs() instead, but the choice should be documented and DOUT should be marked deprecated if indeed that's the case. -Dave
On Aug 4, 2009, at 2:50 PM, David Greene wrote:> On Tuesday 04 August 2009 10:46, Chris Lattner wrote: >> On Aug 4, 2009, at 8:29 AM, Aaron Gray wrote: >>> How do output hex in DOUT's ? >> >> Please don't use DOUT, please use: >> >> DEBUG(errs() << stuff); >> >> instead. > > I've got some more DOUT-involving patches in the queue. Is this > a general design choice that's been made? If so I can change the > patches to use errs() instead, but the choice should be documented > and DOUT should be marked deprecated if indeed that's the case.I'd prefer for it to be eliminated, but it is currently used widely. If your patches don't make it substantially worse, I won't have a problem with them. Bonus points for removing DOUTs though :) -Chris
On Tuesday 04 August 2009 17:52, Chris Lattner wrote:> I'd prefer for it to be eliminated, but it is currently used widely. > If your patches don't make it substantially worse, I won't have a > problem with them. Bonus points for removing DOUTs though :)Ok, this is good to know. With some of these patches I will have opportunities to remove DOUTS. What's the rationale for getting rid of it? -Dave