llvm dev - May 2009 - [LLVMdev] [PATCH] llvm-config: add svn revision to --version

On May 18, 2009, at 11:35 AM, Frits van Bommel wrote:
> Török Edwin wrote:
>> I think you don't need to support all trunk revisions.
>> People using trunk could be told to either update to a certain  
>> revision,
>> or stick to a released version.
>
> We don't support /all/ trunk revisions, but we don't like to force
> upgrades
> unless it's really needed so we try to at least support most recent  
> revisions.
I agree that this is a really useful thing to support. On side of  
being willing to break APIs is that we should work hard to make people  
with out-of-tree code be able to cope with this, even though we  
shouldn't be afraid of breaking APIs.

The idea of the patch to add the new option to llvm-config sounds  
great to me.  One concern: does an svn up now cause a complete relink  
of all llvm tools?  Ideally, I'd like to see something like this:


$ svn up
u docs/LangRef.html
$ make
... only llvm-config is "rebuilt" ...

-Chris

Chris Lattner wrote:
> The idea of the patch to add the new option to llvm-config sounds
> great to me.  One concern: does an svn up now cause a complete relink
> of all llvm tools?  Ideally, I'd like to see something like this:
In the current version of my patch the revision is only updated on a  
re-configure/CMake. On a second thought that is quite stupid. But I'm  
not sure what's the best way to fix this. I guess we need to add a  
target which is always run to llvm-config's Makefile ...

Benjamin Kramer <benny.kra at googlemail.com> writes:
> In the current version of my patch the revision is only updated on a  
> re-configure/CMake. On a second thought that is quite stupid. But I'm  
> not sure what's the best way to fix this. I guess we need to add a  
> target which is always run to llvm-config's Makefile ...
This is easy: see the logic for regenerating llvm-config when the file
that contains the library dependencies changes.

Why do you use `svn info' and not `svnversion'?

And this brings another question: how do you deal with modified working
copies?

-- 
Óscar Fuentes
Desarrollo de Software