Artur Pietrek
2009-Apr-02 12:21 UTC
[LLVMdev] Patch: MSIL backend global pointers initialization
Hi, Here's a patch that fixes initialization of global pointers (also function pointers). I'm working on that backend now, so probably I'll send some more patches soon. I'd be grateful if you could give me some suggestions how to add some test for that backend to the test-suite. On Linux the output code could be run on Mono and compared with outputs for other backends but I'm not sure if it's preferable to involve third party apps. Thanks for help Artur -------------- next part -------------- A non-text attachment was scrubbed... Name: globals_init_fix.patch Type: text/x-patch Size: 3013 bytes Desc: not available URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20090402/e8c3f71d/attachment.bin>
Anton Korobeynikov
2009-Apr-03 11:30 UTC
[LLVMdev] Patch: MSIL backend global pointers initialization
Hi, Artur> I'm working on that backend now, so probably I'll send some more patches > soon. I'd be grateful if you could give me some suggestions how to add > some test for that backend to the test-suite. On Linux the output code > could be run on Mono and compared with outputs for other backends but > I'm not sure if it's preferable to involve third party apps.Tests usually should be self-contained. So, you can, for example, just grep the output for "critical" points, which should always be there. Please refine you patches to be consistent with LLVM's coding style and I'll apply them. Thanks! -- With best regards, Anton Korobeynikov. Faculty of Mathematics & Mechanics, Saint Petersburg State University.
Artur Pietrek
2009-Apr-03 13:25 UTC
[LLVMdev] Patch: MSIL backend global pointers initialization
Anton Korobeynikov wrote:> Hi, Artur > > >> I'm working on that backend now, so probably I'll send some more patches >> soon. I'd be grateful if you could give me some suggestions how to add >> some test for that backend to the test-suite. On Linux the output code >> could be run on Mono and compared with outputs for other backends but >> I'm not sure if it's preferable to involve third party apps. >> > Tests usually should be self-contained. So, you can, for example, just > grep the output for "critical" points, which should always be there. >Ok, thanks.> Please refine you patches to be consistent with LLVM's coding style and > I'll apply them. >I'm sorry, attached again. So again, one of them makes the global pointers initialization work. The second one allows executing code with vararg pinvoke functions under Mono. It generates separate function declaration for each call signature. Artur -------------- next part -------------- A non-text attachment was scrubbed... Name: varargs.patch Type: text/x-patch Size: 5307 bytes Desc: not available URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20090403/b21f8234/attachment.bin> -------------- next part -------------- A non-text attachment was scrubbed... Name: globals_init_fix.patch Type: text/x-patch Size: 3011 bytes Desc: not available URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20090403/b21f8234/attachment-0001.bin>
Maybe Matching Threads
- [LLVMdev] Patch: MSIL backend global pointers initialization
- [LLVMdev] Patch: MSIL backend global pointers initialization
- [LLVMdev] Patch: MSIL backend global pointers initialization
- [LLVMdev] Patch: MSIL backend global pointers initialization
- [LLVMdev] Patch: MSIL backend global pointers initialization