Piotr Rak
2009-Jan-28 12:44 UTC
[LLVMdev] [cfe-commits] r63168 - /cfe/trunk/Driver/clang.cpp
2009/1/28 Mike Stump <mrs at apple.com>:> Author: mrs > Date: Tue Jan 27 20:43:35 2009 > New Revision: 63168 > > URL: http://llvm.org/viewvc/llvm-project?rev=63168&view=rev > Log: > Add a preliminary version number. > > Modified: > cfe/trunk/Driver/clang.cpp > > Modified: cfe/trunk/Driver/clang.cpp > URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/Driver/clang.cpp?rev=63168&r1=63167&r2=63168&view=diff > > =============================================================================> --- cfe/trunk/Driver/clang.cpp (original) > +++ cfe/trunk/Driver/clang.cpp Tue Jan 27 20:43:35 2009 > @@ -1620,6 +1620,10 @@ > } > } > > + if (Verbose) > + fprintf(stderr, "clang version 1.0 based upon " PACKAGE_STRING > + " hosted on " LLVM_HOSTTRIPLE "\n"); > + > if (unsigned NumDiagnostics = Diags.getNumDiagnostics()) > fprintf(stderr, "%d diagnostic%s generated.\n", NumDiagnostics, > (NumDiagnostics == 1 ? "" : "s")); > > > _______________________________________________ > cfe-commits mailing list > cfe-commits at cs.uiuc.edu > http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits >Hi, This commit braeks cmake build for me. PACKAGE_STRING is not set by llvm toplevel CMakeList.txt, and later defined by 'include/llvm/Config/config.h.cmake'. I also changed PACKAGE_VERSION to match with one from 'configure.ac'. Attached fix (for llvm). Piotr -------------- next part -------------- A non-text attachment was scrubbed... Name: cmake_package_string.diff Type: text/x-patch Size: 923 bytes Desc: not available URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20090128/eb251d86/attachment.bin>
Chris Lattner
2009-Jan-28 17:49 UTC
[LLVMdev] [cfe-commits] r63168 - /cfe/trunk/Driver/clang.cpp
On Jan 28, 2009, at 4:44 AM, Piotr Rak wrote:> > This commit braeks cmake build for me. PACKAGE_STRING is not set by > llvm toplevel CMakeList.txt, and later defined by > 'include/llvm/Config/config.h.cmake'. > I also changed PACKAGE_VERSION to match with one from 'configure.ac'.Applied, many thanks! http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20090126/072818.html -Chris
steve naroff
2009-Feb-02 15:24 UTC
[LLVMdev] [cfe-commits] r63168 - /cfe/trunk/Driver/clang.cpp
Hi Piortr, This also breaks the hand-built VC++ project. Any clues on where I should define this? Thanks, snaroff -------------- next part -------------- A non-text attachment was scrubbed... Name: Picture 7.png Type: image/png Size: 13645 bytes Desc: not available URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20090202/eb726ff5/attachment.png> -------------- next part -------------- On Jan 28, 2009, at 7:44 AM, Piotr Rak wrote:> 2009/1/28 Mike Stump <mrs at apple.com>: >> Author: mrs >> Date: Tue Jan 27 20:43:35 2009 >> New Revision: 63168 >> >> URL: http://llvm.org/viewvc/llvm-project?rev=63168&view=rev >> Log: >> Add a preliminary version number. >> >> Modified: >> cfe/trunk/Driver/clang.cpp >> >> Modified: cfe/trunk/Driver/clang.cpp >> URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/Driver/clang.cpp?rev=63168&r1=63167&r2=63168&view=diff >> >> >> >> >> >> >> >> >> >> >> ====================================================================>> --- cfe/trunk/Driver/clang.cpp (original) >> +++ cfe/trunk/Driver/clang.cpp Tue Jan 27 20:43:35 2009 >> @@ -1620,6 +1620,10 @@ >> } >> } >> >> + if (Verbose) >> + fprintf(stderr, "clang version 1.0 based upon " PACKAGE_STRING >> + " hosted on " LLVM_HOSTTRIPLE "\n"); >> + >> if (unsigned NumDiagnostics = Diags.getNumDiagnostics()) >> fprintf(stderr, "%d diagnostic%s generated.\n", NumDiagnostics, >> (NumDiagnostics == 1 ? "" : "s")); >> >> >> _______________________________________________ >> cfe-commits mailing list >> cfe-commits at cs.uiuc.edu >> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits >> > > Hi, > > This commit braeks cmake build for me. PACKAGE_STRING is not set by > llvm toplevel CMakeList.txt, and later defined by > 'include/llvm/Config/config.h.cmake'. > I also changed PACKAGE_VERSION to match with one from 'configure.ac'. > > Attached fix (for llvm). > > Piotr > < > cmake_package_string > .diff>_______________________________________________ > cfe-commits mailing list > cfe-commits at cs.uiuc.edu > http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
Piotr Rak
2009-Feb-02 18:26 UTC
[LLVMdev] [cfe-commits] r63168 - /cfe/trunk/Driver/clang.cpp
2009/2/2 steve naroff <snaroff at apple.com>:> Hi Piortr, > > This also breaks the hand-built VC++ project. > > Any clues on where I should define this? > > Thanks, > > snaroff > > > > > > On Jan 28, 2009, at 7:44 AM, Piotr Rak wrote: > >> 2009/1/28 Mike Stump <mrs at apple.com>: >>> >>> Author: mrs >>> Date: Tue Jan 27 20:43:35 2009 >>> New Revision: 63168 >>> >>> URL: http://llvm.org/viewvc/llvm-project?rev=63168&view=rev >>> Log: >>> Add a preliminary version number. >>> >>> Modified: >>> cfe/trunk/Driver/clang.cpp >>> >>> Modified: cfe/trunk/Driver/clang.cpp >>> URL: >>> http://llvm.org/viewvc/llvm-project/cfe/trunk/Driver/clang.cpp?rev=63168&r1=63167&r2=63168&view=diff >>> >>> >>> >>> >>> >>> >>> >>> >>> >>> >>> ====================================================================>>> --- cfe/trunk/Driver/clang.cpp (original) >>> +++ cfe/trunk/Driver/clang.cpp Tue Jan 27 20:43:35 2009 >>> @@ -1620,6 +1620,10 @@ >>> } >>> } >>> >>> + if (Verbose) >>> + fprintf(stderr, "clang version 1.0 based upon " PACKAGE_STRING >>> + " hosted on " LLVM_HOSTTRIPLE "\n"); >>> + >>> if (unsigned NumDiagnostics = Diags.getNumDiagnostics()) >>> fprintf(stderr, "%d diagnostic%s generated.\n", NumDiagnostics, >>> (NumDiagnostics == 1 ? "" : "s")); >>> >>> >>> _______________________________________________ >>> cfe-commits mailing list >>> cfe-commits at cs.uiuc.edu >>> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits >>> >> >> Hi, >> >> This commit braeks cmake build for me. PACKAGE_STRING is not set by >> llvm toplevel CMakeList.txt, and later defined by >> 'include/llvm/Config/config.h.cmake'. >> I also changed PACKAGE_VERSION to match with one from 'configure.ac'. >> >> Attached fix (for llvm). >> >> Piotr >> < >> cmake_package_string >> .diff>_______________________________________________ >> cfe-commits mailing list >> cfe-commits at cs.uiuc.edu >> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits > > >Hi Steve, No idea, sorry, I use linux x86 now. There must be some way to generate correct llvm/config.h there though. Maybe you should check PACKAGE_VERSION and similar is done there? Piotr