Yes please. Evan On Oct 5, 2007, at 11:55 AM, Arnold Schwaighofer wrote:> > On 5 Oct 2007, at 20:47, Evan Cheng wrote: > >> >> On Oct 5, 2007, at 10:56 AM, Arnold Schwaighofer wrote: >> >>> >>>> We can set a policy of treating fastcc external functions >>>> as c functions. Then there is no chance of introducing ABI >>>> incompatibility. >>> this means limiting tail call opt to protected/invisible functions >>> within a module? >>> a little limiting i think. >> >> It makes sense to be extra careful at this point. The policy can be >> changed when we enable tail call optimization by default. >>> >>> but i think if it is documented that there will be a incompatibility >>> between >>> modules compiled with tailcallopt on/off that is okay? >>> and this would only happen if someone other than llvm-gcc used llvm >>> as a backend >>> anyway. >> >> Documentation isn't going to be enough. We will do everything >> possible to ensure there isn't abi incompatibility. But at this >> point, it's important the patch does not impact codegen in any way >> when tail call optimization is off. This allows us to get a true >> sense of the performance impact. >> > > okay then i'll make tailcallopt switch stack adjusting behaviour? > _______________________________________________ > LLVM Developers mailing list > LLVMdev at cs.uiuc.edu http://llvm.cs.uiuc.edu > http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev
On 5 Oct 2007, at 20:58, Evan Cheng wrote:> Yes please. > > Evanokay :^)
Another round ;) Sadly not beer. tested against r42630 darwin-x86: SPASS llc-beta still fails thanks for the patience On 5 Oct 2007, at 20:58, Evan Cheng wrote:> Yes please. >> okay then i'll make tailcallopt switch stack adjusting behaviour?the patch for the test suite (when/if it's needed) would be something like: >>>>> --- Makefile.programs (revision 42630) +++ Makefile.programs (working copy) @@ -221,7 +221,8 @@ LLCBETAOPTION := -sched=simple endif ifeq ($(ARCH),x86) -LLCBETAOPTION := -enable-x86-conv-3-addr +LLCBETAOPTION := -tailcallopt +# -enable-x86-conv-3-addr #-regalloc=local -fast #-disable-rematerialization #-disable-fp-elim >>>>> gee i am tired really have to go to bed now. regards -------------- next part -------------- A non-text attachment was scrubbed... Name: tailcall-r42653-llvm.patch Type: application/octet-stream Size: 68087 bytes Desc: not available URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20071006/ab7a199c/attachment.obj>
Ok. Like I said, I am not too concerned with one or two llcbeta failures. That's expected. Thx, Evan On Oct 5, 2007, at 3:18 PM, Arnold Schwaighofer <arnold.schwaighofer at gmail.com > wrote:> Another round ;) Sadly not beer. > > tested against r42630 darwin-x86: > SPASS llc-beta still fails > > thanks for the patience > > On 5 Oct 2007, at 20:58, Evan Cheng wrote: > >> Yes please. >>> okay then i'll make tailcallopt switch stack adjusting behaviour? > > > > the patch for the test suite (when/if it's needed) would be > something like: > >>>>> > --- Makefile.programs (revision 42630) > +++ Makefile.programs (working copy) > @@ -221,7 +221,8 @@ > LLCBETAOPTION := -sched=simple > endif > ifeq ($(ARCH),x86) > -LLCBETAOPTION := -enable-x86-conv-3-addr > +LLCBETAOPTION := -tailcallopt > +# -enable-x86-conv-3-addr > #-regalloc=local -fast > #-disable-rematerialization > #-disable-fp-elim > >>>>> > > > gee i am tired really have to go to bed now. > regards > > <tailcall-r42653-llvm.patch> > _______________________________________________ > LLVM Developers mailing list > LLVMdev at cs.uiuc.edu http://llvm.cs.uiuc.edu > http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev