Brendan Bolles
2014-Jan-06 18:28 UTC
[opus] Possible bug in opus_multistream_surround_encoder_create()
I get reliable crashes if I create a 6-channel encoder using opus_multistream_surround_encoder_create(). If I use opus_multistream_encoder_create() instead and pass in the same parameters that opus_multistream_surround_encoder_create() sends out (streams = 4, coupled_streams = 2, mapping = {0, 4, 1, 2, 3, 5}) I don't get the crashes. I notice that opus_demo.c uses opus_multistream_surround_encoder_create(), but then that file also doesn't support more than two channels. I only got my crashes when using 6 channels. Brendan
Jean-Marc Valin
2014-Jan-06 21:47 UTC
[opus] Possible bug in opus_multistream_surround_encoder_create()
The crash is in opus_multistream_surround_encoder_create() or when trying to encode? Does the opus-tools code works for you for a 5.1 input? Jean-Marc On 01/06/2014 01:28 PM, Brendan Bolles wrote:> I get reliable crashes if I create a 6-channel encoder using > opus_multistream_surround_encoder_create(). If I use > opus_multistream_encoder_create() instead and pass in the same > parameters that opus_multistream_surround_encoder_create() sends out > (streams = 4, coupled_streams = 2, mapping = {0, 4, 1, 2, 3, 5}) I > don't get the crashes. > > I notice that opus_demo.c uses > opus_multistream_surround_encoder_create(), but then that file also > doesn't support more than two channels. I only got my crashes when > using 6 channels. > > > Brendan > > _______________________________________________ opus mailing list > opus at xiph.org http://lists.xiph.org/mailman/listinfo/opus >
Brendan Bolles
2014-Jan-06 21:50 UTC
[opus] Possible bug in opus_multistream_surround_encoder_create()
On Jan 6, 2014, at 1:47 PM, Jean-Marc Valin wrote:> The crash is in opus_multistream_surround_encoder_create() or when > trying to encode? Does the opus-tools code works for you for a 5.1 input?It crashes on the first call to opus_multistream_encode_float(). I haven't had a chance to experiment with opus-tools yet. Brendan