Nouveau - Aug 2014 - [PATCH envytools] nvamemtiming: Handle target < initial case when iterating values

On 31/08/2014 15:00, Christian Costa wrote:
> Otherwise some values are not tested at all.
I would rather have a warning than the program doing stuff behind my 
back. This is a dev tool, dumb == good ;)

Le 31/08/2014 15:12, Martin Peres a ?crit :
> On 31/08/2014 15:00, Christian Costa wrote:
>> Otherwise some values are not tested at all.
> I would rather have a warning than the program doing stuff behind my 
> back. This is a dev tool, dumb == good ;)
>
But why didn't you call it Dumb mode rather that Deep mode. That way, I 
wouldn't have tried to use it and figure out what it does. ;p

So about my problem,

Command:
sudo nvamemtiming pramin 0x6a22 3 0 -d 5

Vbios info:
Table offset at 0x6a22
Entry 3 => 0x6a73: 0d 06 0f 26 00 45 00 1b 00 0b 0d 08 04 0c 01 00 00 00 
03 03 10 0a 09 00 03
Entry 5 => 0x6aa5: 05 04 08 05 00 09 00 03 00 02 02 02 02 0c 02 00 00 00 
03 03 08 0a 0f 00 02

With the current code, I get these iterations:
timing table at: 6a22
Deep mode: Will iterate between 5 and 24
idx 5, initial 45, target 9
idx 7, initial 1b, target 3
idx 9, initial b, target 2
idx 10, initial d, target 2
idx 11, initial 8, target 2
idx 12, initial 4, target 2
idx 13, initial c, target c
idx 18, initial 3, target 3
idx 19, initial 3, target 3
idx 20, initial 10, target 8
idx 21, initial a, target a
idx 22, initial 9, target f => a b c d e f
idx 24, initial 3, target 2

It does not test much for the reason most of the time the target value 
is lower than the initial one.

With my patch:
timing table at: 6a22
Deep mode: Will iterate between 5 and 24
idx 5, initial 45, target 9 => 44 43 42 41 40 3f 3e 3d 3c 3b 3a 39 38 37 
36 35 34 33 32 31 30 2f 2e 2d 2c 2b 2a 29 28 27 26 25 24 23 22 21 20 1f 
1e 1d 1c 1b 1a 19 18 17 16 15 14 13 12 11 10 f e d c b a 9
idx 7, initial 1b, target 3 => 1a 19 18 17 16 15 14 13 12 11 10 f e d c 
b a 9 8 7 6 5 4 3
idx 9, initial b, target 2 => a 9 8 7 6 5 4 3 2
idx 10, initial d, target 2 => c b a 9 8 7 6 5 4 3 2
idx 11, initial 8, target 2 => 7 6 5 4 3 2
idx 12, initial 4, target 2 => 3 2
idx 13, initial c, target c
idx 18, initial 3, target 3
idx 19, initial 3, target 3
idx 20, initial 10, target 8 => f e d c b a 9 8
idx 21, initial a, target a
idx 22, initial 9, target f => a b c d e f
idx 24, initial 3, target 2 =>2

Maybe shallow mode would be enough to test timing but what the purpose 
of deep mode in that case ?

Christian

On 31/08/2014 16:01, Christian Costa wrote:
> Le 31/08/2014 15:12, Martin Peres a ?crit :
>> On 31/08/2014 15:00, Christian Costa wrote:
>>> Otherwise some values are not tested at all.
>> I would rather have a warning than the program doing stuff behind my 
>> back. This is a dev tool, dumb == good ;)
>>
> But why didn't you call it Dumb mode rather that Deep mode. That way, 
> I wouldn't have tried to use it and figure out what it does. ;p
Target is supposed to be higher than initial! Initial == minimum safe 
timing.

You just reversed the order, try:
sudo nvamemtiming pramin 0x6a22 5 0 -d 3