similar to: nbdkit test failure with new libnbd

Try doing: $ nbdsh nbd> h.connect_command (["nbdkit", "-s", "null"]) At this point you may observe your laptop fan starts to spin and nbdkit is consuming 100% of CPU. In all other respects everything works fine, you can send commands etc. Anyway I tracked the issue down. nbdkit sits in a loop continuously reading stdin, each read(2) call returning EAGAIN.

On Thu, Aug 15, 2019 at 09:27:14AM -0500, Eric Blake wrote: > The 0.9.8 release breaks API, requiring a number of changes: > - Use symbolic constants instead of magic numbers/open-coded strings > (well, the string for "base:allocation" was present before this > libnbd bump) > - Change callbacks to drop the valid_flag parameter > - Add _is to nbd_read_only call >

On Thu, Jul 04, 2019 at 09:14:13AM +0100, Richard W.M. Jones wrote: >On Thu, Jul 04, 2019 at 09:45:26AM +0200, Martin Kletzander wrote: >> On Wed, Jul 03, 2019 at 05:17:42PM +0100, Richard W.M. Jones wrote: >> >Two simple patches which make libnbd compile on FreeBSD. >> > >> >Are we OK to copy common/include/byte-swapping.h from nbdkit? There >> >is no

On Tue, Aug 13, 2019 at 06:34:11AM -0500, Eric Blake wrote: > On 8/13/19 5:06 AM, Richard W.M. Jones wrote: > > An optional Closure parameter, but otherwise works the same way as > > Closure. > > > @@ -3778,6 +3777,7 @@ let generate_lib_api_c () = > > ) args; > > List.iter ( > > function > > + | OClosure { cbname } -> pr

The idea and patch is fine, but I wonder if it would be more useful to callers if it was exposed as two separate APIs. Callers would then not need to deal with masking out unknown flags, and it works more like the other is_* / can_* ("flag calls") we already have. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and

On Sat, Jun 15, 2019 at 04:56:37PM -0500, Eric Blake wrote: > Once ocamlfind is installed, 'make' failed for me with: > > ocamlfind ocamlc -g -annot -safe-string -warn-error CDEFLMPSUVYZX+52-3 -ccopt '-gdwarf' -package unix -c NBD.ml -o NBD.cmo > File "NBD.ml", line 1: > Error: Could not find the .cmi file for interface NBD.mli. > make[2]: ***

https://aur.archlinux.org/packages/nbdkit/#comment-733981 reports that tests-parallel-nbd.sh hangs. Looking at the log file from the test reveals: nbdkit: backend.c:523: backend_flush: Assertion `h->can_flush == 1' failed. I've attached the full log. If you want to see other logs from the run (probably not relevant) then download

On Thu, Jul 04, 2019 at 09:45:26AM +0200, Martin Kletzander wrote: > On Wed, Jul 03, 2019 at 05:17:42PM +0100, Richard W.M. Jones wrote: > >Two simple patches which make libnbd compile on FreeBSD. > > > >Are we OK to copy common/include/byte-swapping.h from nbdkit? There > >is no license issue that I know of. Should we put it in lib/ or > >create a common/

BTW you might be interested in a ‘fio’ backend I wrote for testing NBD servers. The current public version is here: https://www.spinics.net/lists/fio/msg07831.html but I also now have a version based on libnbd although it's not quite ready for use. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog:

On Thu, Apr 23, 2020 at 07:04:14PM +0100, Richard W.M. Jones wrote: > +# probably should *not* use this in most cases, since your plugin will > +# may end up containing hard paths to the local nbdkit sources. "will may" -> "may" in my local copy. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and

Indeed this test fails: test dos 2 1 <<'EOF' disk2: start=1024 size=1023 type=L EOF with the error "MBR partition 2 not found". I'll see about fixing this. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-p2v converts physical machines to virtual

[NB: This is posted to the public libguestfs mailing list] Fabien, I just posted a very (very) rough set of patches to the mailing list: https://www.redhat.com/archives/libguestfs/2020-March/msg00170.html I think what would help me from here is if there is someone in the KubeVirt community who could help me with making the golang bindings more natural. I'm obviously not a regular golang

On Wed, May 15, 2019 at 10:57:57PM -0500, Eric Blake wrote: > It's easy to expose new callbacks to sh plugins, by borrowing > tri-state code from can_fua. It's possible that nbdkit emulate will > actually work well (in our example.sh script, the kernel caching a > pread from one dd invocation may indeed speed up the next access), but > for the sake of the example, I

For #26, #27, #28, #29: Reviewed-by: Richard W.M. Jones <rjones at redhat.com> -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-p2v converts physical machines to virtual machines. Boot with a live CD or over the network (PXE) and turn machines into KVM guests.

On Mon, Sep 30, 2019 at 12:15:42PM -0500, Eric Blake wrote: > Test the just-fixed bug in --run failing to detect an nbdkit assertion > failure. > > While at it, sleep less when we don't actually need to wait for the > socket to be opened. > > Signed-off-by: Eric Blake <eblake@redhat.com> > --- > tests/test-captive.sh | 46

On Mon, Sep 28, 2020 at 05:05:16PM -0500, Eric Blake wrote: > + "get_meta_context", { > + default_call with > + args = [ Int "i" ]; ret = RString; Previously we have only used the Int parameter type for things which are plausibly integers (timeouts, signal numbers). This one really ought to be an unsigned or better still a size_t. Would it help if I provided

On Thu, Sep 19, 2019 at 11:12:23AM -0500, Eric Blake wrote: > > + open) > > + # Count how many times the connection is (re-)opened. > > + i=`cat retry-reopen-fail-open-count` > > $() is nicer than ``, but even better is just: > > read i retry-reopen-fail-open-count Did you mean: read i < retry-reopen-fail-open-count Unfortunately it fails when

On Mon, Jan 07, 2019 at 04:41:17PM +0100, Pino Toscano wrote: > One option I see is to export, as part of the nbdkit Python module > interface, the equivalent of sys.version_info: this way, the scripts > can detect which python version is the plugin linked with: nbdkit >= 1.8 exports the Python version in ‘--dump-plugin’ output: $ nbdkit python --dump-plugin ... python_version=2.7.15

While I normally port across dependent changes too (eg you mention that libnbd doesn't have get-current-dir-name.h - I would have ported the commit that introduced that too, even though it's not used except by the test), I'm also not that fussed. These are separate projects and as long as the common code is not unnecessarily different or inconsistent, it'll be fine. So ACK

On Wed, Nov 15, 2017 at 10:50:06AM -0600, Eric Blake wrote: > Tell automake that we want ./nbdkit to be kept up-to-date in the > developer's tree. Otherwise, after touching nbdkit.in, you would > have to remember to manually run 'make nbdkit'. > > Signed-off-by: Eric Blake <eblake@redhat.com> > --- > Makefile.am | 2 ++ > 1 file changed, 2 insertions(+)