similar to: [PATCH] Link .mli files corresponding to autorgenerated .ml files into builddir

On Tue, Jan 14, 2020 at 12:04:49AM +0100, Hilko Bengen wrote: > This avoids build failures in separate builds such as this one: > > ,---- > | ocamlfind ocamlc -package str,unix -I . -a guestfs_config.cmo stringMap.cmo stringSet.cmo std_utils.cmo -o mlstdutils.cma > | ar cr libmlstdutils.a libmlstdutils_a-dummy.o > | ranlib libmlstdutils.a > | File "_none_", line 1:

On Tuesday, 14 January 2020 00:04:49 CET Hilko Bengen wrote: > This avoids build failures in separate builds such as this one: > > ,---- > | ocamlfind ocamlc -package str,unix -I . -a guestfs_config.cmo stringMap.cmo stringSet.cmo std_utils.cmo -o mlstdutils.cma > | ar cr libmlstdutils.a libmlstdutils_a-dummy.o > | ranlib libmlstdutils.a > | File "_none_", line 1:

* Pino Toscano: > I do not think this is the correct approach. See my analysis here: > https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=946594#46 This issue is for a different problem that appeared on some architectures after I forced *config.ml to be regenerated for the Debian builds of libguestfs 1.40.2, see

On Thu, Dec 12, 2019 at 11:01:02AM +0100, Vincent Danjean wrote: > [resend to the good (cloned) bug, sorry for the message in the original bug, > it was a mistake] > > Hi, > > On Thu, 5 Dec 2019 11:12:56 +0000 "Richard W.M. Jones" <rjones@redhat.com> wrote: > > I believe this is a new bug and nothing much to do with: > >

On Sun, Nov 17, 2019 at 7:03 PM Richard W.M. Jones <rjones@redhat.com> wrote: > > On Sun, Nov 17, 2019 at 06:07:48PM +0200, Nir Soffer wrote: > > Looks like virt-v2v cannot be built now, since it requires non-existing version > > of libguestfs-devel. > > > > Based on (no README or any instructions in virt-v2v) > >

Looks like virt-v2v cannot be built now, since it requires non-existing version of libguestfs-devel. Based on (no README or any instructions in virt-v2v) http://libguestfs.org/guestfs-building.1.html I tried this: git clean -dxf ./autogen.sh And it fails with: --- Checking for libraries used by virt-v2v --- checking for pkg-config... /usr/bin/pkg-config checking pkg-config is at least version

v1 -> v2: - Fixed everything mentioned in patch review. - Libdir module is removed as a separate commit. Rich.

I did not touch virt-v2v for a while, and I cannot build it now. There are not instructions in the README on under docs, so I tried the common stuff: $ ./autogen.sh ... Next you should type 'make' to build the package, ... $ make make all-recursive make[1]: Entering directory '/home/nsoffer/src/virt-v2v' Making all in common/mlstdutils make[2]: Entering directory

They will be generated by configure. --- mlstdutils/Makefile.am | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/mlstdutils/Makefile.am b/mlstdutils/Makefile.am index d29255e..2b4aed8 100644 --- a/mlstdutils/Makefile.am +++ b/mlstdutils/Makefile.am @@ -19,9 +19,12 @@ include $(top_srcdir)/subdir-rules.mk EXTRA_DIST = \ $(SOURCES_MLI) \ - $(SOURCES_ML) \ +

Followup/fix of commit 61d4891ef48df171a27873efe90aab51a9b711ef. --- builder/Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/builder/Makefile.am b/builder/Makefile.am index 09ae4ae..e64c899 100644 --- a/builder/Makefile.am +++ b/builder/Makefile.am @@ -311,7 +311,7 @@ depend: .depend .depend: $(wildcard $(abs_srcdir)/*.mli) $(wildcard $(abs_srcdir)/*.ml) rm -f

This works reliably for me ... Rich.

They do not contain messages. --- Makefile.am | 1 + po/POTFILES-ml | 11 ----------- 2 files changed, 1 insertion(+), 11 deletions(-) diff --git a/Makefile.am b/Makefile.am index 4dde5002..46a52ca3 100644 --- a/Makefile.am +++ b/Makefile.am @@ -115,6 +115,7 @@ po/POTFILES-ml: configure.ac grep -v '^common/mlprogress/' | \ grep -v '^common/mlvisit/' | \ grep -v

Even if ocamlopt is available, always build a bytecode version of ‘common/mlstdutils’. Furthermore, because this library is pure OCaml, we should not be using ‘ocamlmklib’. We should use ‘ocaml{c,opt} -a’ instead. This doesn't make any difference for native code, but for bytecode it was building a broken library. The original reason for making this change is because the generator is always

This is just the utilities part of the patch series from: https://www.redhat.com/archives/libguestfs/2017-June/msg00103.html I believe this addresses everything raised in comments on that patch series. Rich.

This turned out to be rather more involved than I thought. We have lots of utility functions, spread all over the repository, with not a lot of structure. This moves many of them under common/ and structures them so there are clear dependencies. This doesn't complete the job by any means. Other items I had on my to-do list for this change were: - Split up mllib/common_utils into: -

Removed extra $(OCAML_BYTES_COMPAT_CMO). Add if HAVE_OCAMLOPT around the call to ocamlopt. Tested with OCaml 4.01 on RHEL 7. Rich.

v3 -> v4: Use HAVE_OCAMLOPT in both places.

On distros with OCaml < 4.02 we need to create a compatibility Bytes module. However we didn't create the interface file (bytes.mli) which would mean that dependencies wouldn't be created correctly for parallel builds. This commit uses ‘ocaml -i’ to create an interface file which exports everything. --- .gitignore | 1 + m4/guestfs-ocaml.m4 | 3 ++- 2 files changed, 3

Prune from the list of sources where to extract messages various sources with no messages: - .pl and .pm files, as they do not contain messages: almost all the .pl files are tests, and the only .pm file is the Perl Sys::Guestfs module, which wraps the XS extension - dummy.c sources; they are empty sources used to build OCaml-only targets using automake - gperf generated sources - C/OCaml

This is a combination of: https://www.redhat.com/archives/libguestfs/2017-June/msg00046.html [PATCH 00/12] Refactor utility functions. plus: https://www.redhat.com/archives/libguestfs/2017-June/msg00023.html [PATCH v3 00/19] Allow APIs to be implemented in OCaml. with the second patches rebased on top of the utility refactoring, and some other adjustments and extensions. This passes