similar to: [PATCH] lvm: support lvm2 older than 2.02.107

lvm2 2.02.107 adds the -S/--select option used in lvs to filter out only public LVs (see RHBZ#1278878). To make this work again with versions of lvm2 older than that, only on old versions filter out thin layouts and compose the resulting device strings ourselves. The filtering done is much simplier than what "-S lv_role=public" will do, but should be good enough for our need. ---

--- daemon/Makefile.am | 2 + daemon/lvm.c | 151 ---------------------------------------------- daemon/lvm.ml | 92 ++++++++++++++++++++++++++++ daemon/lvm.mli | 19 ++++++ generator/actions_core.ml | 1 + 5 files changed, 114 insertions(+), 151 deletions(-) diff --git a/daemon/Makefile.am b/daemon/Makefile.am index 22a3036f8..e9c71ba3c 100644

When listing logical volumes, ignore the ones which don't get activated automatically. No /dev/VG/LV device node is created for these ones which confuses APIs that attempt to do 'guestfs_lvs' followed by opening the device node. Note that 'guestfs_lvs_full' is unaffected by this change. --- daemon/lvm.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git

Hi, this series improves the way LVM is used in the appliance: in particular, now lvmetad can eventually run at all, and with the correct configuration. Also improve the listing strategies. Thanks, Pino Toscano (5): daemon: lvm-filter: set also global_filter daemon: lvm-filter: start lvmetad better daemon: lvm: improve filter for LVs with activationskip flag set daemon: lvm: list

When a disk image uses LVM thinp (thin provisioning), the guestfs_lvs API would return the thinp pools. This confused other APIs because thinp pools don't have corresponding /dev/VG/LV device nodes. Filter the LVs that are returned using "lv_role=public". Thanks: Fabian Deutsch --- daemon/lvm.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/daemon/lvm.c

v2 was here: https://www.redhat.com/archives/libguestfs/2017-June/msg00008.html This series gets as far as a working (and faster) reimplementation of ‘guestfs_list_filesystems’. I also have another patch series on top of this one which reimplements the inspection APIs inside the daemon, but that needs a bit more work still, since inspection turns out to be a very large piece of code. Rich.

v1 was posted here: https://www.redhat.com/archives/libguestfs/2017-July/msg00098.html This series now depends on two small patches which I posted separately: https://www.redhat.com/archives/libguestfs/2017-July/msg00207.html https://www.redhat.com/archives/libguestfs/2017-July/msg00209.html v1 -> v2: - Previously changes to generator/daemon.ml were made incrementally through the patch

I think this fixes everything mentioned: - Added the Optgroups module as suggested. - Remove command temporary files. - Replace command ~flags with ?fold_stdout_on_stderr. - Nest _with_mounted function. - Rebase & retest. Rich.

The appliance has no LVM system ID set, which means that lvm commands will ignore VGs with a system ID set to anything. Since we want to work with them, pass --foreign at least when listing them to see them. See also lvmsystemid(7). --- daemon/lvm.c | 10 ++++++---- generator/daemon.ml | 1 + 2 files changed, 7 insertions(+), 4 deletions(-) diff --git a/daemon/lvm.c b/daemon/lvm.c

Hi, this series improves the way LVM is used in the appliance: in particular, now lvmetad can eventually run at all, and with the correct configuration. Also improve the listing strategies. Changes in v2: - dropped patch #5, will be sent separately - move lvmetad statup in own function (patch #2) Thanks, Pino Toscano (4): daemon: lvm-filter: set also global_filter daemon: lvm-filter:

Previously posted as part of the mega utilities/inspection series here: https://www.redhat.com/archives/libguestfs/2017-June/msg00232.html What I've done is to extract just the parts related to rewriting daemon APIs in OCaml, rebase them on top of the current master, fix a few things, and recompile and test everything. Rich.

Hi! I need to convert a KVM virtual machine from LVM to a qcow2 image, and wonder if this is the best way to do it (*1): [$] qemu-img convert -O qcow2 /dev/vg_name/lv_name/ /var/lib/libvirt/images/image_name.qcow2 If this is the best way to do this, will this keep the information on: /dev/vg_name/lv_name/ untouched? Thanks, and please point me towards another mailing list if this it not right

This is a simpler patch that removes GUESTFSD_EXT_CMD completely.

Replace GUESTFSD_EXT_CMD with a command line option ‘./guestfsd --print-external-commands’

On Tuesday 10 November 2015 12:06:21 Richard W.M. Jones wrote: > When a disk image uses LVM thinp (thin provisioning), the guestfs_lvs > API would return the thinp pools. This confused other APIs because > thinp pools don't have corresponding /dev/VG/LV device nodes. > > Filter the LVs that are returned using "lv_role=public". > > Thanks: Fabian Deutsch >

On Wed, Jan 27, 2016 at 07:06:46PM +0100, Pino Toscano wrote: > char ** > do_lvs (void) > { > char *out; > CLEANUP_FREE char *err = NULL; > int r; > + int has_S = test_lvs_has_S_opt (); > + if (has_S < 0) > return NULL; I think this doesn't do the right thing on the second failing call to test_lvs_has_S_opt, because it won't return a

This hook script tries to address the fact that a RHEV-H installation will format all the storage devices available in the machine in order to create HostVG and AppVG with all the available space. It may be the case that RHEV-H needs to respect and co-exist with a proposed partitioning scheme, not getting all the storage space for HostVG and AppVG volume groups. The proposed solution adds the

I can't seem to find the answer to this question via web search... I changed some hardware on a server, and upon powering it back on, got the "/dev/xxx has gone 40 days without being check, check forced" message. Now it's running fsck on a huge (2 TB) ext3 filesystem (5400 RPM drives no less). How can I stop this in-progress check? Ctrl-C doesn't seem to have any effect.

It looks like older versions of lvm2 (recent enough to have selectors) do not recognize '1' (and '0') as boolean values. Switch to 'yes', which seems to be supported. Updates commit 7367945647e774aec4b93c3bf13181212d3c6430. --- daemon/lvm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/daemon/lvm.c b/daemon/lvm.c index a270b13..c186a5a 100644 ---

This is a combination of: https://www.redhat.com/archives/libguestfs/2017-June/msg00046.html [PATCH 00/12] Refactor utility functions. plus: https://www.redhat.com/archives/libguestfs/2017-June/msg00023.html [PATCH v3 00/19] Allow APIs to be implemented in OCaml. with the second patches rebased on top of the utility refactoring, and some other adjustments and extensions. This passes