similar to: [PATCH] gobject: Add pkg-config for gobject bindings

The gobject bindings generate a large number of header files, which pollute /usr/include when installed. This patch moves them all into a guestfs-gobject/ subdirectory. guestfs-gobject.h remains in the same place. This change also moves generated source files into src/, because it makes the gobject directory a bit tidier. --- generator/Makefile.am | 3 +

Certain functions are intended to be internal only, but we currently export them anyway. This change moves them into a separate section of guestfs.h protected by a GUESTFS_PRIVATE variable. This change also enables private structs, but doesn't implement any. This change only affects the C api. Language bindings aren't affected, but probably should be in the future. --- align/Makefile.am

This is the first iteration of the GObject bindings. I have 'kicked the tyres' on these, meaning I have ensured that a bunch of basic manual tests work as expected. I'm in the process of adding more comprehensive tests. Here's an example simple javascript program which uses these bindings: === const Guestfs = imports.gi.Guestfs; print('Starting'); var g = new

This patch replaces patches 14 and 15 from my previous series. The gtk-doc output is now reasonable, and we can rely on an automatically generated guestfs-sections.txt. Matt

Since we removed gtk doc, we might as well replace it with a manual page explaining the basics of how to run gjs. --- .gitignore | 2 ++ docs/guestfs-recipes.pod | 1 + erlang/examples/guestfs-erlang.pod | 1 + gobject/Makefile.am | 19 +++++++++++ gobject/guestfs-gobject.pod | 64 ++++++++++++++++++++++++++++++++++++++

This is a snapshot of gobject bindings. This is literally mid-edit, and contains numerous known errors in its output! I'm posting it for review of the ocaml code. Matt -- Matthew Booth, RHCA, RHCSS Red Hat Engineering, Virtualisation Team GPG ID: D33C3490 GPG FPR: 3733 612D 2D05 5458 8A8A 1600 3441 EA19 D33C 3490 -------------- next part -------------- An embedded and charset-unspecified

I've attached the generated gobject bindings for direct review. Matt -- Matthew Booth, RHCA, RHCSS Red Hat Engineering, Virtualisation Team GPG ID: D33C3490 GPG FPR: 3733 612D 2D05 5458 8A8A 1600 3441 EA19 D33C 3490 -------------- next part -------------- A non-text attachment was scrubbed... Name: Guestfs-1.0.gir Type: text/xml Size: 435504 bytes Desc: not available URL:

--- gobject/TODO.txt | 9 +++++++++ 1 files changed, 9 insertions(+), 0 deletions(-) create mode 100644 gobject/TODO.txt diff --git a/gobject/TODO.txt b/gobject/TODO.txt new file mode 100644 index 0000000..7ac64da --- /dev/null +++ b/gobject/TODO.txt @@ -0,0 +1,9 @@ +Tasks required before the GObject bindings can be considered complete: + +* Fix the problem of inspect_get_type +* Build the

Matt, I don't know if it worries you or not, but the new scheme does create rather a lot of header files directly in /usr/include: /usr/include/guestfs-gobject-optargs-add_domain.h /usr/include/guestfs-gobject-optargs-add_drive_opts.h /usr/include/guestfs-gobject-optargs-btrfs_filesystem_resize.h /usr/include/guestfs-gobject-optargs-compress_device_out.h

also remove guestfs-gobject.c Signed-off-by: Wanlong Gao <gaowanlong at cn.fujitsu.com> --- gobject/Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gobject/Makefile.am b/gobject/Makefile.am index 4744cd2..be6d58e 100644 --- a/gobject/Makefile.am +++ b/gobject/Makefile.am @@ -38,7 +38,7 @@ EXTRA_DIST = \ # Remove the old generated files which were

Matt, further to the conversation today. When you run the tests (make -C gobject check) you'll find it now prints the descriptive message: "GObject bind tests skipped: Int64, OInt64 and OStringList are all broken" That nicely sums up the first two problems. (1) When I tested passing the full range of int64, it turns out to be broken. There are probably two layers of

Use PRIu64 to correctly handle uint64_t. --- generator/gobject.ml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/generator/gobject.ml b/generator/gobject.ml index 5deb87e..5b07edd 100644 --- a/generator/gobject.ml +++ b/generator/gobject.ml @@ -722,6 +722,7 @@ let generate_gobject_session_source () = #include <stdint.h> #include <stdio.h> #include

This patch is still corrupt. If you can't use git send-email, then try using an email attachment. Thanks, Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-builder quickly builds VMs from scratch http://libguestfs.org/virt-builder.1.html

Here is the attachment. Corentin Le mardi 22 janvier 2019 à 15:34 +0000, Richard W.M. Jones a écrit : > This patch is still corrupt. If you can't use git send-email, then > try using an email attachment. > > Thanks, > > Rich. > --=-aTsmf5bEc4PPFwS1NYMU Content-Disposition: attachment; filename="0001-gobject-Add-Vala-binding-support.patch"

On Tue, Jan 22, 2019 at 01:05:41PM +0000, Richard W.M. Jones wrote: > From 610c8206ecd991be372650c2914bbffd9af057fb Mon Sep 17 00:00:00 2001 > From: =?UTF-8?q?Corentin=20No=C3=ABl?= <corentin.noel@collabora.com> > Date: Tue, 22 Jan 2019 13:12:57 +0100 > Subject: [PATCH] gobject: Add Vala binding support > > --- > .gitignore | 1 + >

Read the README file at the top of this patch first. Problems I see with GObject Introspection: (1) Requires that your code uses GObject; obvious in hindsight given the name. In this case, it seems that we'd have to "register" the guestfs_h structure with GObject (whatever that means). (2) Cannot convert C error codes into exceptions automatically. So all your high level code

I tried using Javascript (gjs) with GObject-Introspection and did a port of the create_disk example which is attached below. Quite a bit of time was spent looking up stuff in the GLib reference and guessing how certain idioms translate to gjs. I used the traditional add_drive_opts method since I haven't been able to find how to specify the optional arguments to add_drive_opts. How does that

Generate proper deprecation markers for API documentation and introspection annotations. --- generator/gobject.ml | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/generator/gobject.ml b/generator/gobject.ml index 5b07edd..e563610 100644 --- a/generator/gobject.ml +++ b/generator/gobject.ml @@ -961,7 +961,8 @@ guestfs_session_close (GuestfsSession *session, GError **err)

These are the changes I made to the spec file related to gobject bindings and gobject introspection. TBH I wasn't sure how to properly package this. Rich. diff --git a/libguestfs.spec b/libguestfs.spec index 095a848..1b6e43d 100644 --- a/libguestfs.spec +++ b/libguestfs.spec @@ -29,7 +29,7 @@ Summary: Access and modify virtual machine disk images Name: libguestfs Epoch:

Here is a patch adding Vala bindings support if the GObject Introspection is also available. >From 610c8206ecd991be372650c2914bbffd9af057fb Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Corentin=20No=C3=ABl?= <corentin.noel@collabora.com> Date: Tue, 22 Jan 2019 13:12:57 +0100 Subject: [PATCH] gobject: Add Vala binding support --- .gitignore | 1 + configure.ac