similar to: [PATCH] maint: use $var notation rather than ${var} when possible

--- ruby/Makefile.am | 4 ++-- ruby/Rakefile.in | 18 +++++++++--------- ruby/run-bindtests | 2 +- 3 files changed, 12 insertions(+), 12 deletions(-) diff --git a/ruby/Makefile.am b/ruby/Makefile.am index 112512b..032ace2 100644 --- a/ruby/Makefile.am +++ b/ruby/Makefile.am @@ -62,7 +62,7 @@ RUBY_SITEARCH := $(shell ruby -rrbconfig -e "puts

--- configure.ac | 4 +++- ruby/Makefile.am | 11 ++++++----- ruby/Rakefile.in | 2 +- ruby/run-bindtests | 2 +- ruby/run-ruby-tests | 4 ++-- 5 files changed, 13 insertions(+), 10 deletions(-) diff --git a/configure.ac b/configure.ac index ea0aec4..130db51 100644 --- a/configure.ac +++ b/configure.ac @@ -769,8 +769,10 @@ AC_ARG_ENABLE([ruby],

Introduce a new kind of bindings tests, 090-retvalues, to check all the possible return values in bindings; start implementing them for scripting languages such as GObject introspection, Perl, PHP, Python, and Ruby, reusing existing implementations where existing. --- docs/guestfs-hacking.pod | 1 + gobject/Makefile.am | 4 +-

Since we removed gtk doc, we might as well replace it with a manual page explaining the basics of how to run gjs. --- .gitignore | 2 ++ docs/guestfs-recipes.pod | 1 + erlang/examples/guestfs-erlang.pod | 1 + gobject/Makefile.am | 19 +++++++++++ gobject/guestfs-gobject.pod | 64 ++++++++++++++++++++++++++++++++++++++

This change adds an explicit dependency on generator.ml for every file it generates, except java files. Java is left for another time because it's considerably trickier. This fixes parallel make, and will automatically re-create generated files when make is run from any directory. It also fixes the problem which efad4f53 was targetting. Specifically, src/guestfs_protocol.(c|h) had an

Without this change all the tests in the haskell bindings are rebuilt every time. The primary motivation for this change is to fix this. The fix for the above also allows parallel builds to be re-enabled. --- haskell/Makefile.am | 56 +++++++++++++++++++++++++++++++++++++++-------------- 1 file changed, 41 insertions(+), 15 deletions(-) diff --git a/haskell/Makefile.am b/haskell/Makefile.am

By adding common CLEANFILES and DISTCLEANFILES variables to common-rules.mk, we can remove these from most other Makefiles, and also clean files more consistently. Note that bin_PROGRAMS are already cleaned by 'make clean', so I removed cases where these were unnecessarily added to CLEANFILES. --- .gitignore | 1 + Makefile.am | 6

--- daemon/Makefile.am | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/daemon/Makefile.am b/daemon/Makefile.am index e23ce86..af075d7 100644 --- a/daemon/Makefile.am +++ b/daemon/Makefile.am @@ -42,10 +42,10 @@ noinst_LIBRARIES = libprotocol.a libprotocol_a_SOURCES = guestfs_protocol.c guestfs_protocol.h libprotocol_a_CFLAGS = -Wall -Wno-unused -fno-strict-aliasing

--- run.in | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/run.in b/run.in index 8fdf454..438a68c 100755 --- a/run.in +++ b/run.in @@ -140,15 +140,15 @@ export PERL_VALGRIND=1 export PERL_DESTRUCT_LEVEL=2 # For Python. -export PYTHON=@PYTHON@ +export PYTHON="@PYTHON@" prepend PYTHONPATH "$b/python/.libs" prepend PYTHONPATH

... and why they are (probably) not errors. > bindtextdomain > daemon/guestfsd.c > erlang/erl-guestfs-proto.c > examples/copy_over.c > examples/create_disk.c > examples/display_icon.c > examples/inspect_vm.c > examples/mount_local.c > examples/virt-dhcp-address.c > tests/c-api/test-add-drive-opts.c > tests/c-api/test-add-libvirt-dom.c >

With this, "make syntax-check" runs a few more tests, all passing. >From febff9d2a35c4f40abbaf8943146476bdeac671e Mon Sep 17 00:00:00 2001 From: Jim Meyering <meyering at redhat.com> Date: Tue, 4 Aug 2009 13:49:19 +0200 Subject: [PATCH 1/8] build: remove more files added by ./autogen.sh * po/LINGUAS: Remove file. * po/Makefile.in.in: Likewise. * po/Makevars: Likewise. *

Overwriting LD_LIBRARY_PATH broke some tests when running with fakeroot. --- align/Makefile.am | 2 +- cat/Makefile.am | 2 +- clone/Makefile.am | 2 +- df/Makefile.am | 2 +- edit/Makefile.am | 2 +- fish/Makefile.am | 2 +- haskell/Makefile.am | 2 +- ocaml/Makefile.am |

We would like to have a more flexible way to run tests, including running them on an installed copy of libguestfs, running them in parallel, and being able to express dependencies and ordering between tests and data files properly. Therefore introduce a test harness (test-harness) program which can run tests either from the locally built copy, or from an installed copy of the tests (in

On Thu, Jan 17, Richard W.M. Jones wrote: > On Wed, Jan 16, 2013 at 05:51:53PM +0100, Olaf Hering wrote: > > On Mon, Jan 14, Olaf Hering wrote: > > > This is a first attempt to build libguestfs with just a ocaml bytecode > > > compiler. The three tools written in ocaml will be build only when an > > > ocamlopt compiler is available. > > Here is a more

Hi Rich, I ran this command to spot a few typos: git ls-files|misspellings -f -|grep -v '^po' Here are fixes: >From ec62fad96cc2884c8fd43ecb550a8bcac317cca0 Mon Sep 17 00:00:00 2001 From: Jim Meyering <meyering at redhat.com> Date: Wed, 18 Apr 2012 11:15:57 +0200 Subject: [PATCH libguestfs] maint: fix doc typos Fix typos spotted by http://github.com/lyda/misspell-check. *

'make distcheck' calls us out for leaving files behind after 'make distclean' that were not present in the tarball. Either these files are expensive enough that end users should not be required to regenerate them (so they should be distributed), or they should be cleaned when a user asks to get back to the pristine tarball state. Automake suggests this hierarchy of cleaning:

We would like to have a more flexible way to run tests, including running them on an installed copy of libguestfs, running them in parallel, and being able to express dependencies and ordering between tests and data files properly. Therefore introduce a test harness (test-harness) program which can run tests either from the locally built copy, or from an installed copy of the tests (in

Thanks for the quick review, I addressed the comments but couldn't run `make dist` because of some issue with `libguestfs.pot` while building. So please review it carefully (even if I followed the recommended steps to include Vala support as written here https://wiki.gnome.org/Projects/Vala/UpstreamGuide#Autotools_Integration ) Regards, Corentin >From

We would like to have a more flexible way to run tests, including running them on an installed copy of libguestfs, running them in parallel, and being able to express dependencies and ordering between tests and data files properly. Therefore introduce a test harness (test-harness) program which can run tests either from the locally built copy, or from an installed copy of the tests (in

From: Hiroyuki_Katsura <hiroyuki.katsura.0513@gmail.com> Rust bindings: Add create / close functions Rust bindings: Add 4 bindings tests Rust bindings: Add generator of structs Rust bindings: Add generator of structs for optional arguments Rust bindings: Add generator of function signatures Rust bindings: Complete actions Rust bindings: Fix memory management Rust bindings: Add