similar to: [PATCH 0/2] Use guestfs_list_filesystems in all possible places.

On Tue, Jan 23, 2018 at 12:44:10AM +0200, Mykola Ivanets wrote: > Before I rush to change something I request your comments on the subject. > Let me know what do you think and if it does make sense. > > The issue: guesfs_list_filesystems is inconsistent in its output. The concept of guestfs_list_filesystem is that it returns a list something like the list that running ‘df’ inside a

Before I rush to change something I request your comments on the subject. Let me know what do you think and if it does make sense. The issue: guesfs_list_filesystems is inconsistent in its output. For, example, it filters out partitioned physical devices but doesn't do the same for MD devices. More over, according to its name and API documentation guestfs_list_filesystem should return

guestfs_list_filesystems uses mount/umount to discover btrfs sub-volumes and since 1.37 it generates random mountpoint so it will longer affect already mounted filesystems if either. --- generator/actions_core.ml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/generator/actions_core.ml b/generator/actions_core.ml index ed8cb16..9a695c0 100644 --- a/generator/actions_core.ml

Cédric pointed out this problem we have: $ guestmount -a /var/lib/libvirt/images/sles12sp1-pv.img -m '/dev/sda1:/:subvol=.snapshots/2/snapshot:btrfs' /mnt libguestfs: error: mount_vfs: /dev/sda1 on / (options: 'subvol=.snapshots/2/snapshot'): mount: mount(2) failed: No such file or directory guestmount: '/dev/sda1' could not be mounted. guestmount: Check mount(8) man page

2018-01-23 12:11 GMT+02:00 Richard W.M. Jones <rjones@redhat.com>: > On Tue, Jan 23, 2018 at 12:44:10AM +0200, Mykola Ivanets wrote: >> Before I rush to change something I request your comments on the subject. >> Let me know what do you think and if it does make sense. >> >> The issue: guesfs_list_filesystems is inconsistent in its output. > > The concept of

When you open a LUKS device, you have to associate it with a "raw" device mapper device (eg. /dev/mapper/lukstest). Previously there has been no way through the API to list such devices after they have been created. Also they are not revealed when you tab-complete /dev paths in guestfish. These two patches fix this. The first patch adds a new API called guestfs_list_dm_devices which

Hello, I've been trying to run the tests from master, before applying my patches and it's not not working. I always get this: # make -C tests/mountable check make: Entering directory `/root/src/libguestfs/tests/mountable' make test-internal-parse-mountable make[1]: Entering directory `/root/src/libguestfs/tests/mountable' make[1]: `test-internal-parse-mountable' is up to

This patch series: 1. Addresses comments from last review: part_get_mbr_part_type doesn't break original implementation in C. 2. Rebased on top of master and little bit refactored for readability. Mykola Ivanets (1): tests: md: Test guestfish list-filesystems command skips partitioned md devices. Nikolay Ivanets (2): daemon: Reimplement 'part_get_mbr_part_type' API in

libguestfs is tools and a library for accessing and modifying virtual machine disk images. Home page: http://libguestfs.org/ Source: http://libguestfs.org/download/ I'm pleased to announce the latest stable release of libguestfs 1.6.0 which is available immediately from the website and through Fedora. This represents an enormous amount of work over the last 4-5 months and

--- src/inspect-fs-unix.c | 22 +++++++--------------- src/inspect-fs.c | 21 ++++++--------------- 2 files changed, 13 insertions(+), 30 deletions(-) diff --git a/src/inspect-fs-unix.c b/src/inspect-fs-unix.c index 8ffd85d..c9bbad9 100644 --- a/src/inspect-fs-unix.c +++ b/src/inspect-fs-unix.c @@ -90,8 +90,8 @@ static int check_hostname_unix (guestfs_h *g, struct inspect_fs *fs); static

If the /etc/fstab of a guest contains devices specified with UUID or LABEL, then the new OCaml inspection code will report the findfs failure as general failure of the inspection. OTOH, the old C inspection code simply ignored all the devices that cannot be resolved. Hence, restore the old behaviour by ignoring unresolvable devices. --- daemon/inspect_fs_unix_fstab.ml | 12 ++++++++++-- 1 file

On Wed, Aug 02, 2017 at 12:33:14PM +0200, Pino Toscano wrote: > Hi, > > (replying here since v2 of the series does not have this explanation.) > > On Tuesday, 1 August 2017 16:00:15 CEST Richard W.M. Jones wrote: > > We'd like to use PCRE instead of the awful Str module. However I > > don't necessarily want to pull in the extra dependency of ocaml-pcre, >

On Tue, Dec 02, 2014 at 07:11:55PM +0200, Nikos Skalkotos wrote: > Signed-off-by: Nikos Skalkotos <skalkoto@grnet.gr> > --- > src/inspect-fs-unix.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/src/inspect-fs-unix.c b/src/inspect-fs-unix.c > index 01a59f1..f55e53b 100644 > --- a/src/inspect-fs-unix.c > +++ b/src/inspect-fs-unix.c

This is a fix for: https://bugzilla.redhat.com/show_bug.cgi?id=642930 These patches remove all use of the Perl inspection API (although leaving the code, since it is used by virt-v2v). The tools have been modified so they use the core inspection API. Virt inspector has been basically rewritten to remove excess cruft and to only use the core API (see the final commit for more details). Rich.

Small cosmetic changes. Signed-off-by: Matteo Cafasso <noxdafox@gmail.com> --- daemon/sleuthkit.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/daemon/sleuthkit.c b/daemon/sleuthkit.c index ce738e3..e642731 100644 --- a/daemon/sleuthkit.c +++ b/daemon/sleuthkit.c @@ -47,7 +47,8 @@ do_download_inode (const mountable_t *mountable, int64_t inode) } /*

Rebased. The only thing left unclear is: "Would you like to document behavior for non-MBR partitions more clearly or keep previous implementation despite MBR partition type doesn't make sense for non-MBR partitions at all?"

Add a new guestfs_int_merge_fs_inspections() function that merges the OS inspection information of two inspect_fs instances into one. This function is useful if the inspection information for an OS are gathered by inspecting multiple filesystems. Signed-off-by: Nikos Skalkotos <skalkoto@grnet.gr> --- src/guestfs-internal.h | 1 + src/inspect-fs.c | 115

With these I'm able to get all the way to the end of the build on OS X 10.5. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones virt-df lists disk usage of guests without needing to install any software inside the virtual machine. Supports Linux and Windows. http://et.redhat.com/~rjones/virt-df/

Add a new guestfs_int_merge_fs_inspections() function that merges the OS inspection information of two inspect_fs instances into one. This function is useful if the inspection information for an OS are gathered by inspecting multiple filesystems. Signed-off-by: Nikos Skalkotos <skalkoto@grnet.gr> --- src/guestfs-internal.h | 1 + src/inspect-fs.c | 102

I'll be holding a libguestfs live ?webinar? tomorrow, Friday, 18th November 2011 at 16:00 UTC. To convert the date and time to your timezone, do: date -d '2011-11-17 16:00Z' The programme will include: - An introduction to libguestfs features. - Live demonstrations of guestfish, a Python program, inspection, and image resizing. - An overview of major new features in RHEL 6.3.