search for: xmlsaveuri

Hi All, Here's the latest patch. I think this should address the problem. The query string is now only appended to the end of a URI in the HTTP and HTTPS cases. The add-uri test now passes, and 'make check' still passes. -- Gabriel

I have written a patch (please see attached) which fixes both of these bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1092583 https://bugzilla.redhat.com/show_bug.cgi?id=1232477 By default, when saving a URI using xmlSaveUri it escapes everything in the URI. QEMU doesn't want anything escaped, so now I unescape everything after the URI is generated. Unfortunately there's no flag to change the default behavior. The other problem was that only the "path" portion of the URI struct was being used to in...

Do not hardcode /tmp. --- make-fs/make-fs.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/make-fs/make-fs.c b/make-fs/make-fs.c index 1bec3e2..9c11fef 100644 --- a/make-fs/make-fs.c +++ b/make-fs/make-fs.c @@ -381,8 +381,9 @@ estimate_input (const char *input, uint64_t *estimate_rtn, char **ifmt_rtn) CLEANUP_FCLOSE FILE *fp = NULL; char line[256]; size_t len; +

> > > By default, when saving a URI using xmlSaveUri it escapes everything in > the URI. QEMU doesn't want anything escaped, so now I unescape > everything after the URI is generated. Unfortunately there's no flag to > change the default behavior. > > I'm not sure that's the actual issue here, but I'm somehow incl...

...2015 at 06:44:50PM +0000, Gabriel Hartmann wrote: > I have written a patch (please see attached) which fixes both of these bugs: > > https://bugzilla.redhat.com/show_bug.cgi?id=1092583 > https://bugzilla.redhat.com/show_bug.cgi?id=1232477 > > By default, when saving a URI using xmlSaveUri it escapes everything in the > URI. QEMU doesn't want anything escaped, so now I unescape everything > after the URI is generated. Unfortunately there's no flag to change the > default behavior. > > The other problem was that only the "path" portion of the URI st...

...work sniffer or getting a more clear error message regarding that the failure was because there's a "%3A" in the libvirt created URI, I cannot say for sure. But I would certainly be inclined to believe that could be the problem. The libvirt API 'virURIFormat()' will call 'xmlSaveUri()' to generate a URI from whatever is found in the pool or domain XML. I know that the generated URI has a '%3A' in it from my experience... John

...giugno 2015 18:44:50, Gabriel Hartmann ha scritto: > I have written a patch (please see attached) which fixes both of these bugs: > > https://bugzilla.redhat.com/show_bug.cgi?id=1092583 > https://bugzilla.redhat.com/show_bug.cgi?id=1232477 > > By default, when saving a URI using xmlSaveUri it escapes everything in the > URI. QEMU doesn't want anything escaped, so now I unescape everything > after the URI is generated. Unfortunately there's no flag to change the > default behavior. I'm not sure that's the actual issue here, but I'm somehow included to t...

...RI: %s\n", uri); - exit (EXIT_FAILURE); - } - if (asprintf (&new_path, "/%s", name) == -1) { - perror ("asprintf"); - exit (EXIT_FAILURE); - } - free (xmluri->path); - xmluri->path = new_path; - new_uri = (char *) xmlSaveUri (xmluri); + if (!name) { + fprintf (stderr, "unable to obtain export name: %s\n", + nbd_get_error ()); + exit (EXIT_FAILURE); + } - /* Connect to the new URI. */ - nbd2 = nbd_create (); - if (nbd2 == NULL) { - fprintf (stderr, "%s\...

(apologies if you see this twice, forgot the CC the first time) In data venerdì 26 giugno 2015 18:50:16, Gabriel Hartmann ha scritto: > > > > > By default, when saving a URI using xmlSaveUri it escapes everything in > > the URI. QEMU doesn't want anything escaped, so now I unescape > > everything after the URI is generated. Unfortunately there's no flag to > > change the default behavior. > > > > I'm not sure that's the actual issue here,...

...l Hartmann wrote: > > I have written a patch (please see attached) which fixes both of these > bugs: > > > > https://bugzilla.redhat.com/show_bug.cgi?id=1092583 > > https://bugzilla.redhat.com/show_bug.cgi?id=1232477 > > > > By default, when saving a URI using xmlSaveUri it escapes everything in > the > > URI. QEMU doesn't want anything escaped, so now I unescape everything > > after the URI is generated. Unfortunately there's no flag to change the > > default behavior. > > > > The other problem was that only the "pat...

v1 -> v2: - Rebase on top of Pino's version work. Two patches went upstream, these are the two remaining patches. Note the generation number is still inside the qemu.stat file. We could put it in the filename, I have no particular preference. Rich.

On 2013–12–23 John Ferlan wrote: > On 12/22/2013 10:09 AM, Marco wrote: > > On 2013–12–21 John Ferlan wrote: > > > >> On 12/17/2013 07:13 PM, Marco wrote: > >>> Hi! > >>> > >>> I'm new to libvirt and face problems connecting to an iSCSI target. > >>> What I intend to do is to connect libvirt (I tried virt-manager and

Doing qemu feature detection in the direct backend takes ~100ms because we need to run `qemu -help' and `qemu -devices ?', and each of those interacts with glibc's very slow link loader. Fixing the link loader is really hard. Instead memoize the output of those two commands. This patch series first separates all the code dealing with qemu into a separate module (src/qemu.c) and

...erver *server, const char *path) { xmlURI uri = { .scheme = (char *) scheme, .user = (char *) user }; CLEANUP_FREE char *query = NULL; CLEANUP_FREE char *pathslash = NULL; + CLEANUP_FREE char *userauth = NULL; /* Need to add a leading '/' to URI paths since xmlSaveUri doesn't. */ if (path[0] != '/') { @@ -1222,6 +1224,13 @@ make_uri (guestfs_h *g, const char *scheme, const char *user, else uri.path = (char *) path; + /* Rebuild user:password. */ + if (user != NULL && password != NULL) { + /* Keep the string in an own variabl...

QEMU upstream has broken snapshot=on ... again. These two patches stop using it entirely. Instead we run 'qemu-img create' to create overlay disks as required. Note that the libvirt and UML backends were already doing this: The libvirt backend because <transient/> has never worked, and the UML backend was running uml_mkcow because the UML-equivalent syntax of snapshot=on was

Well, I'm not quite done (I still want to get nbdinfo to work on a single nbd connection for all cases when reading the heads of the file is not required), but I'm happy with patches 1-11, and 12-13 show where I'm headed for getting NBD_OPT_INFO to work. Posting now to see if some of the earlier patches are ready to commit while I continue working on the latter half. Eric Blake (13):

In the kernel and qemu communities it is routine for patches that will be backported to stable branches to be posted for review. I'm proposing we do the same for libguestfs stable branches. All of the attached have been tested with 'make check-release'. Rich.