search for: truncate3

...(if nothing else, to have a list archive to point to when someone else complains about qemu-img changing output). tests/test-ip.sh | 4 ++-- tests/test-nbd-tls-psk.sh | 2 +- tests/test-nbd-tls.sh | 2 +- tests/test-tls-psk.sh | 2 +- tests/test-tls.sh | 2 +- tests/test-truncate3.sh | 2 +- 6 files changed, 7 insertions(+), 7 deletions(-) diff --git a/tests/test-ip.sh b/tests/test-ip.sh index 636d3d3f..60f2e066 100755 --- a/tests/test-ip.sh +++ b/tests/test-ip.sh @@ -59,7 +59,7 @@ ipv4_lo="$(ip -o -4 addr show scope host)" if test -n "$ipv4_lo"; then...

...ut it was easy enough to let these tests pass instead of skip when jq is not present. tests/test-ip.sh | 10 ++++++---- tests/test-nbd-tls-psk.sh | 6 +++--- tests/test-nbd-tls.sh | 6 +++--- tests/test-tls-psk.sh | 7 +++---- tests/test-tls.sh | 7 +++---- tests/test-truncate3.sh | 4 ++-- 6 files changed, 20 insertions(+), 20 deletions(-) diff --git a/tests/test-ip.sh b/tests/test-ip.sh index 636d3d3f..5a00a2ec 100755 --- a/tests/test-ip.sh +++ b/tests/test-ip.sh @@ -57,15 +57,17 @@ kill -s 0 $pid # Check we can connect over the IPv4 loopback interface. ipv4_lo=&q...

...on/include/rounding.h | 58 ++++++++++++++++++++++++++++++++++ filters/cache/Makefile.am | 3 +- filters/cache/cache.c | 2 +- filters/cow/Makefile.am | 3 +- filters/cow/cow.c | 2 +- filters/truncate/truncate.c | 5 +-- tests/Makefile.am | 4 ++- tests/test-truncate3.sh | 62 +++++++++++++++++++++++++++++++++++++ 8 files changed, 132 insertions(+), 7 deletions(-) diff --git a/common/include/rounding.h b/common/include/rounding.h new file mode 100644 index 0000000..ae1708c --- /dev/null +++ b/common/include/rounding.h @@ -0,0 +1,58 @@ +/* nbdkit + * Copyrig...

...------ tests/test-single.sh | 11 ++--------- tests/test-tls-psk.sh | 12 +++--------- tests/test-tls.sh | 12 +++--------- tests/test-truncate1.sh | 8 ++------ tests/test-truncate2.sh | 8 ++------ tests/test-truncate3.sh | 8 ++------ tests/test-zero.sh | 6 +----- 33 files changed, 87 insertions(+), 233 deletions(-) diff --git a/tests/functions.sh.in b/tests/functions.sh.in index 35647f7..289584a 100644 --- a/tests/functions.sh.in +++ b/tests/functions.sh.in @@ -1,7 +1,7 @@...

v1 was here: https://www.redhat.com/archives/libguestfs/2019-January/thread.html#00198 For v2 I changed most existing prerequisite tests to use the new mechanism. I only changed simple tests. There are a few more complex tests that don't fit the “requires model” and those are not changed. I normalized qemu-io/qemu-img testing to always use the --version flag, where previously we used a mix

The partitioning plugin patch is the same (except for rebasing). However I have changed the first two patches based on feedback received. In particular this fixes a very serious bug found by Eric Blake in the current truncate filter. Rich.

...++++ 2 files changed, 87 insertions(+) create mode 100755 tests/test-truncate4.sh diff --git a/tests/Makefile.am b/tests/Makefile.am index 4b7aa22..4148793 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -122,6 +122,7 @@ EXTRA_DIST = \ test-truncate1.sh \ test-truncate2.sh \ test-truncate3.sh \ + test-truncate4.sh \ test-truncate-extents.sh \ test-vddk.sh \ test-vddk-real.sh \ @@ -937,6 +938,7 @@ TESTS += \ test-truncate1.sh \ test-truncate2.sh \ test-truncate3.sh \ + test-truncate4.sh \ test-truncate-extents.sh # xz filter test. diff --git a/tests/test-truncate4.sh b...

...te mode 100755 tests/test-truncate4.sh > > diff --git a/tests/Makefile.am b/tests/Makefile.am > index 4b7aa22..4148793 100644 > --- a/tests/Makefile.am > +++ b/tests/Makefile.am > @@ -122,6 +122,7 @@ EXTRA_DIST = \ > test-truncate1.sh \ > test-truncate2.sh \ > test-truncate3.sh \ > + test-truncate4.sh \ > test-truncate-extents.sh \ > test-vddk.sh \ > test-vddk-real.sh \ > @@ -937,6 +938,7 @@ TESTS += \ > test-truncate1.sh \ > test-truncate2.sh \ > test-truncate3.sh \ > + test-truncate4.sh \ > test-truncate-extents.sh > &g...

While working on adding assertions to pthread_mutex_lock calls, I noticed that the truncate filter's use of mutex didn't really protect us, and isn't really necessary. Cleaning that up also spotted a couple of other potential cleanups. Eric Blake (4): filters: Drop useless .open callbacks truncate: Fix corruption when plugin changes per-connection size truncate: Test for safe

...+++++++++++++++++ tests/test-undefined-plugin.c | 70 +++++++++++++++++++++++++++++++++++ 3 files changed, 134 insertions(+) diff --git a/tests/Makefile.am b/tests/Makefile.am index f9c6b8ad..901dca7e 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -208,6 +208,7 @@ EXTRA_DIST = \ test-truncate3.sh \ test-truncate4.sh \ test-truncate-extents.sh \ + test-undefined.sh \ test-vddk.sh \ test-vddk-real.sh \ test-version.sh \ @@ -351,6 +352,33 @@ test_just_filter_header_CPPFLAGS = \ $(NULL) test_just_filter_header_CFLAGS = $(WARNINGS_CFLAGS) +# Build a plugin with libtool -undefin...

...diff --git a/tests/Makefile.am b/tests/Makefile.am index ecfc3612..2aa95890 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -206,6 +206,7 @@ EXTRA_DIST = \ test-tar.sh \ test-tls.sh \ test-tls-psk.sh \ + test-tmpdisk-command.sh \ test-truncate1.sh \ test-truncate2.sh \ test-truncate3.sh \ @@ -800,6 +801,7 @@ endif HAVE_PERL # tmpdisk plugin test. LIBGUESTFS_TESTS += test-tmpdisk +TESTS += test-tmpdisk-command.sh test_tmpdisk_SOURCES = \ test-tmpdisk.c \ diff --git a/plugins/tmpdisk/tmpdisk.c b/plugins/tmpdisk/tmpdisk.c index 5e8df151..6d8efc08 100644 --- a/plugins/tmpd...

v2 was here: https://www.redhat.com/archives/libguestfs/2020-April/msg00075.html In v3: - Add [VAR=VALUE ...] to manual. - Various minor improvements to the manual. - Work (at least, in theory - not tested) with block devices or symlinks. I didn't document this because it's hard to ensure these files or block devices would be cleaned up, so here be dragons. - Remove O_NOCTTY. -

v2: - Fixes a number of bugs in corner cases. - Uses a 1M block size to fetch from the underlying plugin. This improves performance considerably. I also tested this much more thoroughly and can't find any more bugs. Rich.

This has already been pushed upstream. I am simply posting these here so we have a reference in the mailing list in case we find bugs later (as I'm sure we will - it's a complex patch series). Great thanks to Eric Blake for tireless review on this one. It also seems to have identified a few minor bugs in qemu along the way. Rich.

Matt asked if xz should really be a filter rather than a plugin. The answer is yes, of course it should be! That's been something in the todo file for a while. The commit converts the xz plugin code into a filter (leaving the plugin around, but deprecating it). plugin: nbdkit xz file.xz filter: nbdkit --filter=xz file file.xz plugin: # can't be done filter: nbdkit

This creates libnbdkit.so as discussed in the following thread: https://www.redhat.com/archives/libguestfs/2020-March/thread.html#00203 test-delay-shutdown.sh fails for unclear reasons. This series starts by reverting "tests: Don't strand hung nbdkit processes" which is because several other tests fail randomly unless I revert this patch. I didn't investigate this yet so it