Displaying 16 results from an estimated 16 matches for "test_lvs_has_s_opt".
2016 Jan 27
4
[PATCH] lvm: support lvm2 older than 2.02.107
...ringsbuf (&ret) == -1)
+ return NULL;
+
+ return ret.argv;
+}
+
char **
do_pvs (void)
{
@@ -139,26 +219,76 @@ do_vgs (void)
return convert_lvm_output (out, NULL);
}
+/* Check whether lvs has -S to filter its output.
+ * It is available only in lvm2 >= 2.02.107.
+ */
+static int
+test_lvs_has_S_opt (void)
+{
+ static int result = -1;
+ if (result != -1)
+ return result;
+
+ CLEANUP_FREE char *out = NULL;
+ CLEANUP_FREE char *err = NULL;
+
+ int r = command (&out, &err, str_lvm, "lvs", "--help", NULL);
+ if (r == -1) {
+ reply_with_error ("lvm lvs -...
2016 Jan 28
0
Re: [PATCH] lvm: support lvm2 older than 2.02.107
On Wed, Jan 27, 2016 at 07:06:46PM +0100, Pino Toscano wrote:
> char **
> do_lvs (void)
> {
> char *out;
> CLEANUP_FREE char *err = NULL;
> int r;
> + int has_S = test_lvs_has_S_opt ();
> + if (has_S < 0)
> return NULL;
I think this doesn't do the right thing on the second failing call
to test_lvs_has_S_opt, because it won't return a protocol error?
> + /*NOTREACHED*/
> + assert (false);
> + return NULL;
> }
What's this bit for?...
2016 Jan 28
0
[PATCH v2] lvm: support lvm2 older than 2.02.107
...ringsbuf (&ret) == -1)
+ return NULL;
+
+ return ret.argv;
+}
+
char **
do_pvs (void)
{
@@ -139,26 +218,72 @@ do_vgs (void)
return convert_lvm_output (out, NULL);
}
+/* Check whether lvs has -S to filter its output.
+ * It is available only in lvm2 >= 2.02.107.
+ */
+static int
+test_lvs_has_S_opt (void)
+{
+ static int result = -1;
+ if (result != -1)
+ return result;
+
+ CLEANUP_FREE char *out = NULL;
+ CLEANUP_FREE char *err = NULL;
+
+ int r = command (&out, &err, str_lvm, "lvs", "--help", NULL);
+ if (r == -1) {
+ reply_with_error ("lvm lvs -...
2017 Jul 14
0
[PATCH 14/27] daemon: Reimplement ‘lvs’ API in OCaml.
...t) == -1)
- return NULL;
-
- return take_stringsbuf (&ret);
-}
-
char **
do_pvs (void)
{
@@ -222,74 +139,6 @@ do_vgs (void)
return convert_lvm_output (out, NULL);
}
-/* Check whether lvs has -S to filter its output.
- * It is available only in lvm2 >= 2.02.107.
- */
-static int
-test_lvs_has_S_opt (void)
-{
- static int result = -1;
- if (result != -1)
- return result;
-
- CLEANUP_FREE char *out = NULL;
- CLEANUP_FREE char *err = NULL;
-
- int r = command (&out, &err, str_lvm, "lvs", "--help", NULL);
- if (r == -1) {
- reply_with_error ("lvm lvs -...
2017 Jul 27
0
[PATCH v2] daemon: Remove GUESTFSD_EXT_CMD.
...gs", "-o", "vg_name", "--noheadings", NULL);
+ "lvm", "vgs", "-o", "vg_name", "--noheadings", NULL);
if (r == -1) {
reply_with_error ("%s", err);
free (out);
@@ -235,7 +233,7 @@ test_lvs_has_S_opt (void)
CLEANUP_FREE char *out = NULL;
CLEANUP_FREE char *err = NULL;
- int r = command (&out, &err, str_lvm, "lvs", "--help", NULL);
+ int r = command (&out, &err, "lvm", "lvs", "--help", NULL);
if (r == -1) {
reply...
2017 Jul 24
0
[PATCH 2/2] daemon: Replace GUESTFSD_EXT_CMD with --print-external-commands.
...gs", "-o", "vg_name", "--noheadings", NULL);
+ "lvm", "vgs", "-o", "vg_name", "--noheadings", NULL);
if (r == -1) {
reply_with_error ("%s", err);
free (out);
@@ -235,7 +235,7 @@ test_lvs_has_S_opt (void)
CLEANUP_FREE char *out = NULL;
CLEANUP_FREE char *err = NULL;
- int r = command (&out, &err, str_lvm, "lvs", "--help", NULL);
+ int r = command (&out, &err, "lvm", "lvs", "--help", NULL);
if (r == -1) {
reply...
2017 Jun 05
19
[PATCH v3 00/19] Allow APIs to be implemented in OCaml.
v2 was here:
https://www.redhat.com/archives/libguestfs/2017-June/msg00008.html
This series gets as far as a working (and faster) reimplementation of
‘guestfs_list_filesystems’.
I also have another patch series on top of this one which reimplements
the inspection APIs inside the daemon, but that needs a bit more work
still, since inspection turns out to be a very large piece of code.
Rich.
2017 Jul 27
23
[PATCH v3 00/23] Reimplement many daemon APIs in OCaml.
I think this fixes everything mentioned:
- Added the Optgroups module as suggested.
- Remove command temporary files.
- Replace command ~flags with ?fold_stdout_on_stderr.
- Nest _with_mounted function.
- Rebase & retest.
Rich.
2017 Jul 21
27
[PATCH v2 00/23] Reimplement many daemon APIs in OCaml.
v1 was posted here:
https://www.redhat.com/archives/libguestfs/2017-July/msg00098.html
This series now depends on two small patches which I posted separately:
https://www.redhat.com/archives/libguestfs/2017-July/msg00207.html
https://www.redhat.com/archives/libguestfs/2017-July/msg00209.html
v1 -> v2:
- Previously changes to generator/daemon.ml were made incrementally
through the patch
2017 Jul 14
45
[PATCH 00/27] Reimplement many daemon APIs in OCaml.
Previously posted as part of the mega utilities/inspection
series here:
https://www.redhat.com/archives/libguestfs/2017-June/msg00232.html
What I've done is to extract just the parts related to rewriting
daemon APIs in OCaml, rebase them on top of the current master, fix a
few things, and recompile and test everything.
Rich.
2017 Jul 27
3
[PATCH v2] daemon: Remove GUESTFSD_EXT_CMD.
This is a simpler patch that removes GUESTFSD_EXT_CMD completely.
2017 Jul 24
6
[PATCH 0/2] daemon: Replace GUESTFSD_EXT_CMD with --print-external-commands.
Replace GUESTFSD_EXT_CMD with a command line option
‘./guestfsd --print-external-commands’
2017 Jun 12
32
[PATCH v5 00/32] Refactor utilities, implement some APIs in OCaml.
This is a combination of:
https://www.redhat.com/archives/libguestfs/2017-June/msg00046.html
[PATCH 00/12] Refactor utility functions.
plus:
https://www.redhat.com/archives/libguestfs/2017-June/msg00023.html
[PATCH v3 00/19] Allow APIs to be implemented in OCaml.
with the second patches rebased on top of the utility refactoring, and
some other adjustments and extensions.
This passes
2017 Jun 19
29
[PATCH v7 00/29] Reimplement inspection in the daemon.
v6 was posted here:
https://www.redhat.com/archives/libguestfs/2017-June/msg00103.html
and this requires the utilities refactoring posted here:
https://www.redhat.com/archives/libguestfs/2017-June/msg00169.html
Inspection is now complete[*], although not very well tested. I'm
intending to compare the output of many guests using old & new
virt-inspector to see if I can find any
2017 Jun 15
45
[PATCH v6 00/41] Refactor utilities, reimplement inspection in the daemon.
v5:
https://www.redhat.com/archives/libguestfs/2017-June/msg00065.html
Since v5, this now implements inspection almost completely for Linux
and Windows guests.
Rich.
2017 Jun 21
45
[PATCH v8 00/42] Refactor utilities and reimplement inspection.
v7 was:
https://www.redhat.com/archives/libguestfs/2017-June/msg00169.html
https://www.redhat.com/archives/libguestfs/2017-June/msg00184.html
I believe this addresses all comments received so far.
Also it now passes a test where I compared about 100 disk images
processed with old and new virt-inspector binaries. The output is
identical in all cases except one which is caused by a bug in blkid