search for: string_set

...i = j; + break; + } + } + } + if ( i < 0 ) { + i = cth.num_open; + cth.biggest_in_use = i; + } + } + + + conn->cnum = i; + cth.Connections[i] = conn; + cth.num_open++; + + string_set(&conn->user,""); + string_set(&conn->dirpath,""); + string_set(&conn->connectpath,""); + string_set(&conn->origpath,""); + - ZERO_STRUCTP(conn); - conn->cnum = i; - - bitmap_set(bmap, i); - - num_open++; - - strin...

I compiled and tried rsync 2.5.0 but could not get the server running. loadparm.c:string_set() now calls free() which it did not do in 2.4.6 and this free() tries to free memory that was not allocated with malloc. Here is a gdb run (done after adding return before fork() in become_daemon) which shows where it crashes and what my minimal config file for demonstrating the bug was. The confi...

...> handle_netbios_name -- validate and insert a single netbios-name > parameter. It's a ugstring global, with the DOS_STRING attribute. 2124,2129c2128,2147 < static BOOL handle_netbios_name(char *pszParmValue,char **ptr) < { < /* initially, prove that it works --davecb */ < string_set(ptr,pszParmValue); < add_char_string(pszParmValue); < return(True); --- > static BOOL handle_netbios_name(char *pszParmValue, char **parm_ptr) { > pstring netbios_name; > > if (validate_netbios_name(pszParmValue) == False) > return False; > > pstrcpy(netbi...

I can't create new folder in a czech Win95 explorer on a unix using samba 1.9.18p7. The problem is that Windows exporer uses for the creation new folder a name containing characters above 128. The explorer creates new folder in a two phases: the first It creates directory named Nov<A0> slo<A7>zka and next it gives to user posibility to change this name. Crazy !!? The first phase

...dparm-2.2.3a.c Tue Jul 9 13:50:53 2002 +++ samba-2.2.3a/source/param/loadparm.c Tue Jul 9 13:52:40 2002 @@ -2454,10 +2454,10 @@ pstring fname; pstrcpy(fname, pszParmValue); - add_to_file_list(pszParmValue, fname); - standard_sub_basic(fname); + add_to_file_list(pszParmValue, fname); + string_set(ptr, fname); if (file_exist(fname, NULL)) -- ______ jonathan@cs.keele.ac.uk Jonathan Knight, / Department of Computer Science / _ __ Telephone: +44 1782 583437 University of Keele, Keele, (_/ (_) / / Fax : +44 1782 713082 Staffordshire....

...********************************************************* diff -ur samba-2.0.7/source/param/loadparm.c samba-2.0.7viv/source/param/loadparm.c --- samba-2.0.7/source/param/loadparm.c Wed Apr 26 02:07:00 2000 +++ samba-2.0.7viv/source/param/loadparm.c Wed Mar 21 14:04:55 2001 @@ -1581,6 +1581,7 @@ string_set(&iSERVICE(i).szPath,tmpdir()); string_set(&iSERVICE(i).szUsername,""); string_set(&iSERVICE(i).comment,comment); + unix_to_dos(iSERVICE(i).comment,True); string_set(&iSERVICE(i).fstype,"IPC"); iSERVICE(i).status = False; iSERVICE(i).iMaxConnection...

...uld be nice - * to have either all-strdup'd values, or to never need to free - * memory. + * Assign a copy of @p v to @p *s, freeing any existing values and + * handling NULL strings. @p *v must be initialized when this is + * called, either to NULL or a malloc'd string. **/ static void string_set(char **s, const char *v) { @@ -403,6 +420,8 @@ *s = NULL; return; } + if (*s) + free(*s); *s = strdup(v); if (!*s) exit_cleanup(RERR_MALLOC);

...ry group", P_INTEGER, P_GLOBAL, = &Globals.winbind_primary_group, NULL, NULL, 0},=0A= + {"winbind force primary", P_BOOL, P_GLOBAL, = &Globals.bWinbindForcePrimary, NULL, NULL, 0},=0A= =0A= {NULL, P_BOOL, P_NONE, NULL, NULL, NULL, 0}=0A= };=0A= @@ -1427,6 +1431,8 @@=0A= string_set(&Globals.szTemplateHomedir, "/home/%D/%U");=0A= string_set(&Globals.szWinbindSeparator, "\\");=0A= Globals.winbind_cache_time =3D 15;=0A= + Globals.winbind_primary_group =3D 0; /* use primary group from = domain */=0A= + Globals.bWinbindForcePrimary =3D False; /* Tr...

Attached please find unified diffs against Samba 2.0.6. I'm hoping that others will find it useful and that it may even find its way into Samba 2.0.7 This patch does two things: - Modifies the handling of the 'netbios name' parameter so that standard_sub_basic() is run on its value when the 'netbios name' parameter is processed. This has to be done this way because

Hi all, I've installed samba-3.0.21rc2 on a solaris 10 machine (latest patches applied) by compiling from source: #uname -a SunOS newton 5.10 Generic_118844-20 i86pc i386 i86pc User's home is mounted using automount without any problem. But when I try to mount using samba, it can not access the users home directory when it 's share is not mounted and gives following error:

...clientcert", P_BOOL, P_GLOBAL, &Globals.sslReqClientCert, NULL, NULL, 0}, {"ssl require servercert", P_BOOL, P_GLOBAL, &Globals.sslReqServerCert, NULL, NULL, 0}, {"ssl ciphers", P_STRING, P_GLOBAL, &Globals.sslCiphers, NULL, NULL, 0}, @@ -1297,6 +1303,9 @@ string_set(&Globals.sslClientCert, ""); string_set(&Globals.sslClientPrivKey, ""); string_set(&Globals.sslCiphers, ""); + string_set(&Globals.sslEgdSocket, ""); + string_set(&Globals.sslEntropyFile, ""); + Globals.sslEntropyBytes = 256;...

.../* it might already exist */ if (name) { - i = getservicebyname(name,NULL); + i = getservicebyname(name2,NULL); if (i >= 0) return(i); } @@ -1538,7 +1547,7 @@ init_service(pSERVICE(i)); copy_service(pSERVICE(i),&tservice,NULL); if (name) { - string_set(&iSERVICE(i).szService,name); + string_set(&iSERVICE(i).szService,name2); unix_to_dos(iSERVICE(i).szService, True); } return(i); ---- Cut Here ---- We have not examined under Samba 2.2.0 yet. ---- Cut Here ---- For 2.2.0 ---- --- param/loadparm.c.org Tue Jun 12 01:38:17...

...nip] Seems the patch got cut by the list server. Here it is again. tony *** ../samba-2.0.7/source.Linux/param/loadparm.c Fri Nov 17 09:24:27 2000 --- ./param/loadparm.c Sat Nov 18 00:46:50 2000 *************** *** 2711,2716 **** --- 2711,2718 ---- if ((i=lp_servicenumber(name)) >= 0) string_set(&iSERVICE(i).comment,comment); } + /* free up temporary memory */ + lp_talloc_free(); } /*************************************************************************** *** ../samba-2.0.7/source.Linux/smbd/server.c Thu Mar 16 17:59:52 2000 --- ./smbd/server.c Fri Nov 17 22:58:15 2000 **...