Displaying 12 results from an estimated 12 matches for "sejooh".
2018 Apr 30
1
[SelectionDAG] DbgValue nodes aren't transferred
> On Apr 30, 2018, at 3:16 PM, Se Jong Oh <sejooh at microsoft.com> wrote:
>
> For cast instructions, llvm::salvageDebugInfo() simply makes dbg.value point to the source of the cast. Since SelectionDAG already has transferDbgValues which can move dbgvalue to the cast source, I think that we can just call it where the truncate is optimize...
2018 Apr 30
2
[SelectionDAG] DbgValue nodes aren't transferred
> On Apr 30, 2018, at 2:57 PM, Se Jong Oh <sejooh at microsoft.com> wrote:
>
> Thanks! It looks like SelectionDAG::salvageDebugInfo handles only addition with constant.
You can look at llvm::salvageDebugInfo() for examples on how to handle other situations.
-- adrian
-------------- next part --------------
An HTML attachment was scrub...
2018 Apr 30
0
[SelectionDAG] DbgValue nodes aren't transferred
...cast. Since SelectionDAG already has transferDbgValues which can move dbgvalue to the cast source, I think that we can just call it where the truncate is optimized away.
Thanks,
Sejong
From: aprantl at apple.com <aprantl at apple.com>
Sent: Monday, April 30, 2018 2:59 PM
To: Se Jong Oh <sejooh at microsoft.com>
Cc: jdevlieghere at apple.com; Vedant Kumar <vsk at apple.com>; llvm-dev at lists.llvm.org; pidgeot18 at gmail.com
Subject: Re: [llvm-dev] [SelectionDAG] DbgValue nodes aren't transferred
On Apr 30, 2018, at 2:57 PM, Se Jong Oh <sejooh at microsoft.com<mailt...
2018 Apr 30
0
[SelectionDAG] DbgValue nodes aren't transferred
Thanks! It looks like SelectionDAG::salvageDebugInfo handles only addition with constant.
Sejong
From: aprantl at apple.com <aprantl at apple.com>
Sent: Monday, April 30, 2018 1:53 PM
To: Se Jong Oh <sejooh at microsoft.com>
Cc: jdevlieghere at apple.com; Vedant Kumar <vsk at apple.com>; llvm-dev at lists.llvm.org; pidgeot18 at gmail.com
Subject: Re: [llvm-dev] [SelectionDAG] DbgValue nodes aren't transferred
On Apr 30, 2018, at 1:49 PM, Se Jong Oh <sejooh at microsoft.com<mailt...
2018 Apr 30
2
[SelectionDAG] DbgValue nodes aren't transferred
> On Apr 30, 2018, at 1:49 PM, Se Jong Oh <sejooh at microsoft.com> wrote:
>
> Hi Jonas,
>
> I have another case that DBG_VALUE is not produced. I would appreciate it if you could take a quick look at the testcase below.
>
>
> test code:
>
> llc -mtriple=aarch64 -stop-after=livedebugvalues -o - test.ll
>
>...
2018 Mar 14
2
[SelectionDAG] DbgValue nodes aren't transferred
...rrectly. I also tried a simple function with few operations and confirmed DEBUG_VALUEs which are not produced without trasferDbgValues in SetPromotedInteger.
Thanks,
Sejong
From: jdevlieghere at apple.com <jdevlieghere at apple.com>
Sent: Wednesday, March 14, 2018 4:07 AM
To: Se Jong Oh <sejooh at microsoft.com>
Cc: Vedant Kumar <vsk at apple.com>; llvm-dev at lists.llvm.org; Adrian Prantl <aprantl at apple.com>; pidgeot18 at gmail.com
Subject: Re: [llvm-dev] [SelectionDAG] DbgValue nodes aren't transferred
Hi Sejong,
Indeed, I think you are right and we should call t...
2018 Mar 15
1
[SelectionDAG] DbgValue nodes aren't transferred
> On Mar 14, 2018, at 7:55 PM, Se Jong Oh <sejooh at microsoft.com> wrote:
>
> Hi Jonas,
>
> Thanks for taking a look! It makes linear-dbg-value.ll pass for my target by producing DEBUG_VALUEs correctly. I also tried a simple function with few operations and confirmed DEBUG_VALUEs which are not produced without trasferDbgValues i...
2018 Apr 30
0
[SelectionDAG] DbgValue nodes aren't transferred
...(line: 5, column: 7, scope: !4)
!18 = !DILocation(line: 6, column: 3, scope: !4)
!19 = !DILocation(line: 7, column: 1, scope: !4)
Thanks,
Sejong
-----Original Message-----
From: jdevlieghere at apple.com <jdevlieghere at apple.com>
Sent: Thursday, March 15, 2018 8:43 AM
To: Se Jong Oh <sejooh at microsoft.com>
Cc: Vedant Kumar <vsk at apple.com>; llvm-dev at lists.llvm.org; Adrian Prantl <aprantl at apple.com>; pidgeot18 at gmail.com
Subject: Re: [llvm-dev] [SelectionDAG] DbgValue nodes aren't transferred
> On Mar 14, 2018, at 7:55 PM, Se Jong Oh <sejooh at m...
2018 Mar 14
0
[SelectionDAG] DbgValue nodes aren't transferred
...,
Indeed, I think you are right and we should call transferDbgValues in SetPromotedInteger.
I couldn’t immediately find a suitable in-tree test to verify this though. Can you check and let me know whether this works for your target?
Thanks,
Jonas
> On Mar 13, 2018, at 7:45 PM, Se Jong Oh <sejooh at microsoft.com> wrote:
>
> Thanks for help! I think that sign extension is not involved here. PromoteIntegerResult is called since i32 is not a legal type in my target and the legalizer promotes operations with i32 result type to i64 operations. I think that SetPromotedInteger seems to...
2018 Mar 13
2
[SelectionDAG] DbgValue nodes aren't transferred
...nteger seems to be a common place for all promotions like SetExpandedInteger.
Jonas, I would appreciate it if you can guide me about whether my understanding is correct or not.
Thanks,
Sejong
From: vsk at apple.com <vsk at apple.com>
Sent: Friday, March 9, 2018 3:19 PM
To: Se Jong Oh <sejooh at microsoft.com>
Cc: llvm-dev at lists.llvm.org; Jonas Devlieghere <jdevlieghere at apple.com>; Adrian Prantl <aprantl at apple.com>; pidgeot18 at gmail.com
Subject: Re: [llvm-dev] [SelectionDAG] DbgValue nodes aren't transferred
+ Adrian, Joshua
+ Jonas, since he contributed t...
2018 Mar 09
0
[SelectionDAG] DbgValue nodes aren't transferred
+ Adrian, Joshua
+ Jonas, since he contributed the transferDbgValues change in DAGTypeLegalizer::SetExpandedInteger
> On Mar 8, 2018, at 5:44 PM, Se Jong Oh via llvm-dev <llvm-dev at lists.llvm.org> wrote:
>
> Hi,
>
> I have a problem that dbg_value nodes are not transferred when integer DAG nodes are promoted. For example, an i32 add node is promoted to a i64 add node by
2018 Mar 09
2
[SelectionDAG] DbgValue nodes aren't transferred
Hi,
I have a problem that dbg_value nodes are not transferred when integer DAG nodes are promoted. For example, an i32 add node is promoted to a i64 add node by DAGTypeLegalizer::PromoteIntegerResult and its dbg_value node is not transferred to the new node.
t9: i32 = add nsw t5, t8 --> t31: i64 = add t30, t7 ; the dbg_value node is not transferred to the new i64 add node.
For expansion,