Displaying 20 results from an estimated 25 matches for "rhv_verifyp".
2020 Jan 15
3
[PATCH v2v] v2v: -o rhv-upload: Make -oo rhv-cafile optional in all cases (RHBZ#1791240).
...;-oo rhv-cluster=>C<CLUSTERNAME>
diff --git a/v2v/output_rhv_upload.ml b/v2v/output_rhv_upload.ml
index 7b5ad7a86..14153db36 100644
--- a/v2v/output_rhv_upload.ml
+++ b/v2v/output_rhv_upload.ml
@@ -81,8 +81,6 @@ let parse_output_options options =
let rhv_direct = !rhv_direct in
let rhv_verifypeer = !rhv_verifypeer in
let rhv_disk_uuids = Option.map List.rev !rhv_disk_uuids in
- if rhv_verifypeer && rhv_cafile = None then
- error (f_"-o rhv-upload: must use ‘-oo rhv-cafile’ to supply the path to the oVirt or RHV user’s ‘ca.pem’ file");
{ rhv_cafile; rhv_clus...
2019 Sep 27
1
[PATCH] v2v: -o rhv-upload: make -oo rhv-cafile optional
...b/v2v/output_rhv_upload.ml
index 24a289169..d08502826 100644
--- a/v2v/output_rhv_upload.ml
+++ b/v2v/output_rhv_upload.ml
@@ -28,7 +28,7 @@ open Types
open Utils
type rhv_options = {
- rhv_cafile : string;
+ rhv_cafile : string option;
rhv_cluster : string option;
rhv_direct : bool;
rhv_verifypeer : bool;
@@ -76,15 +76,13 @@ let parse_output_options options =
error (f_"-o rhv-upload: unknown output option ‘-oo %s’") k
) options;
- let rhv_cafile =
- match !rhv_cafile with
- | Some s -> s
- | None ->
- error (f_"-o rhv-upload: must use ‘-oo...
2019 Sep 19
2
[PATCH] v2v: -o rhv-upload: add -oo rhv-disk-uuid option
...changed, 63 insertions(+), 5 deletions(-)
diff --git a/v2v/output_rhv_upload.ml b/v2v/output_rhv_upload.ml
index 40902c371..eec9c5c79 100644
--- a/v2v/output_rhv_upload.ml
+++ b/v2v/output_rhv_upload.ml
@@ -32,6 +32,7 @@ type rhv_options = {
rhv_cluster : string option;
rhv_direct : bool;
rhv_verifypeer : bool;
+ rhv_disk_uuids : string list option;
}
let print_output_options () =
@@ -41,6 +42,11 @@ let print_output_options () =
-oo rhv-cluster=CLUSTERNAME Set RHV cluster name.
-oo rhv-direct[=true|false] Use direct transfer mode (default: false).
-oo rhv-verifypeer[=true|...
2020 Jan 16
0
Re: [PATCH v2v] v2v: -o rhv-upload: Make -oo rhv-cafile optional in all cases (RHBZ#1791240).
...gt;
>
> diff --git a/v2v/output_rhv_upload.ml b/v2v/output_rhv_upload.ml
> index 7b5ad7a86..14153db36 100644
> --- a/v2v/output_rhv_upload.ml
> +++ b/v2v/output_rhv_upload.ml
> @@ -81,8 +81,6 @@ let parse_output_options options =
> let rhv_direct = !rhv_direct in
> let rhv_verifypeer = !rhv_verifypeer in
> let rhv_disk_uuids = Option.map List.rev !rhv_disk_uuids in
> - if rhv_verifypeer && rhv_cafile = None then
> - error (f_"-o rhv-upload: must use ‘-oo rhv-cafile’ to supply the
> path to the oVirt or RHV user’s ‘ca.pem’ file");
>
&g...
2020 Jan 29
1
Re: [PATCH v2v v2 1/2] rhv-upload: Validate UUIDs passed to -oo rhv-disk-uuid (RHBZ#1789279)
...uuid = nil_uuid then false
>+ else PCRE.matches rex_uuid uuid
>+
> let parse_output_options options =
> let rhv_cafile = ref None in
> let rhv_cluster = ref None in
>@@ -71,6 +81,8 @@ let parse_output_options options =
> | "rhv-verifypeer", "" -> rhv_verifypeer := true
> | "rhv-verifypeer", v -> rhv_verifypeer := bool_of_string v
> | "rhv-disk-uuid", v ->
>+ if not (is_nonnil_uuid v) then
>+ error (f_"-o rhv-upload: invalid UUID for -oo rhv-disk-uuid");
> rhv_disk_uuids :=...
2020 Jan 29
4
[PATCH v2v v2 0/2] rhv-upload: Validate UUIDs and check they don't exist already
My stab v2 at fixing this: https://bugzilla.redhat.com/show_bug.cgi?id=1789279
It took me quite some time to go through the whole rfc 4122 just to realize we
do not need to do anything with the versions.
v2:
- Use EEXIST instead of EINVAL
- Put the colliding UUID into the error
- Do not evaluate the PCRE needlessly multiple times
v1:
2018 Dec 13
3
[PATCH] v2v: -o rhv-upload: decouple name of nbdkit python plugin
...changed, 4 insertions(+), 3 deletions(-)
diff --git a/v2v/output_rhv_upload.ml b/v2v/output_rhv_upload.ml
index f5e0e6b1c..d8f608cff 100644
--- a/v2v/output_rhv_upload.ml
+++ b/v2v/output_rhv_upload.ml
@@ -78,6 +78,7 @@ let parse_output_options options =
{ rhv_cafile; rhv_cluster; rhv_direct; rhv_verifypeer }
+let nbdkit_python_plugin = "python"
let pidfile_timeout = 30
let finalization_timeout = 5*60
@@ -139,14 +140,14 @@ class output_rhv_upload output_alloc output_conn
*)
let error_unless_nbdkit_python_plugin_working () =
let cmd = sprintf "nbdkit %s %s --dump-plu...
2020 Mar 11
4
[PATCH v2v v3 0/2] rhv-upload: Validate UUIDs and check they don't exist already
My stab v3 at fixing this: https://bugzilla.redhat.com/show_bug.cgi?id=1789279
It took me quite some time to go through the whole rfc 4122 just to realize we
do not need to do anything with the versions.
v3:
- Do the check in precheck
- Fix for Lazy evaluation of regexp UUID
v2:
- https://www.redhat.com/archives/libguestfs/2020-January/msg00221.html
- Use EEXIST instead of EINVAL
- Put the
2020 Jan 23
0
[v2v PATCH 1/2] rhv-upload: Validate UUIDs passed to -oo rhv-disk-uuid (RHBZ#1789279)
...E.compile rex_uuid in
+ if uuid = nil_uuid then false
+ else PCRE.matches rex_uuid uuid
+
let parse_output_options options =
let rhv_cafile = ref None in
let rhv_cluster = ref None in
@@ -71,6 +79,8 @@ let parse_output_options options =
| "rhv-verifypeer", "" -> rhv_verifypeer := true
| "rhv-verifypeer", v -> rhv_verifypeer := bool_of_string v
| "rhv-disk-uuid", v ->
+ if not (is_nonnil_uuid v) then
+ error (f_"-o rhv-upload: invalid UUID for -oo rhv-disk-uuid");
rhv_disk_uuids := Some (v :: (Option.d...
2020 Jan 29
0
[PATCH v2v v2 1/2] rhv-upload: Validate UUIDs passed to -oo rhv-disk-uuid (RHBZ#1789279)
...E.compile str
+ ) in
+ if uuid = nil_uuid then false
+ else PCRE.matches rex_uuid uuid
+
let parse_output_options options =
let rhv_cafile = ref None in
let rhv_cluster = ref None in
@@ -71,6 +81,8 @@ let parse_output_options options =
| "rhv-verifypeer", "" -> rhv_verifypeer := true
| "rhv-verifypeer", v -> rhv_verifypeer := bool_of_string v
| "rhv-disk-uuid", v ->
+ if not (is_nonnil_uuid v) then
+ error (f_"-o rhv-upload: invalid UUID for -oo rhv-disk-uuid");
rhv_disk_uuids := Some (v :: (Option.d...
2020 Mar 11
0
[PATCH v2v v3 1/2] rhv-upload: Validate UUIDs passed to -oo rhv-disk-uuid (RHBZ#1789279)
...+ ) in
+ if uuid = nil_uuid then false
+ else PCRE.matches (Lazy.force rex_uuid) uuid
+
let parse_output_options options =
let rhv_cafile = ref None in
let rhv_cluster = ref None in
@@ -71,6 +81,8 @@ let parse_output_options options =
| "rhv-verifypeer", "" -> rhv_verifypeer := true
| "rhv-verifypeer", v -> rhv_verifypeer := bool_of_string v
| "rhv-disk-uuid", v ->
+ if not (is_nonnil_uuid v) then
+ error (f_"-o rhv-upload: invalid UUID for -oo rhv-disk-uuid");
rhv_disk_uuids := Some (v :: (Option.d...
2018 Mar 21
2
[PATCH v6] v2v: Add -o rhv-upload output mode.
v5 was here:
https://www.redhat.com/archives/libguestfs/2018-March/msg00032.html
There is only a single patch in this version because the other
patches went upstream.
This patch adds the virt-v2v -o rhv-upload mode
(https://bugzilla.redhat.com/show_bug.cgi?id=1557273).
Compared to v5, this adds the ability to make zero, trim and flush
requests to the oVirt imageio server
2018 Mar 21
0
[PATCH v6] v2v: Add -o rhv-upload output mode.
...44
--- a/v2v/cmdline.ml
+++ b/v2v/cmdline.ml
@@ -67,6 +67,10 @@ let parse_cmdline () =
let output_password = ref None in
let output_storage = ref None in
let password_file = ref None in
+ let rhv_cafile = ref None in
+ let rhv_cluster = ref None in
+ let rhv_direct = ref false in
+ let rhv_verifypeer = ref false in
let vddk_config = ref None in
let vddk_cookie = ref None in
let vddk_libdir = ref None in
@@ -145,6 +149,8 @@ let parse_cmdline () =
| "disk" | "local" -> output_mode := `Local
| "null" -> output_mode := `Null
| "ovi...
2020 Jan 23
5
[v2v PATCH 0/2] rhv-upload: Validate UUIDs and check they don't exist already
My stab at fixing this: https://bugzilla.redhat.com/show_bug.cgi?id=1789279
It took me quite some time to go through the whole rfc 4122 just to realize we
do not need to do anything with the versions.
Martin Kletzander (2):
rhv-upload: Validate UUIDs passed to -oo rhv-disk-uuid (RHBZ#1789279)
rhv-upload: Check that rhv-disk-uuid is not already taken
(RHBZ#1789279)
2018 Mar 22
0
[PATCH v7 6/6] v2v: Add -o rhv-upload output mode (RHBZ#1557273).
...ranklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
+ *)
+
+open Printf
+open Unix
+
+open Std_utils
+open Tools_utils
+open Unix_utils
+open Common_gettext.Gettext
+
+open Types
+open Utils
+
+type rhv_options = {
+ rhv_cafile : string;
+ rhv_cluster : string option;
+ rhv_direct : bool;
+ rhv_verifypeer : bool;
+}
+
+let print_rhv_output_options () =
+ printf (f_"Output options (-oo) which can be used with -o rhv-upload:
+
+ -oo rhv-cafile=CA.PEM Set ‘ca.pem’ certificate bundle filename.
+ -oo rhv-cluster=CLUSTERNAME Set RHV cluster name.
+ -oo rhv-direct[=true|false]...
2018 Apr 05
2
[PATCH v8] v2v: Add -o rhv-upload output mode (RHBZ#1557273).
v7 was here:
https://www.redhat.com/archives/libguestfs/2018-March/msg00143.html
Since then:
- Earlier patches are now upstream.
- The to-do list is moved from the commit message to the TODO file.
- This version forces -of raw + -oa sparse and gives an error in
any other mode. We intend to lift these restrictions later.
- Tested against latest imageio which supports longer timeouts,
2018 Apr 05
0
[PATCH v8] v2v: Add -o rhv-upload output mode (RHBZ#1557273).
...ranklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
+ *)
+
+open Printf
+open Unix
+
+open Std_utils
+open Tools_utils
+open Unix_utils
+open Common_gettext.Gettext
+
+open Types
+open Utils
+
+type rhv_options = {
+ rhv_cafile : string;
+ rhv_cluster : string option;
+ rhv_direct : bool;
+ rhv_verifypeer : bool;
+}
+
+let print_output_options () =
+ printf (f_"Output options (-oo) which can be used with -o rhv-upload:
+
+ -oo rhv-cafile=CA.PEM Set ‘ca.pem’ certificate bundle filename.
+ -oo rhv-cluster=CLUSTERNAME Set RHV cluster name.
+ -oo rhv-direct[=true|false] Use...
2018 Apr 10
0
[PATCH v9] v2v: Add -o rhv-upload output mode (RHBZ#1557273).
...ranklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
+ *)
+
+open Printf
+open Unix
+
+open Std_utils
+open Tools_utils
+open Unix_utils
+open Common_gettext.Gettext
+
+open Types
+open Utils
+
+type rhv_options = {
+ rhv_cafile : string;
+ rhv_cluster : string option;
+ rhv_direct : bool;
+ rhv_verifypeer : bool;
+}
+
+let print_output_options () =
+ printf (f_"Output options (-oo) which can be used with -o rhv-upload:
+
+ -oo rhv-cafile=CA.PEM Set ‘ca.pem’ certificate bundle filename.
+ -oo rhv-cluster=CLUSTERNAME Set RHV cluster name.
+ -oo rhv-direct[=true|false] Use...
2018 Apr 10
2
[PATCH v9] v2v: Add -o rhv-upload output mode (RHBZ#1557273).
v8 was here:
https://www.redhat.com/archives/libguestfs/2018-April/msg00022.html
v8 -> v9:
- Addresses the only feedback from Tomáš.
Rich.
2019 Jan 07
0
Re: [PATCH] v2v: -o rhv-upload: decouple name of nbdkit python plugin
...oes break "out of the box" -o
rhv-upload. It means that to get it to work on Fedora we _have_ to
patch:
> --- a/v2v/output_rhv_upload.ml
> +++ b/v2v/output_rhv_upload.ml
> @@ -78,6 +78,7 @@ let parse_output_options options =
>
> { rhv_cafile; rhv_cluster; rhv_direct; rhv_verifypeer }
>
> +let nbdkit_python_plugin = "python"
to change this "python3" [1].
I would dearly love to drop Python 2 support everywhere, but I don't
think we can do that realisticly before the Python 2 EOL
(https://pythonclock.org/) which is another 12 months away.
I...