search for: rhbz790721

These two patches make appliance building thread-safe. The first adds a test which easily demonstrates the problem. The second fixes the issue. For more information see Ian McLeod's analysis of the bug here: https://bugzilla.redhat.com/show_bug.cgi?id=790528#c5 Rich.

...ta/guestfs-hashsums.sh | 43 +++++++++++++++++++++++++++++++++++ tests/qemu/Makefile.am | 1 - tests/qemu/guestfs-md5.sh | 30 ------------------------ tests/qemu/qemu-liveness.sh | 2 +- tests/qemu/qemu-snapshot-isolation.sh | 2 +- tests/regressions/rhbz790721.c | 2 +- v2v/test-v2v-i-ova-formats.sh | 4 +++- v2v/test-v2v-i-ova-gz.sh | 4 +++- v2v/test-v2v-i-ova-two-disks.sh | 6 +++-- v2v/test-v2v-i-ova.sh | 6 +++-- v2v/test-v2v-in-place.sh | 6 +++-- 18 files changed, 87 insertions(+...

...th-callbacks.c | 2 +- tests/mount-local/test-parallel-mount-local.c | 2 +- tests/parallel/test-parallel.c | 2 +- tests/regressions/rhbz1055452.c | 2 +- tests/regressions/rhbz501893.c | 2 +- tests/regressions/rhbz790721.c | 2 +- tests/regressions/rhbz914931.c | 2 +- tests/regressions/test-big-heap.c | 2 +- utils/boot-analysis/boot-analysis-timeline.c | 2 +- utils/boot-analysis/boot-analysis-utils.c | 2 +- utils/boot-analysi...

...tests/mount-local/test-parallel-mount-local.c | 2 +- tests/parallel/test-parallel.c | 2 +- tests/regressions/rhbz1055452.c | 2 +- tests/regressions/rhbz501893.c | 2 +- tests/regressions/rhbz790721.c | 2 +- tests/regressions/rhbz914931.c | 2 +- tests/regressions/test-big-heap.c | 2 +- utils/boot-analysis/boot-analysis-timeline.c | 2 +- utils/boot-analysis/boot-analysis-utils.c...

...dle.c | 11 +++---- tests/charsets/test-charset-fidelity.c | 4 ++- tests/mount-local/test-parallel-mount-local.c | 5 ++-- tests/parallel/test-parallel.c | 5 ++-- tests/regressions/Makefile.am | 8 ++++-- tests/regressions/rhbz790721.c | 4 ++- tests/regressions/rhbz914931.c | 4 ++- utils/boot-analysis/boot-analysis.c | 6 ++-- utils/boot-benchmark/boot-benchmark.c | 8 ++++-- utils/qemu-boot/qemu-boot.c | 10 ++++--- utils/qemu-speed-test/qemu-speed-test.c...

I've been taking a long hard look at the protocol layer. It has evolved over a long time without any particular direction, and the result is, to say the least, not very organized. These patches take a first step at cleaning up the mess by abstracting out socket operations from the rest of the code. The purpose of this is to allow us to slot in a different connection layer under the

...ndex 74f23dd..c4f60ae 100644 --- a/tests/regressions/Makefile.am +++ b/tests/regressions/Makefile.am @@ -71,6 +71,7 @@ TESTS = \ rhbz1091803.sh \ rhbz1175196.sh \ rhbz1232192.sh \ + test-big-heap \ test-noexec-stack.pl if HAVE_LIBVIRT @@ -89,7 +90,8 @@ check_PROGRAMS = \ rhbz501893 \ rhbz790721 \ rhbz914931 \ - rhbz1055452 + rhbz1055452 \ + test-big-heap rhbz501893_SOURCES = rhbz501893.c rhbz501893_CPPFLAGS = \ @@ -130,5 +132,14 @@ rhbz1055452_CFLAGS = \ rhbz1055452_LDADD = \ $(top_builddir)/src/libguestfs.la +test_big_heap_SOURCES = test-big-heap.c +test_big_heap_CPPFLAGS = \...

...12 ++++++- 4 files changed, 11 insertions(+), 92 deletions(-) delete mode 100644 tests/regressions/rhbz1044014.c diff --git a/.gitignore b/.gitignore index f84e2cd..74661b0 100644 --- a/.gitignore +++ b/.gitignore @@ -492,7 +492,6 @@ Makefile.in /tests/regressions/rhbz501893 /tests/regressions/rhbz790721 /tests/regressions/rhbz914931 -/tests/regressions/rhbz1044014 /tests/regressions/rhbz1044014.out /tests/regressions/rhbz1055452 /tests/rsync/rsyncd.pid diff --git a/tests/regressions/Makefile.am b/tests/regressions/Makefile.am index d45a76c..8016e2f 100644 --- a/tests/regressions/Makefile.am ++...

...c > tests/c-api/test-just-header.c > tests/c-api/test-last-errno.c > tests/c-api/test-private-data.c > tests/c-api/test-user-cancel.c > tests/charsets/test-charset-fidelity.c > tests/mount-local/test-parallel-mount-local.c > tests/regressions/rhbz501893.c > tests/regressions/rhbz790721.c > maint.mk: the above files do not call bindtextdomain > make: *** [sc_bindtextdomain] Error 1 I think for examples, tests and the rather special Erlang case, it's wrong to demand calls to bindtextdomain. The daemon is arguable, but we don't include any locale data in the applianc...

This is almost just refactoring, but I also set the memory limit to really 1 GB, and not 1×10⁹. --- src/info.c | 27 +++++++++++++++------------ 1 file changed, 15 insertions(+), 12 deletions(-) diff --git a/src/info.c b/src/info.c index d7f45f0..616ef50 100644 --- a/src/info.c +++ b/src/info.c @@ -56,6 +56,7 @@ static yajl_val get_json_output (guestfs_h *g, const char *filename); static char

Note: This is a regression in RHEL 6.3. Please review this patch urgently. The description of the bug is here: https://bugzilla.redhat.com/show_bug.cgi?id=812092 This patch set attempts to fix the problem conservatively, because it's a very high risk codepath and very late in the development of RHEL 6.3. The first patch reverts the behaviour of calling realpath(3) and checking for

...t-private-data.c | 8 +- tests/c-api/test-user-cancel.c | 42 ++++------ tests/c-api/tests-main.c | 32 +++----- tests/events/test-libvirt-auth-callbacks.c | 49 +++++------ tests/qemu/qemu-boot.c | 46 ++++------- tests/regressions/rhbz790721.c | 12 +-- 38 files changed, 457 insertions(+), 821 deletions(-) diff --git a/align/scan.c b/align/scan.c index 1185293..db6eb19 100644 --- a/align/scan.c +++ b/align/scan.c @@ -26,6 +26,7 @@ #include <unistd.h> #include <getopt.h> #include <errno.h> +#include &l...

...ble/test-internal-parse-mountable.c | 12 +- tests/protocol/test-error-messages.c | 7 +- tests/qemu/qemu-boot.c | 7 +- tests/qemu/qemu-speed-test.c | 37 ++---- tests/regressions/rhbz1055452.c | 14 +- tests/regressions/rhbz790721.c | 7 +- tests/regressions/rhbz914931.c | 7 +- 53 files changed, 587 insertions(+), 1009 deletions(-) diff --git a/builder/index-validate.c b/builder/index-validate.c index 9bc2e73..22e2ccd 100644 --- a/builder/index-validate.c +++ b/builder/index-validate.c...

An experimental series that adds support for rsync. Rich.

[PATCH 1/7] mount: Add mount_vfs_nochroot This is significantly reworked from before. umount is gone as discussed, and variable motion is minimised. [PATCH 2/7] btrfs: Update btrfs_subvolume_list to take Already provisionally ACKed. Previous comment was that cleanup could be tidier. I looked into creating a new cleanup function for fs_buf, but it isn't possible (or simple, anyway) in this

...3.c rhbz501893_CPPFLAGS = \ + -I$(top_srcdir)/common/utils -I$(top_builddir)/common/utils \ -I$(top_srcdir)/src -I$(top_builddir)/src rhbz501893_CFLAGS = \ $(WARN_CFLAGS) $(WERROR_CFLAGS) rhbz501893_LDADD = \ + $(top_builddir)/common/utils/libutils.la \ $(top_builddir)/src/libguestfs.la rhbz790721_SOURCES = rhbz790721.c rhbz790721_CPPFLAGS = \ -I$(top_srcdir)/gnulib/lib -I$(top_builddir)/gnulib/lib \ + -I$(top_srcdir)/common/utils -I$(top_builddir)/common/utils \ -I$(top_srcdir)/src -I$(top_builddir)/src rhbz790721_CFLAGS = \ -pthread \ $(WARN_CFLAGS) $(WERROR_CFLAGS) rhbz790721_L...

This converts more of the tests (basically everything under tests/) to use the test harness, revealing some problems which have subsequently been fixed. Rich.

This turned out to be rather more involved than I thought. We have lots of utility functions, spread all over the repository, with not a lot of structure. This moves many of them under common/ and structures them so there are clear dependencies. This doesn't complete the job by any means. Other items I had on my to-do list for this change were: - Split up mllib/common_utils into: -

libguestfs has used double and triple underscores in identifiers. These aren't valid for global names in C++. (http://stackoverflow.com/a/228797) These large but completely mechanical patches change the illegal identifiers to legal ones. Rich.

...on/utils -I$(top_builddir)/common/utils \ -I$(top_srcdir)/lib -I$(top_builddir)/lib rhbz501893_CFLAGS = \ $(WARN_CFLAGS) $(WERROR_CFLAGS) rhbz501893_LDADD = \ $(top_builddir)/common/utils/libutils.la \ + $(top_builddir)/common/cleanups/libcleanups.la \ $(top_builddir)/lib/libguestfs.la rhbz790721_SOURCES = rhbz790721.c rhbz790721_CPPFLAGS = \ -I$(top_srcdir)/gnulib/lib -I$(top_builddir)/gnulib/lib \ + -I$(top_srcdir)/common/cleanups -I$(top_builddir)/common/cleanups \ -I$(top_srcdir)/common/utils -I$(top_builddir)/common/utils \ -I$(top_srcdir)/lib -I$(top_builddir)/lib rhbz790721_C...