search for: parse_vmx

If you accidentally point -i vmx at a disk image, it will try to load the whole thing into memory and crash. Catch this narrow case and print an error. However don't fail if ‘file’ is not installed or if we don't know what the file is. --- v2v/parse_vmx.ml | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/v2v/parse_vmx.ml b/v2v/parse_vmx.ml index 65d5a0edd..f6c34e2cf 100644 --- a/v2v/parse_vmx.ml +++ b/v2v/parse_vmx.ml @@ -268,6 +268,18 @@ let remove_vmx_escapes str = (* Parsing. *) let rec parse_file vmx_filename = + (* One p...

https://bugzilla.redhat.com/show_bug.cgi?id=1441197

...-i vmx at a disk image, it will try to load > > the whole thing into memory and crash. Catch this narrow case and > > print an error. > > > > However don't fail if ‘file’ is not installed or if we don't know what > > the file is. > > --- > > v2v/parse_vmx.ml | 12 ++++++++++++ > > 1 file changed, 12 insertions(+) > > > > diff --git a/v2v/parse_vmx.ml b/v2v/parse_vmx.ml > > index 65d5a0edd..f6c34e2cf 100644 > > --- a/v2v/parse_vmx.ml > > +++ b/v2v/parse_vmx.ml > > @@ -268,6 +268,18 @@ let remove_vmx_escapes...

...ote: > If you accidentally point -i vmx at a disk image, it will try to load > the whole thing into memory and crash. Catch this narrow case and > print an error. > > However don't fail if ‘file’ is not installed or if we don't know what > the file is. > --- > v2v/parse_vmx.ml | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/v2v/parse_vmx.ml b/v2v/parse_vmx.ml > index 65d5a0edd..f6c34e2cf 100644 > --- a/v2v/parse_vmx.ml > +++ b/v2v/parse_vmx.ml > @@ -268,6 +268,18 @@ let remove_vmx_escapes str = > > (* Parsing. *) &...

...libvirtd doesn't pass the SSH_AUTH_SOCK environment variable to qemu you must set this environment variable:\n\nexport LIBGUESTFS_BACKEND=direct\n\nand then rerun the virt-v2v command."); + error_if_no_ssh_agent () method source () = - (* Parse the VMX file. *) - let vmx = Parse_vmx.parse_file vmx_filename in + let vmx_source = vmx_source_of_arg input_transport arg in + + (* If the transport is SSH, fetch the file from remote, else + * parse it from local. + *) + let vmx = + match vmx_source with + | File filename -> Parse_vmx.parse_file filename...

On Friday, 8 December 2017 17:02:30 CET Richard W.M. Jones wrote: > This enhances the existing VMX input support allowing it to be > used over SSH to the ESXi server. > > The original command (for local .vmx files) was: > > $ virt-v2v -i vmx guest.vmx -o local -os /var/tmp > > Adding ‘-it ssh’ and using an SSH remote path gives the new syntax: > > $ virt-v2v \

...545..a5caf906b 100644 --- a/v2v/input_vmx.ml +++ b/v2v/input_vmx.ml @@ -426,6 +426,27 @@ object | File filename -> name_from_disk filename | SSH uri -> name_from_disk (path_of_uri uri) in + let genid = + (* XXX NOT yet tested against VMware. *) + let genid = Parse_vmx.get_int64 vmx ["vm"; "genid"] + and genidX = Parse_vmx.get_int64 vmx ["vm"; "genidX"] in + match genid, genidX with + | None, None | Some _, None | None, Some _ -> None + | Some lo, Some hi -> + (* The actual mapping from the...

A colleague found some VMX files which omit the deviceType field. This allows -i vmx mode to parse them. Rich.

...vmx.ml > +++ b/v2v/input_vmx.ml > @@ -426,6 +426,27 @@ object > | File filename -> name_from_disk filename > | SSH uri -> name_from_disk (path_of_uri uri) in > > + let genid = > + (* XXX NOT yet tested against VMware. *) > + let genid = Parse_vmx.get_int64 vmx ["vm"; "genid"] > + and genidX = Parse_vmx.get_int64 vmx ["vm"; "genidX"] in > + match genid, genidX with > + | None, None | Some _, None | None, Some _ -> None > + | Some lo, Some hi -> > + (* Th...

The first patch was previously posted here: https://www.redhat.com/archives/libguestfs/2017-December/msg00018.html That patch hasn't changed except that I made the ‘input_transport’ variable type-safe. The second patch adds a significant new mode for liberating data from VMware: the ability to copy VMs over SSH directly from ESXi hypervisors. Although this requires enabling SSH access (a

v1 was here: https://www.redhat.com/archives/libguestfs/2017-September/msg00135.html This is a more complete evolution of the earlier patch. It replaces most important uses of Str with PCRE throughout the code. It also extends the bindings with some useful features like case-insensitive regexps. The main places I *didn't* touch are the generator (GObject uses Str extensively); and

v2 -> v3: - Renamed List.assoc_ -> List.assoc_lbl. - Rebased on top of current master branch. Rich.

...y = None; (* XXX *) diff --git a/v2v/input_vmx.ml b/v2v/input_vmx.ml index a8b33f66f..f79e89139 100644 --- a/v2v/input_vmx.ml +++ b/v2v/input_vmx.ml @@ -436,17 +436,18 @@ object | None -> 1 | Some i -> i in - let cpu_sockets, cpu_cores = + let cpu_topology = match Parse_vmx.get_int vmx ["cpuid"; "coresPerSocket"] with - | None -> None, None + | None -> None | Some cores_per_socket -> let sockets = vcpu / cores_per_socket in if sockets <= 0 then ( warning (f_"invalid cpuid.coresPerSoc...

v1: https://www.redhat.com/archives/libguestfs/2017-September/msg00135.html v2: https://www.redhat.com/archives/libguestfs/2017-September/msg00158.html v3 is almost identical to v2, but I have added 4 extra commits to almost finish the job of replacing Str everywhere possible (note it's not possible to replace Str in common/mlstdutils or the generator because those are pure OCaml). As

In Std_utils we already extend Char and String. These commits take it a little further by extending List and adding a new Option submodule. All basically simple refactoring. Rich.

Per my previous email: https://www.redhat.com/archives/libguestfs/2017-September/msg00203.html I'd like to talk about requiring a more modern version of the OCaml compiler. These commits show some of the code changes which would be possible with OCaml >= 3.12 [which it turns out we already require by accident] and also with OCaml >= 4.02. The latter is my favoured option. Rich.

This time including the first commit ...

v1 was here: https://www.redhat.com/archives/libguestfs/2017-October/msg00183.html v2: - Adds back the Debian test, but simplified. - Adds tests on Fedora & Debian. Rich.

Miscellaneous refactoring, but the main one is to rename mllib/ as common/mltools/ Rich.

...output_qemu.ml | 3 +- v2v/output_rhv.ml | 3 +- v2v/output_vdsm.ml | 3 +- v2v/parse_libvirt_xml.ml | 7 +- v2v/parse_ovf_from_ova.ml | 3 +- v2v/parse_vmx.ml | 1 + v2v/target_bus_assignment.ml | 1 + v2v/test-harness/Makefile.am | 3 +- v2v/test-harness/v2v_test_harness.ml | 1 + v2v/utils.ml | 3 +- v2v/v2v.ml...