search for: is_systemroot

...t_windows_systemroot () <> None + +and get_windows_systemroot () = + let rec loop = function + | [] -> None + | path :: paths -> + let path = case_sensitive_path_silently path in + match path with + | None -> loop paths + | Some path -> + if is_systemroot path then Some path + else loop paths + in + let systemroot = loop systemroot_paths in + + let systemroot = + match systemroot with + | Some systemroot -> Some systemroot + | None -> + (* If the fs contains boot.ini, check it for non-standard + * systemroot l...

...ot;/System Volume Information". Those would * *not* be Windows root disks. (RHBZ#674130) */ -static const char *systemroots[] = - { "/windows", "/winnt", "/win32", "/win", NULL }; -int -guestfs___has_windows_systemroot (guestfs_h *g) +static int is_systemroot (guestfs_h *const g, const char *const systemroot) { - size_t i; char path[256]; - for (i = 0; i < sizeof systemroots / sizeof systemroots[0]; ++i) { - CLEANUP_FREE char *systemroot = - guestfs___case_sensitive_path_silently (g, systemroots[i]); - if (!systemroot) - conti...

...shes for forward slashes in the system root + * path */ + for (char *j = path; *j != '\0'; j++) { + if (*j == '\\') *j = '/'; + } + + char *systemroot = guestfs___case_sensitive_path_silently (g, path); + if (systemroot && is_systemroot (g, systemroot)) { + debug (g, "windows %%SYSTEMROOT%% = %s", systemroot); + + return systemroot; + } else { + free (systemroot); + } + } + } + } + return NULL; /* not found */ } -- 1.8.2.1

...ar what > the effects might be of allowing the guest to allocate potentially > very large stack frames, but at best it allows the guest to cause > libguestfs to segfault. It turns out we are very lucky that > fs->windows_systemroot cannot be set arbitrarily large (see checks in > is_systemroot). > > This commit changes those to large heap allocations instead. The general idea and changes of this patch is good, although there are few places to fix. > --- a/daemon/btrfs.c > +++ b/daemon/btrfs.c > @@ -94,6 +94,11 @@ btrfs_set_label (const char *device, const char *label) &...

v10: https://www.redhat.com/archives/libguestfs/2017-July/msg00245.html No actual change here, but I rebased and retested. Also this series now does not depend on any other patch series since everything else needed is upstream. Rich.

Various changes/fixes to use smaller stack frames. Rich.

...rolled. It's not clear what the effects might be of allowing the guest to allocate potentially very large stack frames, but at best it allows the guest to cause libguestfs to segfault. It turns out we are very lucky that fs->windows_systemroot cannot be set arbitrarily large (see checks in is_systemroot). This commit changes those to large heap allocations instead. --- builder/index-parse.y | 7 +++++++ builder/pxzcat-c.c | 24 ++++++++++++++++------- cat/visit.c | 7 ++++++- daemon/available.c | 8 +++++--- daemon/base64.c | 10 ++++++++-- daemo...

v9 was here: https://www.redhat.com/archives/libguestfs/2017-July/msg00139.html This depends on these three series (the first two being single minor patches): https://www.redhat.com/archives/libguestfs/2017-July/msg00207.html https://www.redhat.com/archives/libguestfs/2017-July/msg00209.html https://www.redhat.com/archives/libguestfs/2017-July/msg00215.html There is no substantive change. I

This depends on the patch series "[PATCH 00/27] Reimplement many daemon APIs in OCaml." (https://www.redhat.com/archives/libguestfs/2017-July/msg00098.html) v8 was posted here: https://www.redhat.com/archives/libguestfs/2017-June/msg00274.html v9: - I split up the mega-patch into a more reviewable series of smaller, incremental patches. There are some other changes vs v8, but

This fixes almost everything. Note that it adds an extra commit which fixes the whole utf8/iconv business. It's probably better to list what isn't fixed: (1) I didn't leave the osinfo code around because I'm still haven't looked too closely at virt-builder-repository. Can't we just fetch this code from the git history when we need it? (2) I didn't change the way

.../* Swap backslashes for forward slashes in the system root + * path */ + for (char *j = path; *j != '\0'; j++) { + if (*j == '\\') *j = '/'; + } - char *systemroot = guestfs_int_case_sensitive_path_silently (g, path); - if (systemroot && is_systemroot (g, systemroot)) { - debug (g, "windows %%SYSTEMROOT%% = %s", systemroot); + char *systemroot = guestfs_int_case_sensitive_path_silently (g, path); + if (systemroot && is_systemroot (g, systemroot)) { + debug (g, "windows %%SYSTEMROOT%% = %s", systemroot...

Result of earlier copy and paste. --- align/scan.c | 35 ++++++++++--------- cat/cat.c | 39 +++++++++++---------- cat/filesystems.c | 69 +++++++++++++++++++------------------- cat/log.c | 35 ++++++++++--------- cat/ls.c | 61 +++++++++++++++++---------------- df/main.c | 43 ++++++++++++------------ diff/diff.c | 67

v6 was posted here: https://www.redhat.com/archives/libguestfs/2017-June/msg00103.html and this requires the utilities refactoring posted here: https://www.redhat.com/archives/libguestfs/2017-June/msg00169.html Inspection is now complete[*], although not very well tested. I'm intending to compare the output of many guests using old & new virt-inspector to see if I can find any

v5: https://www.redhat.com/archives/libguestfs/2017-June/msg00065.html Since v5, this now implements inspection almost completely for Linux and Windows guests. Rich.

v7 was: https://www.redhat.com/archives/libguestfs/2017-June/msg00169.html https://www.redhat.com/archives/libguestfs/2017-June/msg00184.html I believe this addresses all comments received so far. Also it now passes a test where I compared about 100 disk images processed with old and new virt-inspector binaries. The output is identical in all cases except one which is caused by a bug in blkid

libguestfs has used double and triple underscores in identifiers. These aren't valid for global names in C++. (http://stackoverflow.com/a/228797) These large but completely mechanical patches change the illegal identifiers to legal ones. Rich.