Displaying 20 results from an estimated 22 matches for "is_gpt".
2016 Feb 05
2
[PATCHv2] inspect: get windows drive letters for GPT disks.
...:";
snprintf (system, len, "%s/system32/config/system",
fs->windows_systemroot);
@@ -490,12 +494,18 @@ check_windows_system_registry (guestfs_h *g, struct inspect_fs *fs)
CLEANUP_FREE char *blob = NULL;
char *device;
int64_t type;
+ bool is_gpt;
type = guestfs_hivex_value_type (g, v);
blob = guestfs_hivex_value_value (g, v, &len);
- if (blob != NULL && type == 3 && len == 12) {
+ is_gpt = memcmp (blob, gpt_prefix, 8) == 0;
+ if (blob != NULL && type == 3 && (len == 12 || i...
2016 Feb 05
3
[PATCH] inspect: get windows drive letters for GPT disks.
...windows_systemroot);
@@ -493,9 +497,14 @@ check_windows_system_registry (guestfs_h *g, struct inspect_fs *fs)
type = guestfs_hivex_value_type (g, v);
blob = guestfs_hivex_value_value (g, v, &len);
- if (blob != NULL && type == 3 && len == 12) {
+ bool is_gpt = memcmp(blob, gpt_prefix, 8) == 0;
+ if (blob != NULL && type == 3 && (len == 12 || is_gpt)) {
/* Try to map the blob to a known disk and partition. */
- device = map_registry_disk_blob (g, blob);
+ if (is_gpt)
+ device = map_registry_disk_blob_...
2016 Feb 06
1
[PATCH v3] inspect: get windows drive letters for GPT disks.
...:";
snprintf (system, len, "%s/system32/config/system",
fs->windows_systemroot);
@@ -490,12 +494,18 @@ check_windows_system_registry (guestfs_h *g, struct inspect_fs *fs)
CLEANUP_FREE char *blob = NULL;
char *device;
int64_t type;
+ bool is_gpt;
type = guestfs_hivex_value_type (g, v);
blob = guestfs_hivex_value_value (g, v, &len);
- if (blob != NULL && type == 3 && len == 12) {
+ is_gpt = memcmp (blob, gpt_prefix, 8) == 0;
+ if (blob != NULL && type == 3 && (len == 12 || i...
2016 Feb 05
0
Re: [PATCH] inspect: get windows drive letters for GPT disks.
...-493,9 +497,14 @@ check_windows_system_registry (guestfs_h *g, struct inspect_fs *fs)
>
> type = guestfs_hivex_value_type (g, v);
> blob = guestfs_hivex_value_value (g, v, &len);
> - if (blob != NULL && type == 3 && len == 12) {
> + bool is_gpt = memcmp(blob, gpt_prefix, 8) == 0;
> + if (blob != NULL && type == 3 && (len == 12 || is_gpt)) {
> /* Try to map the blob to a known disk and partition. */
> - device = map_registry_disk_blob (g, blob);
> + if (is_gpt)
> + device...
2018 Jan 25
0
[PATCH v2 2/3] daemon: list-filesystems: Don't list partitions which cannot hold file system.
...quot; in
+ (* Microsoft Reserved Partition. *)
+ let gpt_msr = "E3C9E316-0B5C-4DB8-817D-F92DF00215AE" in
+
+ let device = Devsparts.part_to_dev partition in
+ let partnum = Devsparts.part_to_partnum partition in
+
+ let parttype = Parted.part_get_parttype device in
+ let is_gpt = parttype = "gpt" in
+ let is_mbr = parttype = "msdos" in
+
+ (* MBR partition id will be converted into corresponding GPT type. *)
+ let gpt_type = Parted.part_get_gpt_type device partnum in
+
+ let is_ldm = gpt_type = gpt_ldm_metadata || gpt_type = gpt_ldm_data in...
2016 Feb 05
1
Re: [PATCH] inspect: get windows drive letters for GPT disks.
...stem_registry (guestfs_h *g,
> > struct inspect_fs *fs)
> >
> > type = guestfs_hivex_value_type (g, v);
> > blob = guestfs_hivex_value_value (g, v, &len);
> > - if (blob != NULL && type == 3 && len == 12) {
> > + bool is_gpt = memcmp(blob, gpt_prefix, 8) == 0;
> > + if (blob != NULL && type == 3 && (len == 12 || is_gpt)) {
> > /* Try to map the blob to a known disk and partition. */
> > - device = map_registry_disk_blob (g, blob);
> > + if (is_gpt)
>...
2018 Apr 27
0
[PATCH v5 2/3] daemon: list-filesystems: Don't list partitions which cannot hold file system.
...artition and extended MBR partitions because they
+ * cannot hold filesystem.
+ *)
+and check_partition partition =
+ try
+ let device = Devsparts.part_to_dev partition in
+ let partnum = Devsparts.part_to_partnum partition in
+ let parttype = Parted.part_get_parttype device in
+
+ let is_gpt = parttype = "gpt" in
+ let is_mbr = parttype = "msdos" in
+ let is_gpt_or_mbr = is_gpt || is_mbr in
+
+ let is_mbr_extended =
+ if is_mbr then (
+ let mbr_type = Parted.part_get_mbr_part_type device partnum in
+ mbr_type = "extended"
+...
2018 Jan 28
9
guestfs_list_filesystems: skip block devices which cannot hold file system
Initial discussion is here: https://www.redhat.com/archives/libguestfs/2018-January/msg00188.html.
v2 was posted here: https://www.redhat.com/archives/libguestfs/2018-January/msg00246.html.
v3 comparing to v2 is just a rebase with slightly changed commits comments.
2018 Jan 25
2
[PATCH v2 1/3] daemon: Reimplement 'part_get_mbr_part_type' API in OCaml.
Instead of parsing 'parted' output OCaml implementation relies on the following facts:
1. The function is applicable for MBR partitions only (as noted in documentation and as function name suggests).
2. An attempt to call the function for non-MBR partition fails with "part_get_mbr_part_type can only be used on MBR Partitions" error and NULL is returned.
3. MBR partition table
2018 May 02
6
[PATCH v7 0/6] daemon: list_filesystems: filter out block devices which cannot hold filesystem.
This patch series addresses comments after v6 series review.
Mykola Ivanets (6):
daemon: Changing the way that we detect if a device contains
partitions.
daemon: list-filesystems: Ignore partitioned MD devices.
tests: list-filesystems command ignores partitioned MD devices.
daemon: list-filesystems: Change the way we filter out LDM partitions.
daemon: list-filesystems: Filter out
2018 Jun 01
7
[PATCH v8 0/6] daemon: list_filesystems: filter out block devices which cannot hold filesystem.
v8: - Rebased on top of master.
v7: - Addresses comments after v6 series review.
v6: - Addresses comments after v5 series review.
- Large commit is splitted to more granular commits for better code review.
v5: - Addresses comments after v4 series review (part_get_mbr_part_type doesn't break original implementation in C).
- Rebased on top of master and little bit refactored for
2018 Apr 27
4
[PATCH v5 0/3] libguestfs: guestfs_list_filesystems: skip block devices which cannot hold file system
This patch series:
1. Addresses comments from last review:
part_get_mbr_part_type doesn't break original implementation in C.
2. Rebased on top of master and little bit refactored for readability.
Mykola Ivanets (1):
tests: md: Test guestfish list-filesystems command skips partitioned
md devices.
Nikolay Ivanets (2):
daemon: Reimplement 'part_get_mbr_part_type' API in
2018 May 01
9
[PATCH v6 0/7] daemon: list_filesystems: filter out block devices which cannot hold filesystem
This patch series:
1. Addresses comments from v5 series review
2. Large commit is splitted to more granular commits for better code review.
Mykola Ivanets (6):
daemon: Changing the way that we detect if a device contains
partitions.
daemon: list-filesystems: Ignore partitioned MD devices.
tests: list-filesystems command ignores partitioned MD devices.
daemon: list-filesystems: Change
2016 Mar 06
8
[PATCH 0/5] Use less stack.
Various changes/fixes to use smaller stack frames.
Rich.
2016 Mar 07
2
[PATCH v2] Use less stack.
...em",
+ fs->windows_systemroot);
CLEANUP_FREE char *system_path = guestfs_case_sensitive_path (g, system);
if (!system_path)
@@ -495,6 +492,7 @@ check_windows_system_registry (guestfs_h *g, struct inspect_fs *fs)
char *device;
int64_t type;
bool is_gpt;
+ size_t len;
type = guestfs_hivex_value_type (g, v);
blob = guestfs_hivex_value_value (g, v, &len);
diff --git a/src/osinfo.c b/src/osinfo.c
index b1cfa09..4a4cbfc 100644
--- a/src/osinfo.c
+++ b/src/osinfo.c
@@ -229,9 +229,7 @@ static int read_os_node (guestfs_h *g, xmlX...
2017 Jul 21
10
[PATCH v10 00/10] Reimplement inspection in the daemon.
v9 was here:
https://www.redhat.com/archives/libguestfs/2017-July/msg00139.html
This depends on these three series (the first two being single minor
patches):
https://www.redhat.com/archives/libguestfs/2017-July/msg00207.html
https://www.redhat.com/archives/libguestfs/2017-July/msg00209.html
https://www.redhat.com/archives/libguestfs/2017-July/msg00215.html
There is no substantive change. I
2017 Jul 17
12
[PATCH v9 00/11] Reimplement inspection in the daemon.
This depends on the patch series
"[PATCH 00/27] Reimplement many daemon APIs in OCaml."
(https://www.redhat.com/archives/libguestfs/2017-July/msg00098.html)
v8 was posted here:
https://www.redhat.com/archives/libguestfs/2017-June/msg00274.html
v9:
- I split up the mega-patch into a more reviewable series of
smaller, incremental patches.
There are some other changes vs v8, but
2017 Aug 09
16
[PATCH v12 00/11] Reimplement inspection in the daemon.
This fixes almost everything. Note that it adds an extra commit which
fixes the whole utf8/iconv business.
It's probably better to list what isn't fixed:
(1) I didn't leave the osinfo code around because I'm still haven't
looked too closely at virt-builder-repository. Can't we just fetch
this code from the git history when we need it?
(2) I didn't change the way
2017 Jul 31
16
[PATCH v11 00/10] Reimplement inspection in the daemon.
v10: https://www.redhat.com/archives/libguestfs/2017-July/msg00245.html
No actual change here, but I rebased and retested. Also this series
now does not depend on any other patch series since everything else
needed is upstream.
Rich.
2017 Jun 19
29
[PATCH v7 00/29] Reimplement inspection in the daemon.
v6 was posted here:
https://www.redhat.com/archives/libguestfs/2017-June/msg00103.html
and this requires the utilities refactoring posted here:
https://www.redhat.com/archives/libguestfs/2017-June/msg00169.html
Inspection is now complete[*], although not very well tested. I'm
intending to compare the output of many guests using old & new
virt-inspector to see if I can find any