Displaying 5 results from an estimated 5 matches for "have_hotplug_status_watch".
2011 Apr 03
2
Signed bit field; int have_hotplug_status_watch:1
Hi Ian,
I've been going through some sparse scans of the kernel and
it threw up:
CHECK drivers/net/xen-netback/xenbus.c
drivers/net/xen-netback/xenbus.c:29:40: error: dubious one-bit signed bitfield
int have_hotplug_status_watch:1;
from your patch f942dc2552b8bfdee607be867b12a8971bb9cd85
It does look like that should be an unsigned (given it's assigned
0 and 1)
Dave
--
-----Open up your eyes, open up your mind, open up your code -------
/ Dr. David Alan Gilbert | Running GNU/Linux | Happy \
\...
2011 Apr 03
2
Signed bit field; int have_hotplug_status_watch:1
Hi Ian,
I've been going through some sparse scans of the kernel and
it threw up:
CHECK drivers/net/xen-netback/xenbus.c
drivers/net/xen-netback/xenbus.c:29:40: error: dubious one-bit signed bitfield
int have_hotplug_status_watch:1;
from your patch f942dc2552b8bfdee607be867b12a8971bb9cd85
It does look like that should be an unsigned (given it's assigned
0 and 1)
Dave
--
-----Open up your eyes, open up your mind, open up your code -------
/ Dr. David Alan Gilbert | Running GNU/Linux | Happy \
\...
2011 Apr 03
2
Signed bit field; int have_hotplug_status_watch:1
Hi Ian,
I've been going through some sparse scans of the kernel and
it threw up:
CHECK drivers/net/xen-netback/xenbus.c
drivers/net/xen-netback/xenbus.c:29:40: error: dubious one-bit signed bitfield
int have_hotplug_status_watch:1;
from your patch f942dc2552b8bfdee607be867b12a8971bb9cd85
It does look like that should be an unsigned (given it's assigned
0 and 1)
Dave
--
-----Open up your eyes, open up your mind, open up your code -------
/ Dr. David Alan Gilbert | Running GNU/Linux | Happy \
\...
2011 Apr 04
0
[PATCH] xen: netback: use unsigned type for one-bit bitfield.
Fixes error from sparse:
CHECK drivers/net/xen-netback/xenbus.c
drivers/net/xen-netback/xenbus.c:29:40: error: dubious one-bit signed bitfield
int have_hotplug_status_watch:1;
Reported-by: Dr. David Alan Gilbert <linux at treblig.org>
Signed-off-by: Ian Campbell <ian.campbell at citrix.com>
Cc: netdev at vger.kernel.org
Cc: xen-devel at lists.xensource.com
---
drivers/net/xen-netback/xenbus.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
d...
2011 Apr 04
0
[PATCH] xen: netback: use unsigned type for one-bit bitfield.
Fixes error from sparse:
CHECK drivers/net/xen-netback/xenbus.c
drivers/net/xen-netback/xenbus.c:29:40: error: dubious one-bit signed bitfield
int have_hotplug_status_watch:1;
Reported-by: Dr. David Alan Gilbert <linux at treblig.org>
Signed-off-by: Ian Campbell <ian.campbell at citrix.com>
Cc: netdev at vger.kernel.org
Cc: xen-devel at lists.xensource.com
---
drivers/net/xen-netback/xenbus.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
d...