search for: guestfs_set_pgroup

...3 +++ 2 files changed, 4 insertions(+), 1 deletions(-) diff --git a/fish/fish.c b/fish/fish.c index 575fe99..fbacbb9 100644 --- a/fish/fish.c +++ b/fish/fish.c @@ -406,7 +406,7 @@ main (int argc, char *argv[]) sigaction (SIGINT, &sa, NULL); sigaction (SIGQUIT, &sa, NULL); - guestfs_set_pgroup (g, 1); + guestfs_set_pgroup (g, 0); } /* Old-style -i syntax? Since -a/-d/-N and -i was disallowed diff --git a/src/guestfs.c b/src/guestfs.c index 3493d79..2ff506b 100644 --- a/src/guestfs.c +++ b/src/guestfs.c @@ -143,6 +143,9 @@ guestfs_create (void) */ g->msg_next_serial...

Hi, this patch series fixes few more issues discovered by Coverity. Thanks, Pino Toscano (6): tail: check the return value pf guestfs_set_pgroup daemon: btrfs: check end_stringsbuf return values everywhere java: use cleanup handlers for structs (lists) as return values lib: qemu: improve handling of FILE* p2v: check more return values p2v: fix possible close(-1) issue cat/tail.c | 5 ++- daemon/btrfs.c | 3 +- gene...

...it a/fish/fish.c b/fish/fish.c index efd6b0b..b782b7c 100644 --- a/fish/fish.c +++ b/fish/fish.c @@ -402,6 +402,7 @@ main (int argc, char *argv[]) sa.sa_handler = user_cancel; sa.sa_flags = SA_RESTART; sigaction (SIGINT, &sa, NULL); + sigaction (SIGQUIT, &sa, NULL); guestfs_set_pgroup (g, 1); } -- 1.7.8

The existing mechanism was clunky, slow and used ~ 10 MB of local disk. Rich.

...aults with @@ -1271,7 +1271,7 @@ There are two common places that you might call C<guestfs_user_cancel>: In an interactive text-based program, you might call it from a C<SIGINT> signal handler so that pressing C<^C> cancels the current -operation. (You also need to call L</guestfs_set_pgroup> so that +operation. (You also need to call C<guestfs_set_pgroup> so that child processes don't receive the C<^C> signal). In a graphical program, when the main thread is displaying a progress @@ -1585,7 +1585,7 @@ file types such as directories, symbolic links, block specia...

Nothing new in the virt-tail command itself, but the second commit includes a simple test. Rich.

...ge to track each file. */ + file = calloc (argc, sizeof (struct follow)); + + /* We loop until the user hits ^C. */ + memset (&sa, 0, sizeof sa); + sa.sa_handler = user_cancel; + sa.sa_flags = SA_RESTART; + sigaction (SIGINT, &sa, NULL); + sigaction (SIGQUIT, &sa, NULL); + + if (guestfs_set_pgroup (g, 1) == -1) + exit (EXIT_FAILURE); + + drvt = disk_mtime (drvs); + if (drvt == (time_t)-1) + return -1; + + while (!quit) { + time_t t; + int i; + int windows; + int processed; + + if (add_and_mount (drvs, mps, &windows) == -1) + return -1; + + /* Check files h...

This adds a new tool which does a follow operation (ie. tail -f) on one or more log/text files inside the guest. I've only done limited testing, but it works for me for tailing various long-running builds inside guests which I'm doing at the moment. There are no tests at present. Rich.

...ge to track each file. */ + file = calloc (argc, sizeof (struct follow)); + + /* We loop until the user hits ^C. */ + memset (&sa, 0, sizeof sa); + sa.sa_handler = user_cancel; + sa.sa_flags = SA_RESTART; + sigaction (SIGINT, &sa, NULL); + sigaction (SIGQUIT, &sa, NULL); + + if (guestfs_set_pgroup (g, 1) == -1) + exit (EXIT_FAILURE); + + drvt = disk_mtime (drvs); + if (drvt == (time_t)-1) + return -1; + + while (!quit) { + time_t t; + int i; + int windows = 0; + char *root; + CLEANUP_FREE_STRING_LIST char **roots = NULL; + int processed; + + /* Add drives, inspe...

...rgc, sizeof (struct follow)); > + > + /* We loop until the user hits ^C. */ > + memset (&sa, 0, sizeof sa); > + sa.sa_handler = user_cancel; > + sa.sa_flags = SA_RESTART; > + sigaction (SIGINT, &sa, NULL); > + sigaction (SIGQUIT, &sa, NULL); > + > + if (guestfs_set_pgroup (g, 1) == -1) > + exit (EXIT_FAILURE); > + > + drvt = disk_mtime (drvs); > + if (drvt == (time_t)-1) > + return -1; > + > + while (!quit) { > + time_t t; > + int i; > + int windows; > + int processed; > + > + if (add_and_mount (drvs, mp...

Since v2: - Fix the things that Pino mentioned, except the recursion. - Implement Windows support. For Windows support to be sane, I had to inline the add_and_mount code. Rich.

libguestfs has used double and triple underscores in identifiers. These aren't valid for global names in C++. (http://stackoverflow.com/a/228797) These large but completely mechanical patches change the illegal identifiers to legal ones. Rich.

Split up the huge generator/actions.ml into several smaller files. Rich.