Displaying 17 results from an estimated 17 matches for "guestfs_int_free_qemu_data".
2016 May 12
0
[PATCH 4/4] lib: qemu: Memoize qemu feature detection.
...R_OK) == -1)
+ goto do_test;
+
+ debug (g, "loading previously cached test results");
+
+ data = safe_calloc (g, 1, sizeof *data);
+
+ if (guestfs_int_read_whole_file (g, qemu_help_filename,
+ &data->qemu_help, NULL) == -1) {
+ guestfs_int_free_qemu_data (data);
+ return NULL;
+ }
+
+ parse_qemu_version (g, data);
+
+ if (guestfs_int_read_whole_file (g, qemu_devices_filename,
+ &data->qemu_devices, NULL) == -1) {
+ guestfs_int_free_qemu_data (data);
+ return NULL;
+ }
+
+ retu...
2017 Mar 06
7
[PATCH 0/6] Various Coverity fixes #2
Hi,
this patch series fixes few more issues discovered by Coverity.
Thanks,
Pino Toscano (6):
tail: check the return value pf guestfs_set_pgroup
daemon: btrfs: check end_stringsbuf return values everywhere
java: use cleanup handlers for structs (lists) as return values
lib: qemu: improve handling of FILE*
p2v: check more return values
p2v: fix possible close(-1) issue
cat/tail.c
2017 Sep 12
0
[PATCH v2 2/5] lib: qemu: Factor out common code for reading and writing cache files.
...R_OK) == -1)
- goto do_test;
-
- debug (g, "loading previously cached test results");
-
- data = safe_calloc (g, 1, sizeof *data);
-
- if (guestfs_int_read_whole_file (g, qemu_help_filename,
- &data->qemu_help, NULL) == -1) {
- guestfs_int_free_qemu_data (data);
- return NULL;
- }
-
- parse_qemu_version (g, data->qemu_help, &data->qemu_version);
-
- if (guestfs_int_read_whole_file (g, qemu_devices_filename,
- &data->qemu_devices, NULL) == -1) {
- guestfs_int_free_qemu_data (dat...
2016 May 25
4
[PATCH 0/4] qemu: Use sqlite to store qemu detection data.
Patches 1 & 2 were posted previously here:
https://www.redhat.com/archives/libguestfs/2016-May/msg00134.html
Patch 3 is a hack so I can test this using my own version of qemu (the
`-L ?' stuff is not upstream).
Patch 4 is where the real action takes place: Replace the caching of
qemu features in blob-like files with a sqlite database. Probably the
best way to approach this patch is to
2017 Sep 11
4
[PATCH 0/4] lib: qemu: Add test for mandatory locking.
The patch I posted last week to disable mandatory locking for readonly
drives
(https://www.redhat.com/archives/libguestfs/2017-September/msg00013.html)
was wrong in a couple of respects. Firstly it didn't work, which I
didn't detect because my tests were testing the wrong thing. Oops.
Secondly it used a simple version number check to detect qemu binaries
implementing mandatory locking.
2017 Sep 12
8
[PATCH v3 0/6] launch: direct: Disable qemu locking when opening drives readonly.
v2 -> v3:
- I addressed everything that Pino mentioned last time.
- It's tricky to get a stable run when multiple copies of qemu are
involved, because the same cache files get overwritten by parallel
libguestfs. So I changed the names of the cache files to include
the qemu binary key (size, mtime), which removes this conflict.
This is in new patch 4/6.
Rich.
2017 Sep 12
9
[PATCH v2 0/5] launch: direct: Disable qemu locking when opening drives readonly (RHBZ#1417306)
Patches 1-4 are almost the same as they are when previously posted
here:
https://www.redhat.com/archives/libguestfs/2017-September/msg00039.html
Patch 5 actually uses the mandatory locking test to turn off locking
in the narrow case where a drive is opened readonly, and then only for
the drive being inspected.
Passes ordinary tests (‘check-direct’ and ‘check-valgrind-direct’).
Rich.
2016 May 18
2
[PATCH v2 0/2] lib: qemu: Memoize qemu feature detection.
v1 -> v2:
- Rebase on top of Pino's version work.
Two patches went upstream, these are the two remaining patches.
Note the generation number is still inside the qemu.stat file. We
could put it in the filename, I have no particular preference.
Rich.
2016 May 12
7
[PATCH 0/4] lib: qemu: Memoize qemu feature detection.
Doing qemu feature detection in the direct backend takes ~100ms
because we need to run `qemu -help' and `qemu -devices ?', and each of
those interacts with glibc's very slow link loader.
Fixing the link loader is really hard. Instead memoize the
output of those two commands.
This patch series first separates all the code dealing with qemu into
a separate module (src/qemu.c) and
2016 May 17
2
[PATCH 0/2] Use -bios bios-fast.bin where supported.
NOTE: Not for upstream, yet.
This depends on 3 non-upstream patches.
- The qemu rework in libguestfs, which in turn depends on what
Pino is up to.
- Support for '-L ?' in qemu:
https://lists.gnu.org/archive/html/qemu-devel/2016-05/threads.html#02596
- Support for bios-fast.bin in qemu:
https://lists.gnu.org/archive/html/qemu-devel/2016-05/threads.html#02408
This commit
2016 May 18
2
[PATCH v2 0/2] Use -bios bios-fast.bin where supported.
This commit uses -bios bios-fast.bin if available, which basically
stops SeaBIOS from trying to do PCI probing during boot, which is a
waste of time when using the -kernel option.
v1 -> v2:
- Rebase on top of Pino's work.
This still has 3 dependencies:
- The qemu memoization work (v2).
- Support for '-L ?' in qemu:
2017 Sep 12
0
[PATCH v2 3/5] lib: qemu: Run QMP ‘query-commands’, ‘query-qmp-schema’ against the qemu binary.
...eted by the tmp cleaner */
+ if (r == 0) {
+ /* Cache gone, maybe deleted by the tmp cleaner, so we must run
+ * the full tests. We will have a partially filled qemu_data
+ * structure. The safest way to deal with that is to free
+ * it and start again.
+ */
+ guestfs_int_free_qemu_data (data);
+ data = safe_calloc (g, 1, sizeof *data);
goto do_test;
+ }
}
goto out;
@@ -186,6 +212,8 @@ guestfs_int_test_qemu (guestfs_h *g)
out:
/* Derived fields. */
parse_qemu_version (g, data->qemu_help, &data->qemu_version);
+ parse_json (g, data->qmp_...
2018 Sep 13
1
[PATCH] lib: direct: Query qemu binary for availability of KVM (RHBZ#1605071).
...ng and writing plain text strings.
@@ -628,6 +713,12 @@ guestfs_int_qemu_mandatory_locking (guestfs_h *g,
return 0;
}
+bool
+guestfs_int_platform_has_kvm (guestfs_h *g, const struct qemu_data *data)
+{
+ return data->has_kvm;
+}
+
/**
* Escape a qemu parameter.
*
@@ -976,6 +1067,7 @@ guestfs_int_free_qemu_data (struct qemu_data *data)
free (data->qemu_help);
free (data->qemu_devices);
free (data->qmp_schema);
+ free (data->query_kvm);
json_decref (data->qmp_schema_tree);
free (data);
}
--
2.19.0.rc0
2018 Feb 12
0
[PATCH v2 1/1] Switch from YAJL to Jansson
...&&
+ STREQ (json_string_value (name), "locking"))
return 1;
}
}
@@ -646,8 +628,6 @@ guestfs_int_qemu_mandatory_locking (guestfs_h *g,
return 0;
}
-#pragma GCC diagnostic pop
-
/**
* Escape a qemu parameter.
*
@@ -995,7 +975,7 @@ guestfs_int_free_qemu_data (struct qemu_data *data)
free (data->qemu_help);
free (data->qemu_devices);
free (data->qmp_schema);
- yajl_tree_free (data->qmp_schema_tree);
+ json_decref (data->qmp_schema_tree);
free (data);
}
}
diff --git a/m4/guestfs-libraries.m4 b/m4/guestfs-libra...
2017 Nov 23
0
[PATCH 1/1] Switch from YAJL to Jansson
...&&
+ STREQ (json_string_value (name), "locking"))
return 1;
}
}
@@ -646,8 +628,6 @@ guestfs_int_qemu_mandatory_locking (guestfs_h *g,
return 0;
}
-#pragma GCC diagnostic pop
-
/**
* Escape a qemu parameter.
*
@@ -995,7 +975,7 @@ guestfs_int_free_qemu_data (struct qemu_data *data)
free (data->qemu_help);
free (data->qemu_devices);
free (data->qmp_schema);
- yajl_tree_free (data->qmp_schema_tree);
+ json_decref (data->qmp_schema_tree);
free (data);
}
}
diff --git a/m4/guestfs-libraries.m4 b/m4/guestfs-libra...
2018 Feb 12
2
[PATCH v2 0/1] RFC: switch from YAJL to Jansson
Hi,
recently, there was a discussion in the development list of libvirt on
switching to a different JSON library than YAJL [1]. Since we use YAJL,
and the points there IMHO apply to libguestfs as well, I decided to give
a try in switching to Jansson [2].
The result IMHO is nice, with the additional APIs of Jansson that
simplify some of our code. Unlike with YAJL, I did not set a minimum
2017 Nov 23
4
[PATCH 0/1] RFC: switch from YAJL to Jansson
Hi,
recently, there was a discussion in the development list of libvirt on
switching to a different JSON library than YAJL [1]. Since we use YAJL,
and the points there IMHO apply to libguestfs as well, I decided to give
a try in switching to Jansson [2].
The result IMHO is nice, with the additional APIs of Jansson that
simplify some of our code. Unlike with YAJL, I did not set a minimum