search for: guestfs_impl_launch

...rt.so.0 > > #6 0x00007fac56de213d in remoteDomainCreateXML () from > /lib64/libvirt.so.0 > > #7 0x00007fac56d82151 in virDomainCreateXML () from /lib64/libvirt.so.0 > > #8 0x00007fac58acca50 in launch_libvirt () from /lib64/libguestfs.so.0 > > #9 0x00007fac58ac2b2b in guestfs_impl_launch () from > /lib64/libguestfs.so.0 > > #10 0x00007fac58a5eba5 in guestfs_launch () from /lib64/libguestfs.so.0 > > #11 0x00000000004117ca in main () > ... > > libguestfs: [62900ms] launch libvirt guest > > The error is happening in libvirt's virDomainCreateXML call,...

..._from_daemon (g=g@entry=0x7fe6f8e04bd0, size_rtn=size_rtn@entry=0x7ffe4c0538e4, buf_rtn=buf_rtn@entry=0x7ffe4c053908) at proto.c:611 #5 0x00007fe6f797dae0 in launch_libvirt (g=0x7fe6f8e04bd0, datav=0x7fe6f8e04d90, libvirt_uri=<optimized out>) at launch-libvirt.c:573 #6 0x00007fe6f7973b2b in guestfs_impl_launch (g=g@entry=0x7fe6f8e04bd0) at launch.c:93 #7 0x00007fe6f790fb4d in guestfs_launch (g=0x7fe6f8e04bd0) at actions-3.c:142 #8 0x00007fe6f86e7eda in run_launch (cmd=<optimized out>, argc=<optimized out>, argv=<optimized out>) at cmds.c:13411 #9 0x00007fe6f870276c in issue_command (...

...if (drv->disk_label) append_list_format ("serial=%s", drv->disk_label); } end_list (); diff --git a/lib/launch.c b/lib/launch.c index eb7f85c..f56e389 100644 --- a/lib/launch.c +++ b/lib/launch.c @@ -54,7 +54,7 @@ static struct backend { } *backends = NULL; int -guestfs_impl_launch (guestfs_h *g) +guestfs_impl_launch (guestfs_h *g, const struct guestfs_launch_argv *optargs) { int r; @@ -85,6 +85,16 @@ guestfs_impl_launch (guestfs_h *g) if (guestfs_int_lazy_make_tmpdir (g) == -1) return -1; + /* Add the blocksize. */ + if (optargs->blocksize >= 512 &amp...

Move to lazy_make_tmpdir the logic for making world-readable (but only for root) newly-created temporary directories, removing the non-fatal code doing that in guestfs_impl_launch. Followup of commit 772f649e595d202bdb67f05aeb62157c1104be89. --- src/launch.c | 7 ------- src/tmpdirs.c | 30 ++++++++++++------------------ 2 files changed, 12 insertions(+), 25 deletions(-) diff --git a/src/launch.c b/src/launch.c index 9273c58..958d4b3 100644 --- a/src/launch.c +++ b/src/...

...h *g); + #endif /* GUESTFS_INTERNAL_H_ */ diff --git a/src/launch.c b/src/launch.c index a4326fe..460ed29 100644 --- a/src/launch.c +++ b/src/launch.c @@ -50,8 +50,6 @@ static struct backend { const struct backend_ops *ops; } *backends = NULL; -static mode_t get_umask (guestfs_h *g); - int guestfs_impl_launch (guestfs_h *g) { @@ -75,6 +73,7 @@ guestfs_impl_launch (guestfs_h *g) guestfs_version (g); struct backend *b; CLEANUP_FREE char *backend = guestfs_get_backend (g); + int mask; debug (g, "launch: program=%s", g->program); if (STRNEQ (g->identifier, &q...

...append_list_format ("serial=%s", drv->disk_label); } end_list (); diff --git a/lib/launch.c b/lib/launch.c index eb7f85c..8edf7b1 100644 --- a/lib/launch.c +++ b/lib/launch.c @@ -53,6 +53,20 @@ static struct backend { const struct backend_ops *ops; } *backends = NULL; +int +guestfs_impl_launch_blocksize (guestfs_h *g, int blocksize) +{ + if (blocksize >= 512 && blocksize <= 32768 + && (blocksize & (blocksize-1)) == 0) { + g->blocksize = blocksize; + return guestfs_impl_launch (g); + } + else { + error (g, _("blocksize must be a power of...

...h *g); + #endif /* GUESTFS_INTERNAL_H_ */ diff --git a/src/launch.c b/src/launch.c index a4326fe..460ed29 100644 --- a/src/launch.c +++ b/src/launch.c @@ -50,8 +50,6 @@ static struct backend { const struct backend_ops *ops; } *backends = NULL; -static mode_t get_umask (guestfs_h *g); - int guestfs_impl_launch (guestfs_h *g) { @@ -75,6 +73,7 @@ guestfs_impl_launch (guestfs_h *g) guestfs_version (g); struct backend *b; CLEANUP_FREE char *backend = guestfs_get_backend (g); + int mask; debug (g, "launch: program=%s", g->program); if (STRNEQ (g->identifier, &q...

...cbfe2 in callFull.isra.2 () from /lib64/libvirt.so.0 #6 0x00007fac56de213d in remoteDomainCreateXML () from /lib64/libvirt.so.0 #7 0x00007fac56d82151 in virDomainCreateXML () from /lib64/libvirt.so.0 #8 0x00007fac58acca50 in launch_libvirt () from /lib64/libguestfs.so.0 #9 0x00007fac58ac2b2b in guestfs_impl_launch () from /lib64/libguestfs.so.0 #10 0x00007fac58a5eba5 in guestfs_launch () from /lib64/libguestfs.so.0 #11 0x00000000004117ca in main () Log: 2016-Aug-29 15:02:07 main:1385 Entering main() 2016-Aug-29 15:02:07 main:1393 guestfs_create succeeded 2016-Aug-29 15:02:07 main:1398 guestfs_set_network o...

...h *g); + #endif /* GUESTFS_INTERNAL_H_ */ diff --git a/src/launch.c b/src/launch.c index a4326fe..460ed29 100644 --- a/src/launch.c +++ b/src/launch.c @@ -50,8 +50,6 @@ static struct backend { const struct backend_ops *ops; } *backends = NULL; -static mode_t get_umask (guestfs_h *g); - int guestfs_impl_launch (guestfs_h *g) { @@ -75,6 +73,7 @@ guestfs_impl_launch (guestfs_h *g) guestfs_version (g); struct backend *b; CLEANUP_FREE char *backend = guestfs_get_backend (g); + int mask; debug (g, "launch: program=%s", g->program); if (STRNEQ (g->identifier, &q...

...) from /lib64/libc.so.6 > #1 0x00007fe3aa1e5ea4 in read_data () from /lib64/libguestfs.so.0 > #2 0x00007fe3aa20af0c in guestfs_int_recv_from_daemon () from > /lib64/libguestfs.so.0 > #3 0x00007fe3aa204ae0 in launch_libvirt () from /lib64/libguestfs.so.0 > #4 0x00007fe3aa1fab2b in guestfs_impl_launch () from /lib64/libguestfs.so.0 > #5 0x00007fe3aa196b4d in guestfs_launch () from /lib64/libguestfs.so.0 > #6 0x00000000004116f8 in main () Before you call guestfs_launch(), call: guestfs_set_verbose (1); guestfs_set_trace (1); That should print (on stderr) a lot more information abou...

...ra.2 () from /lib64/libvirt.so.0 > #6 0x00007fac56de213d in remoteDomainCreateXML () from /lib64/libvirt.so.0 > #7 0x00007fac56d82151 in virDomainCreateXML () from /lib64/libvirt.so.0 > #8 0x00007fac58acca50 in launch_libvirt () from /lib64/libguestfs.so.0 > #9 0x00007fac58ac2b2b in guestfs_impl_launch () from /lib64/libguestfs.so.0 > #10 0x00007fac58a5eba5 in guestfs_launch () from /lib64/libguestfs.so.0 > #11 0x00000000004117ca in main () ... > libguestfs: [62900ms] launch libvirt guest The error is happening in libvirt's virDomainCreateXML call, called from libguestfs here: http...

...y drives have been added, the current backend only supports 255 drives --- lib/launch.c | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/lib/launch.c b/lib/launch.c index 7f06c69..a977db5 100644 --- a/lib/launch.c +++ b/lib/launch.c @@ -55,12 +55,23 @@ static struct backend { int guestfs_impl_launch (guestfs_h *g) { + int r; + /* Configured? */ if (g->state != CONFIG) { error (g, _("the libguestfs handle has already been launched")); return -1; } + /* Too many drives? */ + r = guestfs_max_disks (g); + if (r == -1) + return -1; + if (g->nr_drives &g...

v1 was here: https://www.redhat.com/archives/libguestfs/2017-April/msg00268.html v1 broke some tests because the guestfs_max_disks API isn't supported by some backends, specifically ?unix:?. This makes failure of guestfs_max_disks non-fatal. Rich.

...ives have been added, the current backend only supports 255 drives --- lib/launch.c | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/lib/launch.c b/lib/launch.c index 7f06c69..37ab024 100644 --- a/lib/launch.c +++ b/lib/launch.c @@ -55,12 +55,27 @@ static struct backend { int guestfs_impl_launch (guestfs_h *g) { + int r; + /* Configured? */ if (g->state != CONFIG) { error (g, _("the libguestfs handle has already been launched")); return -1; } + /* Too many drives? + * + * Some backends such as ?unix:? don't allow us to query max_disks. + * Don...

This is very useful for debugging multithreaded programs. Rich.

...2c20 in __poll_nocancel () from /lib64/libc.so.6 #1 0x00007fe3aa1e5ea4 in read_data () from /lib64/libguestfs.so.0 #2 0x00007fe3aa20af0c in guestfs_int_recv_from_daemon () from /lib64/libguestfs.so.0 #3 0x00007fe3aa204ae0 in launch_libvirt () from /lib64/libguestfs.so.0 #4 0x00007fe3aa1fab2b in guestfs_impl_launch () from /lib64/libguestfs.so.0 #5 0x00007fe3aa196b4d in guestfs_launch () from /lib64/libguestfs.so.0 #6 0x00000000004116f8 in main () It is very easy to reproduce this issue. Does anyone has any idea about this issue? Here is output of libguestfs_test_tool: *******************************...

...uot;, + cachedir, (uintmax_t) geteuid ()); guestfs_int_cmd_add_arg (cmd, "ls"); guestfs_int_cmd_add_arg (cmd, "-a"); diff --git a/src/launch.c b/src/launch.c index fd5479e..343f4ea 100644 --- a/src/launch.c +++ b/src/launch.c @@ -86,7 +86,7 @@ guestfs_impl_launch (guestfs_h *g) debug (g, "launch: tmpdir=%s", g->tmpdir); debug (g, "launch: umask=0%03o", get_umask (g)); - debug (g, "launch: euid=%d", geteuid ()); + debug (g, "launch: euid=%ju", (uintmax_t) geteuid ()); } /* Launch the applia...

...uot;, + cachedir, (uintmax_t) geteuid ()); guestfs_int_cmd_add_arg (cmd, "ls"); guestfs_int_cmd_add_arg (cmd, "-a"); diff --git a/src/launch.c b/src/launch.c index fd5479e..343f4ea 100644 --- a/src/launch.c +++ b/src/launch.c @@ -86,7 +86,7 @@ guestfs_impl_launch (guestfs_h *g) debug (g, "launch: tmpdir=%s", g->tmpdir); debug (g, "launch: umask=0%03o", get_umask (g)); - debug (g, "launch: euid=%d", geteuid ()); + debug (g, "launch: euid=%ju", (uintmax_t) geteuid ()); } /* Launch the applia...

The existing mechanism was clunky, slow and used ~ 10 MB of local disk. Rich.

This patch series moves some files and directories around but is only code motion (or supposed to be). A new directory, common/, is created for all of the common code which is currently shared in random ways between parts of the project. And src/ becomes lib/ (the largest change, but mostly mechanical). In full this series makes the following changes: src/libprotocol -> common/protocol