Displaying 20 results from an estimated 24 matches for "guestfs_file_architecture".
2016 Jan 26
2
[PATCH] inspect: Get architecture of Alpine Linux from /bin/busybox.
All the files in /bin are links to busybox. guestfs_file_architecture
doesn't follow symlinks so it fails. Therefore check /bin/busybox
(not a symlink) to find the architecture.
---
src/inspect-fs-unix.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/inspect-fs-unix.c b/src/inspect-fs-unix.c
index f915e86..6aaf5a1 100644
--- a/src/ins...
2016 Jan 26
1
[PATCH] inspect: resolve symlinks when detecting architecture
...stfs_is_file_opts (g, binaries[i],
+ GUESTFS_IS_FILE_OPTS_FOLLOWSYMLINKS, 1, -1) > 0) {
+ CLEANUP_FREE char *resolved = NULL;
+
+ /* Ignore errors from realpath and file_architecture calls. */
guestfs_push_error_handler (g, NULL, NULL);
- arch = guestfs_file_architecture (g, binaries[i]);
+ resolved = guestfs_realpath (g, binaries[i]);
+ /* If is_file above succeeded realpath should too, but better
+ * be safe than sorry.
+ */
+ if (resolved)
+ arch = guestfs_file_architecture (g, resolved);
guestfs_pop_error_handler (g);...
2012 Nov 05
2
[PATCH 0/1] lib: debian support for package arch inspection
...is adds package arch inspection for deb-based systems. The patch
returns package arch as given by dpkg, which means that it returns
'amd64' instead of 'x86_64', for example. Whether or not we should
standardize this to match rpm output is up for debate. I see other
places such as guestfs_file_architecture that use the rpm-style arch.
I can understand though where a user of guestfs inspecting deb-based
hosts would rather get back the "native" strings.
Thoughts?
2017 Feb 27
1
[PATCH] lib: Require libmagic.
If libmagic isn't installed then the guestfs_file_architecture API
doesn't work. This means that inspection will always return
<arch>unknown</arch> for every guest. This subtly breaks a few
features. In particular it was reported that the
virt-builder/virt-customize --install option did not work because the
"unknown" architecture o...
2016 Jan 26
0
Re: [PATCH] inspect: Get architecture of Alpine Linux from /bin/busybox.
On Tuesday 26 January 2016 15:54:46 Richard W.M. Jones wrote:
> All the files in /bin are links to busybox. guestfs_file_architecture
> doesn't follow symlinks so it fails. Therefore check /bin/busybox
> (not a symlink) to find the architecture.
> ---
While this patch looks okay in principle, I think it would be better
to just resolve the paths we are looking for: that is, do symlink
resolution in is_file, and use...
2015 May 26
6
[PATCH 0/6] Update the way that API versions are generated for the man page.
The existing mechanism was clunky, slow and used ~ 10 MB of
local disk.
Rich.
2012 Sep 28
0
[PATCH v2] inspection: Fix calls to case_sensitive_path (RHBZ#858126).
...);
- char *cmd_exe_path = guestfs___case_sensitive_path_silently (g, cmd_exe);
+ /* Should exist because of previous check above in has_windows_systemroot. */
+ char *cmd_exe_path = guestfs_case_sensitive_path (g, cmd_exe);
if (!cmd_exe_path)
- return 0;
+ return -1;
char *arch = guestfs_file_architecture (g, cmd_exe_path);
free (cmd_exe_path);
@@ -210,17 +209,24 @@ static int
check_windows_software_registry (guestfs_h *g, struct inspect_fs *fs)
{
int ret = -1;
+ int r;
size_t len = strlen (fs->windows_systemroot) + 64;
char software[len];
snprintf (software, len, "%s/sys...
2012 Sep 28
2
[PATCH 0/2] Fix calls to case_sensitive_path.
Proposed patches to fix
https://bugzilla.redhat.com/show_bug.cgi?id=858126
2020 Jul 24
3
[PATCH v2] v2v: fix UEFI bootloader for linux guests
v2:
Rich, I hope I've done all modifications according to your comments, namely:
* moved the code from linux_bootloaders to convert_linux
* made minor code modifications
---
Not all UEFI guests can survive conversion, because of lost bootloader
information in UEFI NVRAM. But some guest can cope with this because they
have a fallback bootloader and use UEFI Removable Media Boot
2010 Aug 02
5
[PATCH v3 0/5] Inspection code in C
The first three patches were posted previously:
https://www.redhat.com/archives/libguestfs/2010-July/msg00082.html
The last two patches in this series change guestfish -i to use
this new code.
Rich.
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming blog: http://rwmj.wordpress.com
Fedora now supports 80 OCaml packages (the OPEN alternative to
2010 Jul 29
4
[PATCH 0/3] Inspection code in C
These three patches (two were previously posted) can do simple
operating system inspection in C.
Example of use:
><fs> add-ro rhel55.img
><fs> run
><fs> inspect-os
/dev/VolGroup00/LogVol00
><fs> inspect-get-type /dev/VolGroup00/LogVol00
linux
><fs> inspect-get-distro /dev/VolGroup00/LogVol00
rhel
><fs> inspect-get-arch
2010 Aug 17
8
[PATCH v4 0/8] Inspection code in C
Previously discussed here:
https://www.redhat.com/archives/libguestfs/2010-August/msg00002.html
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
virt-df lists disk usage of guests without needing to install any
software inside the virtual machine. Supports Linux and Windows.
http://et.redhat.com/~rjones/virt-df/
2014 Oct 18
1
ANNOUNCE: libguestfs 1.28 released
...Inspection
Oracle Linux is returned as oraclelinux (Nikos Skalkotos).
Linux guests which do not have /etc/fstab can now be handled (Pino
Toscano).
Minix is returned as minix (Pino Toscano).
Architectures
Aarch64 (64 bit ARM) support has been added.
Inspection and the guestfs_file_architecture call can now recognize arm
(32 bit) and aarch64 guests.
Security
CVE-2014-0191 Network usage and entity resolution in XML parsing
Libguestfs previously used unsafe libxml2 APIs for parsing libvirt
XML. These APIs defaulted to allowing network connections to be made
whe...
2017 Feb 28
0
ANNOUNCE: libguestfs 1.36 released
...red. Also handled are disks
which require libvirt authentication secrets to open (Pino
Toscano).
"guestfs_canonical_device_name"
This call will no longer incorrectly modify Linux software RAID
device names (like /dev/mdX).
"guestfs_file_architecture"
Previously the "file_architecture" API could return either of the
strings "i386" or "i486" for 32 bit x86 binaries. It now only
returns "i386" (as documented).
This API can now return the following new value...
2013 Jan 25
4
[PATCH 0/3] Use __attribute__((cleanup(...)))
This patch series changes a small part of the library to use
__attribute__((cleanup(...))) to automatically free memory when
pointers go out of the current scope.
In general terms this seems to be a small win although you do have to
use it carefully. For functions where you can completely get rid of
the "exit code paths", it can simplify things. For a good example,
see the
2017 Jul 21
10
[PATCH v10 00/10] Reimplement inspection in the daemon.
v9 was here:
https://www.redhat.com/archives/libguestfs/2017-July/msg00139.html
This depends on these three series (the first two being single minor
patches):
https://www.redhat.com/archives/libguestfs/2017-July/msg00207.html
https://www.redhat.com/archives/libguestfs/2017-July/msg00209.html
https://www.redhat.com/archives/libguestfs/2017-July/msg00215.html
There is no substantive change. I
2017 Jul 17
12
[PATCH v9 00/11] Reimplement inspection in the daemon.
This depends on the patch series
"[PATCH 00/27] Reimplement many daemon APIs in OCaml."
(https://www.redhat.com/archives/libguestfs/2017-July/msg00098.html)
v8 was posted here:
https://www.redhat.com/archives/libguestfs/2017-June/msg00274.html
v9:
- I split up the mega-patch into a more reviewable series of
smaller, incremental patches.
There are some other changes vs v8, but
2017 Aug 09
16
[PATCH v12 00/11] Reimplement inspection in the daemon.
This fixes almost everything. Note that it adds an extra commit which
fixes the whole utf8/iconv business.
It's probably better to list what isn't fixed:
(1) I didn't leave the osinfo code around because I'm still haven't
looked too closely at virt-builder-repository. Can't we just fetch
this code from the git history when we need it?
(2) I didn't change the way
2017 Jul 31
16
[PATCH v11 00/10] Reimplement inspection in the daemon.
v10: https://www.redhat.com/archives/libguestfs/2017-July/msg00245.html
No actual change here, but I rebased and retested. Also this series
now does not depend on any other patch series since everything else
needed is upstream.
Rich.
2017 Jun 19
29
[PATCH v7 00/29] Reimplement inspection in the daemon.
v6 was posted here:
https://www.redhat.com/archives/libguestfs/2017-June/msg00103.html
and this requires the utilities refactoring posted here:
https://www.redhat.com/archives/libguestfs/2017-June/msg00169.html
Inspection is now complete[*], although not very well tested. I'm
intending to compare the output of many guests using old & new
virt-inspector to see if I can find any