search for: guestfs_c_actions

Hi, building current git fails with gcc -std=gnu99 -std=gnu99 -I.. -I/usr/lib/ocaml -I../ocaml -I../src -I../src -g -O2 -fPIC -Wall -c guestfs_c_actions.c In file included from ../src/guestfs.h:84, from guestfs_c_actions.c:35: ../src/guestfs-actions.h:28: error: expected declaration specifiers or '...' before 'va_list' This is fixed by an #include <stdarg.h> but since this file is autogenrated in some ocam...

...on that is checked in: diff --git a/po/POTFILES.in b/po/POTFILES.in index ca01b3d..154915a 100644 --- a/po/POTFILES.in +++ b/po/POTFILES.in @@ -63,12 +63,11 @@ fish/tilde.c fish/time.c inspector/virt-inspector.pl java/com_redhat_et_libguestfs_GuestFS.c -ocaml/guestfs_c_actions.c ocaml/guestfs_c.c +ocaml/guestfs_c_actions.c perl/bindtests.pl -perl/Guestfs.c -perl/lib/Sys/Guestfs/Lib.pm perl/lib/Sys/Guestfs.pm +perl/lib/Sys/Guestfs/Lib.pm python/guestfs-py.c ruby/ext/guestfs/_guestfs.c src/guestfs-actions.c If we generate that...

From: "Richard W.M. Jones" <rjones at redhat.com> --- configure.ac | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/configure.ac b/configure.ac index fa97479..6e42423 100644 --- a/configure.ac +++ b/configure.ac @@ -141,6 +141,10 @@ if test "$gl_gcc_warnings" = yes; then # Work around warning in src/inspect.c. This seems to be a bug in gcc

Hi Rich, I realized a day or two late that my suggestion was not quite right. Here's the fix: >From 5294c21cf07c4ec2f094182ba9f32696f3de2751 Mon Sep 17 00:00:00 2001 From: Jim Meyering <meyering at redhat.com> Date: Mon, 23 Jan 2012 10:01:40 +0100 Subject: [PATCH libguestfs] build: don't use automake-internal variable * ocaml/Makefile.am (mlguestfs.cma): Use the documented

>From 23740528cd2d75a236aae1fb5d073e8be2e5a295 Mon Sep 17 00:00:00 2001 From: Jim Meyering <meyering at redhat.com> Date: Fri, 28 Aug 2009 13:43:16 +0200 Subject: [PATCH libguestfs 1/3] generator.ml: avoid warnings in generated ocaml/guestfs_c_actions.c * src/generator.ml: Emit prototypes for ocaml_guestfs_* functions, to avoid warnings from gcc -Wmissing-prototypes. Normally we'd put these somewhere else, but in this unusual case, they're not needed anywhere else. Handle the >5-argument case, too, for these: ocaml_guestfs_test0_by...

Patch 1/5 is a repost. Only change is title update. These fix parallel make on my machine, and additionally make building from subdirectories more correct.

...e.am b/ocaml/Makefile.am index bb7407a..4375337 100644 --- a/ocaml/Makefile.am +++ b/ocaml/Makefile.am @@ -15,12 +15,22 @@ # along with this program; if not, write to the Free Software # Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA. +GENERATOR_ML = \ + guestfs.mli \ + guestfs.ml \ + guestfs_c_actions.c \ + bindtests.ml + +.PHONY: force + +$(GENERATOR_ML): force + $(MAKE) -C $(top_builddir)/src stamp-generator + EXTRA_DIST = \ - guestfs.mli guestfs.ml \ - guestfs_c.c guestfs_c.h guestfs_c_actions.c \ + $(GENERATOR_ML) \ + guestfs_c.c guestfs_c.h \ guestfs_inspector.mli guestfs_inspector.ml \...

...isabled-tests list. >From 3d13b4e3062a3b06d9ed3acadb4cb55fb41a05c8 Mon Sep 17 00:00:00 2001 From: Jim Meyering <meyering at redhat.com> Date: Mon, 3 Aug 2009 06:58:16 -0400 Subject: [PATCH 1/4] build: add -I option to get config.h. * ocaml/Makefile.am (AM_CPPFLAGS): Define. (guestfs_c.o, guestfs_c_actions.o): Use it. --- ocaml/Makefile.am | 7 +++++-- 1 files changed, 5 insertions(+), 2 deletions(-) diff --git a/ocaml/Makefile.am b/ocaml/Makefile.am index 12522f2..1aa0cb6 100644 --- a/ocaml/Makefile.am +++ b/ocaml/Makefile.am @@ -28,6 +28,9 @@ SUBDIRS = examples CLEANFILES = *.cmi *.cmo *.cmx...

...ts.c gobject/src/optargs-set_e2attrs.c +gobject/src/optargs-test0.c gobject/src/optargs-tune2fs.c gobject/src/optargs-umount_local.c gobject/src/session.c @@ -180,6 +186,7 @@ inspector/virt-inspector.c java/com_redhat_et_libguestfs_GuestFS.c ocaml/guestfs-c-actions.c ocaml/guestfs-c.c +ocaml/guestfs_c_actions.c perl/Guestfs.c perl/bindtests.pl perl/lib/Sys/Guestfs.pm @@ -197,6 +204,7 @@ src/bindtests.c src/dbdump.c src/errnostring-gperf.c src/errnostring.c +src/errnostring_gperf.c src/events.c src/filearch.c src/fuse.c -- 1.7.11.2.249.g31c7954

This new series condenses all of the previously posted patches into new patch 1/2. The second patch is a new fix for parallel build in the haskell directory.

We observed a while back that the Perl-based libguestfs tools were not being localized. In fact I've tracked this problem down to a regression some time ago and some subsequent changes we made. These two patches fix everything. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones virt-top is 'top' for virtual machines. Tiny program with many

--- cat/Makefile.am | 6 +++--- df/Makefile.am | 2 +- edit/Makefile.am | 2 +- examples/Makefile.am | 12 ++++++------ fish/Makefile.am | 18 +++++++++--------- fuse/Makefile.am | 2 +- inspector/Makefile.am | 2 +- java/examples/Makefile.am | 6 +++--- ocaml/examples/Makefile.am | 6 +++---

At the moment OpenStack uses kpartx and nbd to resize filesystems and inject files to guests. I sincerely hope they don't allow untrusted users to upload guest images / AMIs :-( To fix this I'm looking into adding libguestfs support as an optional backend in OpenStack. The only missing feature in libguestfs is the ability to call tune2fs on a filesystem. This patch series adds tune2fs

...ree.c +df/virt-df.pl fish/alloc.c fish/cmds.c fish/completion.c @@ -8,6 +56,23 @@ fish/fish.c fish/glob.c fish/lcd.c fish/more.c +fish/rc.c +fish/rc_protocol.c +fish/reopen.c +fish/tilde.c fish/time.c -src/guestfs.c +inspector/virt-inspector.pl +java/com_redhat_et_libguestfs_GuestFS.c +ocaml/guestfs_c_actions.c +ocaml/guestfs_c.c +perl/bindtests.pl +perl/Guestfs.c +perl/lib/Sys/Guestfs/Lib.pm +perl/lib/Sys/Guestfs.pm +python/guestfs-py.c +ruby/ext/guestfs/_guestfs.c src/guestfs-actions.c +src/guestfs-bindtests.c +src/guestfs.c +src/guestfs_protocol.c +v2v/virt-v2v.pl diff --git a/po/libguestfs.pot b/po...

...uestfs(3)>, +L<guestfs(3)>, +L<http://libguestfs.org/>, +L<Sys::Virt(3)>, +L<http://libvirt.org/>, +L<guestfish(1)>. + +=cut diff --git a/po/POTFILES.in b/po/POTFILES.in index ca01b3d..694a831 100644 --- a/po/POTFILES.in +++ b/po/POTFILES.in @@ -67,8 +67,18 @@ ocaml/guestfs_c_actions.c ocaml/guestfs_c.c perl/bindtests.pl perl/Guestfs.c +perl/lib/Sys/Guestfs/GuestOS.pm +perl/lib/Sys/Guestfs/GuestOS/RedHat.pm +perl/lib/Sys/Guestfs/HVSource.pm +perl/lib/Sys/Guestfs/HVSource/Xen/Linux.pm +perl/lib/Sys/Guestfs/HVTarget/Linux.pm +perl/lib/Sys/Guestfs/HVTarget.pm perl/lib/Sys/Gues...

Version 1 of the patch, for discussion, but not to be applied. It does work, but needs a lot more testing. This removes all the psychopathic gettextify cruft, and replaces it with a 99 line Makefile.am. A large win, I think. The third patch implements gettext support in the OCaml tools. The fourth patch is just for illustration. It shows the consequent changes to libguestfs.pot and the po

...ritten src/libguestfs.syms written daemon/actions.h written daemon/stubs.c written daemon/names.c written capitests/tests.c written fish/cmds_gperf.gperf written fish/cmds.c written fish/completion.c written fish/guestfish-actions.pod written ocaml/guestfs.mli written ocaml/guestfs.ml written ocaml/guestfs_c_actions.c written perl/Guestfs.xs written perl/lib/Sys/Guestfs.pm written python/guestfs-py.c written python/guestfs.py written ruby/ext/guestfs/_guestfs.c written java/com/redhat/et/libguestfs/GuestFS.java written java/com_redhat_et_libguestfs_GuestFS.c written haskell/Guestfs.hs written csharp/Libguestfs...

...ritten src/libguestfs.syms written daemon/actions.h written daemon/stubs.c written daemon/names.c written capitests/tests.c written fish/cmds_gperf.gperf written fish/cmds.c written fish/completion.c written fish/guestfish-actions.pod written ocaml/guestfs.mli written ocaml/guestfs.ml written ocaml/guestfs_c_actions.c written perl/Guestfs.xs written perl/lib/Sys/Guestfs.pm written python/guestfs-py.c written python/guestfs.py written ruby/ext/guestfs/_guestfs.c written java/com/redhat/et/libguestfs/GuestFS.java written java/com_redhat_et_libguestfs_GuestFS.c written haskell/Guestfs.hs written csharp/Libguestfs...

...ernal-actions.h written src/actions.c written src/guestfs-actions.pod written src/libguestfs.syms written capitests/tests.c written fish/cmds_gperf.gperf written fish/cmds.c written fish/completion.c written fish/guestfish-actions.pod written ocaml/guestfs.mli written ocaml/guestfs.ml written ocaml/guestfs_c_actions.c written perl/Guestfs.xs written perl/lib/Sys/Guestfs.pm written python/guestfs-py.c written python/guestfs.py written ruby/ext/guestfs/_guestfs.c written java/com/redhat/et/libguestfs/GuestFS.java written java/com_redhat_et_libguestfs_GuestFS.c written csharp/Libguestfs.cs written php/extension/p...

...ritten src/libguestfs.syms written daemon/actions.h written daemon/stubs.c written daemon/names.c written capitests/tests.c written fish/cmds_gperf.gperf written fish/cmds.c written fish/completion.c written fish/guestfish-actions.pod written ocaml/guestfs.mli written ocaml/guestfs.ml written ocaml/guestfs_c_actions.c written perl/Guestfs.xs written perl/lib/Sys/Guestfs.pm written python/guestfs-py.c written python/guestfs.py written ruby/ext/guestfs/_guestfs.c written java/com/redhat/et/libguestfs/GuestFS.java written java/com_redhat_et_libguestfs_GuestFS.c written csharp/Libguestfs.cs written php/extension/p...