search for: gerror

I'm currently working on gobject bindings for libguestfs. I haven't got as far as compiling anything yet, but I've attached the C header for initial review. Matt -- Matthew Booth, RHCA, RHCSS Red Hat Engineering, Virtualisation Team GPG ID: D33C3490 GPG FPR: 3733 612D 2D05 5458 8A8A 1600 3441 EA19 D33C 3490 -------------- next part -------------- An embedded and

...r -Wno-long-long -fno-gnu-keywords -g -O2 -MT queryparser_internal.lo -MD -MP -MF .deps/queryparser_internal.Tpo -c queryparser_internal.cc -fPIC -DPIC -o .libs/queryparser_internal.o In file included from /usr/include/glib-2.0/glib/gquark.h:30, from /usr/include/glib-2.0/glib/gerror.h:24, from /usr/include/glib-2.0/glib/gunicode.h:25, from accentnormalisingitor.h:22, from /u1/olly/xapian-svn-snapshot/trunk/xapian/xapian-core/queryparser/queryparser.lemony:24: /usr/include/glib-2.0/glib/gtypes.h:30:24: glibconfig.h: No such fi...

...long-long -fno-gnu-keywords -O2 -g -pipe -m64 -MT queryparser_internal.lo -MD -MP -MF .deps/queryparser_internal.Tpo -c queryparser_internal.cc -fPIC -DPIC -o .libs/queryparser_internal.o In file included from /usr/include/glib-2.0/glib/gquark.h:30, from /usr/include/glib-2.0/glib/gerror.h:24, from /usr/include/glib-2.0/glib/gunicode.h:25, from accentnormalisingitor.h:22, from /u1/olly/xapian-svn-snapshot/tags/0.9.4/xapian/xapian-core/queryparser/queryparser.lemony:24: /usr/include/glib-2.0/glib/gtypes.h:30:24: glibconfig.h: No suc...

The main goal of these patch series is to implement a new API that allows to retrieve created device-mapper devices for volumes and partitions back after they have been created. As part of this patch: - required libdevmapper version was bumped to 1.02. I think it is safe because it was released more then 10 years ago; - newer version of libdevmapper allowed to simplify code base a little bit; -

RConstOptString cannot return an error in the C api. This makes it a special case for the GObject api, as all other return types have a corresponding GError **err argument to return an error. This change removes this special case, and includes the possibility of an error return in the API. An error is indicated by setting *err to a non-NULL value. This change is in preparation for adding a close api. An attempt to call any api, even RConstOptString, o...

...ould use #SwfdecGtkLoader + * directly and use its error property. * This function calls swfdec_init () for you if it wasn't called before. * - * Returns: a new player or %NULL on error. + * Returns: a new player. **/ SwfdecPlayer * -swfdec_gtk_player_new_from_file (const char *filename, GError **error) +swfdec_gtk_player_new_from_file (const char *uri) { SwfdecLoader *loader; SwfdecPlayer *player; - g_return_val_if_fail (filename != NULL, NULL); + g_return_val_if_fail (uri != NULL, NULL); - loader = swfdec_loader_new_from_file (filename, error); - if (loader == NULL) -...

...ere are a couple of points in here I'm still not 100% happy with. Specifically the handling of FBuffer and the Cancellable flag. Both are explained below. I'm interested in suggestions. Return values: ************** All functions which can return an error have as their final argument a GError **. GI maps this to the appropriate error mechanism for each target language. RErr returns a gboolean, true = success, false = failure. The following types return the value from libguestfs unchanged: RInt RInt64 RBool RConstString (transfer none): gobject doesn't manage returne...

--- generator/generator_gobject.ml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/generator/generator_gobject.ml b/generator/generator_gobject.ml index e4c175b..48ddbf0 100644 --- a/generator/generator_gobject.ml +++ b/generator/generator_gobject.ml @@ -391,7 +391,7 @@ let generate_gobject_optargs_source name optargs flags () = pr "G_DEFINE_TYPE(%s, guestfs_%s,

...2 insertions(+), 2 deletions(-) diff --git a/src/ldm.c b/src/ldm.c index 19a0663..372b0d7 100644 --- a/src/ldm.c +++ b/src/ldm.c @@ -2615,7 +2615,7 @@ _dm_create_part(const LDMPartitionPrivate * const part, uint32_t cookie, static GString * _dm_create_spanned(const LDMVolumePrivate * const vol, GError ** const err) { - static GString *name = NULL; + GString *name = NULL; guint i = 0; struct dm_target *targets = g_malloc(sizeof(*targets) * vol->parts->len); @@ -2682,7 +2682,7 @@ out: static GString * _dm_create_striped(const LDMVolumePrivate * const vol, GError ** const...

...3 insertions(+), 3 deletions(-) diff --git a/src/ldm.c b/src/ldm.c index 19a0663..e112ae0 100644 --- a/src/ldm.c +++ b/src/ldm.c @@ -2615,7 +2615,7 @@ _dm_create_part(const LDMPartitionPrivate * const part, uint32_t cookie, static GString * _dm_create_spanned(const LDMVolumePrivate * const vol, GError ** const err) { - static GString *name = NULL; + GString *name = NULL; guint i = 0; struct dm_target *targets = g_malloc(sizeof(*targets) * vol->parts->len); @@ -2682,7 +2682,7 @@ out: static GString * _dm_create_striped(const LDMVolumePrivate * const vol, GError ** const...

v1 was here: https://www.redhat.com/archives/libguestfs/2018-May/msg00058.html v2: - more correct explanation of a crash reason. Mykola Ivanets (1): Fix crash while creating mapper for a volume which lacks of partitions. src/ldm.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) -- 2.17.0

...git a/libswfdec/swfdec_buffer.c b/libswfdec/swfdec_buffer.c index 2c43f9d..7c86316 100644 --- a/libswfdec/swfdec_buffer.c +++ b/libswfdec/swfdec_buffer.c @@ -240,9 +240,9 @@ swfdec_buffer_free_mapped (unsigned char *data, gpointer priv) * @filename: file to read * @error: return location for a #GError or %NULL * - * Tries to create a buffer for the given @filename using a #GMappedFile. If - * the creation fails, %NULL is returned and @error is set. The error can be - * any of the errors that are valid from g_mapped_file_new(). + * Creates a buffer containing the contents of the given file. If...

This patch replaces patches 14 and 15 from my previous series. The gtk-doc output is now reasonable, and we can rely on an automatically generated guestfs-sections.txt. Matt

In an effort to reduce the code, start to use few bits of GLib: - replace the gnulib c-type module - replace the gnulib getprogname module - use g_spawn_sync to launch curl, and drop a file reading function Pino Toscano (6): Include glib.h in p2v.h Use g_ascii_isspace instead of c_isspace from gnulib Use g_get_prgname instead of getprogname from gnulib build: remove no more used gnulib

--- configure.ac | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/configure.ac b/configure.ac index 469ea96..0e7e2ea 100644 --- a/configure.ac +++ b/configure.ac @@ -85,14 +85,14 @@ PKG_CHECK_MODULES([GIO_UNIX], [gio-unix-2.0 >= 2.32.0], ] ) -PKG_CHECK_MODULES([ZLIB], [zlib >= 1.2.5], +PKG_CHECK_MODULES([ZLIB], [zlib >= 1.2], [

...s. --- generator/gobject.ml | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/generator/gobject.ml b/generator/gobject.ml index 5b07edd..e563610 100644 --- a/generator/gobject.ml +++ b/generator/gobject.ml @@ -961,7 +961,8 @@ guestfs_session_close (GuestfsSession *session, GError **err) fun ({ name = name; style = (ret, args, optargs as style); cancellable = cancellable; c_function = c_function; c_optarg_prefix = c_optarg_prefix; - shortdesc = shortdesc; longdesc = longdesc } as f) -> + shortdesc = shortdesc; longdesc = lo...

...k/swfdec_gtk_player.c index 475cd3f..60d391b 100644 --- a/libswfdec-gtk/swfdec_gtk_player.c +++ b/libswfdec-gtk/swfdec_gtk_player.c @@ -188,7 +188,7 @@ swfdec_gtk_player_new (void) * Returns: a new player or %NULL on error. **/ SwfdecPlayer * -swfdec_player_new_from_file (const char *filename, GError **error) +swfdec_gtk_player_new_from_file (const char *filename, GError **error) { SwfdecLoader *loader; SwfdecPlayer *player;

...b 17 12:54:23 2007 +0100 implement --variables or -v flag to provide Flash variables diff --git a/player/swfdebug.c b/player/swfdebug.c index 63af21d..e1f0cbd 100644 --- a/player/swfdebug.c +++ b/player/swfdebug.c @@ -307,11 +307,13 @@ main (int argc, char *argv[]) SwfdecPlayer *player; GError *error = NULL; gboolean use_image = FALSE; + char *variables = NULL; GOptionEntry options[] = { { "scale", 's', 0, G_OPTION_ARG_INT, &ret, "scale factor", "PERCENT" }, { "image", 'i', 0, G_OPTION_ARG_NONE, &use_image...

...from Ruuid.h:5, from Rinit.c:1: /usr/local/include/glib-2.0/glib/garray.h:32: error: parse error before "G_BEGIN_DECLS" /usr/local/include/glib-2.0/glib/garray.h:34: error: syntax error before "typedef" In file included from /usr/local/include/glib-2.0/glib/gerror.h:24, from /usr/local/include/glib-2.0/glib/gthread.h:30, from /usr/local/include/glib-2.0/glib/gasyncqueue.h:30, from /usr/local/include/glib-2.0/glib.h:32, from uuidP.h:33, from Ruuid.h:5,...

...f not, write to the Free Software - * Foundation, Inc., 51 Franklin Street, Fifth Floor, - * Boston, MA 02110-1301 USA - */ - -#ifdef HAVE_CONFIG_H -#include "config.h" -#endif - -#include <libswfdec/swfdec.h> - -int -main (int argc, char **argv) -{ - GOptionContext *context; - GError *err; - SwfdecPlayer *player; - SwfdecLoader *loader; - guint i; - cairo_surface_t *surface; - cairo_t *cr; - gboolean aborts; - glong play_per_file = 30; - glong max_per_file = 60; - glong max_per_advance = 10; - GTimer *timer; - char **filenames = NULL; - const GOptionEntry entries[]...